Add "Quanta ACER HD User Facing" devices.
Subsystems (2)
PATCH 1/1 Add "Quanta ACER HD User Facing" devices.
This patch adds two built-in video cameras for Acer laptops.
--- drivers/media/usb/uvc/uvc_driver.c | 23 +++++++++++++++++++++++ 1 file changed, 23 insertions(+)
drivers/media/usb/uvc/uvc_driver.c +23 -0
@@ -2454,6 +2454,29 @@ static const struct usb_device_id uvc_ids[] = { .bInterfaceSubClass = 1, .bInterfaceProtocol = UVC_PC_PROTOCOL_15, .driver_info = (kernel_ulong_t)&uvc_ctrl_power_line_limited }, +/* Quanta ACER HD User Facing 0x4035 */ + { .match_flags = USB_DEVICE_ID_MATCH_DEVICE + | USB_DEVICE_ID_MATCH_INT_INFO, + .idVendor = 0x0408, + .idProduct = 0x4035, + .bInterfaceClass = USB_CLASS_VIDEO, + .bInterfaceSubClass = 1, + .bInterfaceProtocol = UVC_PC_PROTOCOL_15, + .driver_info = (kernel_ulong_t) &(const struct uvc_device_info ) { + .uvc_version =0x010a , + } + }, + /* Quanta ACER HD User Facing 4033 */ + { .match_flags = USB_DEVICE_ID_MATCH_DEVICE + | USB_DEVICE_ID_MATCH_INT_INFO, + .idVendor = 0x0408, + .idProduct = 0x4033, + .bInterfaceClass = USB_CLASS_VIDEO, + .bInterfaceSubClass = 1, + .bInterfaceProtocol = UVC_PC_PROTOCOL_15, + .driver_info = (kernel_ulong_t) &(const struct uvc_device_info ) { + .uvc_version =0x010a , } + }, /* LogiLink Wireless Webcam */ { .match_flags = USB_DEVICE_ID_MATCH_DEVICE | USB_DEVICE_ID_MATCH_INT_INFO,
Signature · 1 line
2.44.0
Hi Ilyas
Quoted 5 lines · Ilyas Erezhepov
This patch adds two built-in video cameras for Acer laptops.
Signed-off-by Ilyas Erezhepov <[email protected]>Signed-off-by Laurent Pinchart <[email protected]>
May I ask where Laurent reviewed the patch?
I am trying to find it in linux-media and I am not able to find it
Quoted 43 lines
--- drivers/media/usb/uvc/uvc_driver.c | 23 +++++++++++++++++++++++ 1 file changed, 23 insertions(+)drivers/media/usb/uvc/uvc_driver.c +23
-1@@ -2454,6 +2454,29 @@ static const struct usb_device_id uvc_ids[] = { .bInterfaceSubClass = 1, .bInterfaceProtocol = UVC_PC_PROTOCOL_15, .driver_info = (kernel_ulong_t)&uvc_ctrl_power_line_limited }, +/* Quanta ACER HD User Facing 0x4035 */ + { .match_flags = USB_DEVICE_ID_MATCH_DEVICE + | USB_DEVICE_ID_MATCH_INT_INFO, + .idVendor = 0x0408, + .idProduct = 0x4035, + .bInterfaceClass = USB_CLASS_VIDEO, + .bInterfaceSubClass = 1, + .bInterfaceProtocol = UVC_PC_PROTOCOL_15, + .driver_info = (kernel_ulong_t) &(const struct uvc_device_info ) { + .uvc_version =0x010a , + } + }, + /* Quanta ACER HD User Facing 4033 */ + { .match_flags = USB_DEVICE_ID_MATCH_DEVICE + | USB_DEVICE_ID_MATCH_INT_INFO, + .idVendor = 0x0408, + .idProduct = 0x4033, + .bInterfaceClass = USB_CLASS_VIDEO, + .bInterfaceSubClass = 1, + .bInterfaceProtocol = UVC_PC_PROTOCOL_15, + .driver_info = (kernel_ulong_t) &(const struct uvc_device_info ) { + .uvc_version =0x010a , } + }, /* LogiLink Wireless Webcam */ { .match_flags = USB_DEVICE_ID_MATCH_DEVICE | USB_DEVICE_ID_MATCH_INT_INFO, --2.44.0
Signature · 1 line
Ricardo Ribalda
A message that is not in the archive (sent off-list or not yet received): [email protected]
Hi Ильяс
Quoted 4 lines · Ильяс Эреджепов
Hi Ricardo
I thought he was on the list of people who should see this patch.
Adding him as CC: ot To: should be enough.
Signed-off-by: means that the person has reviewed and approved the patch, it can only be added by the actual person who did the review
Quoted 4 lines
I asked Laurent how to send a patch correctly.
Do I need to send a new letter that is signed only by me?
Yes please, and I think that you should only add 0x4033, there is a patch already under review for 0x4035.
https://lore.kernel.org/linux-media/[email protected]/
When you send the patch, please add the output of lsusb -v of the device.
Thanks!
Quoted 57 lines · Ricardo Ribalda
Quoted 55 lines
Hi Ilyas
Quoted 4 lines · Ilyas Erezhepov
This patch adds two built-in video cameras for Acer laptops.
Signed-off-by Ilyas Erezhepov <[email protected]>Signed-off-by Laurent Pinchart <[email protected]>May I ask where Laurent reviewed the patch?
I am trying to find it in linux-media and I am not able to find it
Quoted 42 lines
--- drivers/media/usb/uvc/uvc_driver.c | 23 +++++++++++++++++++++++ 1 file changed, 23 insertions(+)drivers/media/usb/uvc/uvc_driver.c +23
-1@@ -2454,6 +2454,29 @@ static const struct usb_device_id uvc_ids[] = { .bInterfaceSubClass = 1, .bInterfaceProtocol = UVC_PC_PROTOCOL_15, .driver_info = (kernel_ulong_t)&uvc_ctrl_power_line_limited }, +/* Quanta ACER HD User Facing 0x4035 */ + { .match_flags = USB_DEVICE_ID_MATCH_DEVICE + | USB_DEVICE_ID_MATCH_INT_INFO, + .idVendor = 0x0408, + .idProduct = 0x4035, + .bInterfaceClass = USB_CLASS_VIDEO, + .bInterfaceSubClass = 1, + .bInterfaceProtocol = UVC_PC_PROTOCOL_15, + .driver_info = (kernel_ulong_t) &(const struct uvc_device_info ) { + .uvc_version =0x010a , + } + }, + /* Quanta ACER HD User Facing 4033 */ + { .match_flags = USB_DEVICE_ID_MATCH_DEVICE + | USB_DEVICE_ID_MATCH_INT_INFO, + .idVendor = 0x0408, + .idProduct = 0x4033, + .bInterfaceClass = USB_CLASS_VIDEO, + .bInterfaceSubClass = 1, + .bInterfaceProtocol = UVC_PC_PROTOCOL_15, + .driver_info = (kernel_ulong_t) &(const struct uvc_device_info ) { + .uvc_version =0x010a , } + }, /* LogiLink Wireless Webcam */ { .match_flags = USB_DEVICE_ID_MATCH_DEVICE | USB_DEVICE_ID_MATCH_INT_INFO, --2.44.0
Signature · 1 line
Ricardo Ribalda