ksmbd: fix uninitialized symbol 'share' in smb2_tree_connect()
Subsystems (2)
Namjae Jeon
maintainerPATCH 1/1 ksmbd: fix uninitialized symbol 'share' in smb2_tree_connect()
Fix uninitialized symbol 'share' in smb2_tree_connect().
Fixes e9d8c2f95ab8 ("ksmbd: add continuous availability share parameter")
Reported-by kernel test robot <[email protected]>
Reported-by Dan Carpenter <[email protected]>
Signed-off-by Namjae Jeon <[email protected]>
--- fs/smb/server/smb2pdu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
fs/smb/server/smb2pdu.c +2 -2
@@ -1926,7 +1926,7 @@ int smb2_tree_connect(struct ksmbd_work *work)struct ksmbd_session *sess = work->sess;char *treename =NULL , *name =NULL ;struct ksmbd_tree_conn_status status; -struct ksmbd_share_config *share; +struct ksmbd_share_config *share =NULL ;int rc = -EINVAL ;WORK_BUFFERS (work, req, rsp);
@@ -1988,7 +1988,7 @@ int smb2_tree_connect(struct ksmbd_work *work)write_unlock (&sess->tree_conns_lock); rsp->StructureSize =cpu_to_le16 (16 ); out_err1: -if (server_conf.flags &KSMBD_GLOBAL_FLAG_DURABLE_HANDLE && +if (server_conf.flags &KSMBD_GLOBAL_FLAG_DURABLE_HANDLE && share &&test_share_config_flag (share,KSMBD_SHARE_FLAG_CONTINUOUS_AVAILABILITY )) rsp->Capabilities =SMB2_SHARE_CAP_CONTINUOUS_AVAILABILITY ;
Signature · 1 line
2.25.1