Skip to contentSkip to conversation

drm/amdgpu: IB test encode test package change for VCN5

PATCH In review Sonny Jiang 3 participants 5 messages Apr 25, 2024 – Apr 29, 2024

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 drm/amdgpu: IB test encode test package change for VCN5

From: Sonny Jiang <[email protected]>

VCN5 session info package interface changed

---
 drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c +2 -2
index 677eb141554e..b89605b400c0 100644
@@ -885,7 +885,7 @@ static int amdgpu_vcn_enc_get_create_msg(struct amdgpu_ring *ring, uint32_t hand
 	ib->ptr[ib->length_dw++] = handle;
 	ib->ptr[ib->length_dw++] = upper_32_bits(addr);
 	ib->ptr[ib->length_dw++] = addr;
-	ib->ptr[ib->length_dw++] = 0x0000000b;
+	ib->ptr[ib->length_dw++] = 0x00000000;
 
 	ib->ptr[ib->length_dw++] = 0x00000014;
 	ib->ptr[ib->length_dw++] = 0x00000002; /* task info */
@@ -952,7 +952,7 @@ static int amdgpu_vcn_enc_get_destroy_msg(struct amdgpu_ring *ring, uint32_t han
 	ib->ptr[ib->length_dw++] = handle;
 	ib->ptr[ib->length_dw++] = upper_32_bits(addr);
 	ib->ptr[ib->length_dw++] = addr;
-	ib->ptr[ib->length_dw++] = 0x0000000b;
+	ib->ptr[ib->length_dw++] = 0x00000000;
 
 	ib->ptr[ib->length_dw++] = 0x00000014;
 	ib->ptr[ib->length_dw++] = 0x00000002;
Signature · 1 line
2.43.2
#1 lore raw

[AMD Official Use Only - General]

By tests, I didn't find error on VCN1 to VCN4.

Thanks,
Sonny

________________________________
From: Jiang, Sonny <[email protected]>
Sent: Thursday, April 25, 2024 4:10 PM
To: [email protected] <[email protected]>
Cc: Jiang, Sonny <[email protected]>; Jiang, Sonny <[email protected]>
Subject: [PATCH v3] drm/amdgpu: IB test encode test package change for VCN5

From: Sonny Jiang <[email protected]>

VCN5 session info package interface changed

---
 drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c +2 -2
index 677eb141554e..b89605b400c0 100644
@@ -885,7 +885,7 @@ static int amdgpu_vcn_enc_get_create_msg(struct amdgpu_ring *ring, uint32_t hand
         ib->ptr[ib->length_dw++] = handle;
         ib->ptr[ib->length_dw++] = upper_32_bits(addr);
         ib->ptr[ib->length_dw++] = addr;
-       ib->ptr[ib->length_dw++] = 0x0000000b;
+       ib->ptr[ib->length_dw++] = 0x00000000;
 
         ib->ptr[ib->length_dw++] = 0x00000014;
         ib->ptr[ib->length_dw++] = 0x00000002; /* task info */
@@ -952,7 +952,7 @@ static int amdgpu_vcn_enc_get_destroy_msg(struct amdgpu_ring *ring, uint32_t han
         ib->ptr[ib->length_dw++] = handle;
         ib->ptr[ib->length_dw++] = upper_32_bits(addr);
         ib->ptr[ib->length_dw++] = addr;
-       ib->ptr[ib->length_dw++] = 0x0000000b;
+       ib->ptr[ib->length_dw++] = 0x00000000;
 
         ib->ptr[ib->length_dw++] = 0x00000014;
         ib->ptr[ib->length_dw++] = 0x00000002;

--
2.43.2

#2 lore raw

[AMD Official Use Only - General]

Ping.

Sonny
________________________________
From: Jiang, Sonny <[email protected]>
Sent: Thursday, April 25, 2024 4:12 PM
To: [email protected] <[email protected]>
Subject: Re: [PATCH v3] drm/amdgpu: IB test encode test package change for VCN5

By tests, I didn't find error on VCN1 to VCN4.

Thanks,
Sonny

________________________________
From: Jiang, Sonny <[email protected]>
Sent: Thursday, April 25, 2024 4:10 PM
To: [email protected] <[email protected]>
Cc: Jiang, Sonny <[email protected]>; Jiang, Sonny <[email protected]>
Subject: [PATCH v3] drm/amdgpu: IB test encode test package change for VCN5

From: Sonny Jiang <[email protected]>

VCN5 session info package interface changed

---
 drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c +2 -2
index 677eb141554e..b89605b400c0 100644
@@ -885,7 +885,7 @@ static int amdgpu_vcn_enc_get_create_msg(struct amdgpu_ring *ring, uint32_t hand
         ib->ptr[ib->length_dw++] = handle;
         ib->ptr[ib->length_dw++] = upper_32_bits(addr);
         ib->ptr[ib->length_dw++] = addr;
-       ib->ptr[ib->length_dw++] = 0x0000000b;
+       ib->ptr[ib->length_dw++] = 0x00000000;
 
         ib->ptr[ib->length_dw++] = 0x00000014;
         ib->ptr[ib->length_dw++] = 0x00000002; /* task info */
@@ -952,7 +952,7 @@ static int amdgpu_vcn_enc_get_destroy_msg(struct amdgpu_ring *ring, uint32_t han
         ib->ptr[ib->length_dw++] = handle;
         ib->ptr[ib->length_dw++] = upper_32_bits(addr);
         ib->ptr[ib->length_dw++] = addr;
-       ib->ptr[ib->length_dw++] = 0x0000000b;
+       ib->ptr[ib->length_dw++] = 0x00000000;
 
         ib->ptr[ib->length_dw++] = 0x00000014;
         ib->ptr[ib->length_dw++] = 0x00000002;

--
2.43.2

Reviewed-by Ruijing Dong [email protected]
#3 lore raw

[AMD Official Use Only - General]

Thanks,
Ruijing

From: amd-gfx <[email protected]> On Behalf Of Jiang, Sonny
Sent: Monday, April 29, 2024 9:49 AM
To: [email protected]
Subject: Re: [PATCH v3] drm/amdgpu: IB test encode test package change for VCN5

[AMD Official Use Only - General]

[AMD Official Use Only - General]

Ping.

Sonny
________________________________
From: Jiang, Sonny <[email protected]<mailto:[email protected]>>
Sent: Thursday, April 25, 2024 4:12 PM
To: [email protected]<mailto:[email protected]> <[email protected]<mailto:[email protected]>>
Subject: Re: [PATCH v3] drm/amdgpu: IB test encode test package change for VCN5

By tests, I didn't find error on VCN1 to VCN4.

Thanks,
Sonny

________________________________
From: Jiang, Sonny <[email protected]<mailto:[email protected]>>
Sent: Thursday, April 25, 2024 4:10 PM
To: [email protected]<mailto:[email protected]> <[email protected]<mailto:[email protected]>>
Cc: Jiang, Sonny <[email protected]<mailto:[email protected]>>; Jiang, Sonny <[email protected]<mailto:[email protected]>>
Subject: [PATCH v3] drm/amdgpu: IB test encode test package change for VCN5

From: Sonny Jiang <[email protected]<mailto:[email protected]>>

VCN5 session info package interface changed

---
 drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c +2 -2
index 677eb141554e..b89605b400c0 100644
@@ -885,7 +885,7 @@ static int amdgpu_vcn_enc_get_create_msg(struct amdgpu_ring *ring, uint32_t hand
         ib->ptr[ib->length_dw++] = handle;
         ib->ptr[ib->length_dw++] = upper_32_bits(addr);
         ib->ptr[ib->length_dw++] = addr;
-       ib->ptr[ib->length_dw++] = 0x0000000b;
+       ib->ptr[ib->length_dw++] = 0x00000000;
 
         ib->ptr[ib->length_dw++] = 0x00000014;
         ib->ptr[ib->length_dw++] = 0x00000002; /* task info */
@@ -952,7 +952,7 @@ static int amdgpu_vcn_enc_get_destroy_msg(struct amdgpu_ring *ring, uint32_t han
         ib->ptr[ib->length_dw++] = handle;
         ib->ptr[ib->length_dw++] = upper_32_bits(addr);
         ib->ptr[ib->length_dw++] = addr;
-       ib->ptr[ib->length_dw++] = 0x0000000b;
+       ib->ptr[ib->length_dw++] = 0x00000000;
 
         ib->ptr[ib->length_dw++] = 0x00000014;
         ib->ptr[ib->length_dw++] = 0x00000002;

--
2.43.2

Reviewed-by on v3 1/1
#4 lore raw
In reply to Sonny Jiang

[AMD Official Use Only - General]

Quoted 45 lines

-----Original Message-----
From: amd-gfx <[email protected]> On Behalf Of Sonny Jiang
Sent: Thursday, April 25, 2024 4:11 PM
To: [email protected]
Cc: Jiang, Sonny <[email protected]>; Jiang, Sonny <[email protected]>
Subject: [PATCH v3] drm/amdgpu: IB test encode test package change for VCN5

From: Sonny Jiang <[email protected]>

VCN5 session info package interface changed

---
 drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c +0 -0
index 677eb141554e..b89605b400c0 100644
@@ -885,7 +885,7 @@ static int amdgpu_vcn_enc_get_create_msg(struct

amdgpu_ring *ring, uint32_t hand

      ib->ptr[ib->length_dw++] = handle;
      ib->ptr[ib->length_dw++] = upper_32_bits(addr);
      ib->ptr[ib->length_dw++] = addr;
drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c +2 -1
-     ib->ptr[ib->length_dw++] = 0x0000000b;
+     ib->ptr[ib->length_dw++] = 0x00000000;
 
      ib->ptr[ib->length_dw++] = 0x00000014;
      ib->ptr[ib->length_dw++] = 0x00000002; /* task info */ @@ -952,7
+952,7 @@ static int amdgpu_vcn_enc_get_destroy_msg(struct amdgpu_ring

*ring, uint32_t han

      ib->ptr[ib->length_dw++] = handle;
      ib->ptr[ib->length_dw++] = upper_32_bits(addr);
      ib->ptr[ib->length_dw++] = addr;
drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c +1 -2
-     ib->ptr[ib->length_dw++] = 0x0000000b;
+     ib->ptr[ib->length_dw++] = 0x00000000;
 
      ib->ptr[ib->length_dw++] = 0x00000014;
      ib->ptr[ib->length_dw++] = 0x00000002;
--

2.43.2