drm/amd/pm: fix the uninitialized scalar variable waring
Subsystems (3)
PATCH 1/2 drm/amd/pm: fix the uninitialized scalar variable waring
Initialize variable size before calling hwmgr->hwmgr_func->iread_sensor, such as smu7_read_sensor.
--- drivers/gpu/drm/amd/pm/powerplay/amd_powerplay.c | 1 + 1 file changed, 1 insertion(+)
drivers/gpu/drm/amd/pm/powerplay/amd_powerplay.c +1 -0
@@ -102,6 +102,7 @@ static void pp_swctf_delayed_work_handler(struct work_struct *work)uint32_t gpu_temperature, size;int ret; + size =sizeof (gpu_temperature);/* * If the hotspot/edge temperature is confirmed as below SW CTF setting point * after the delay enforced, nothing will be done.
Signature · 1 line
2.25.1
[AMD Official Use Only - General]
This patch is,
Best Regards,
Tim Huang
Quoted 35 lines
-----Original Message-----
From: Jesse Zhang <[email protected]>
Sent: Friday, April 26, 2024 5:52 PM
To: [email protected]
Cc: Deucher, Alexander <[email protected]>; Koenig, Christian <[email protected]>; Huang, Tim <[email protected]>; Zhang, Jesse(Jie) <[email protected]>; Zhang, Jesse(Jie) <[email protected]>
Subject: [PATCH 1/2] drm/amd/pm: fix the uninitialized scalar variable waringInitialize variable size before calling
hwmgr->hwmgr_func->iread_sensor, such assmu7_read_sensor.Signed-off-by Jesse Zhang <[email protected]>--- drivers/gpu/drm/amd/pm/powerplay/amd_powerplay.c | 1 + 1 file changed, 1 insertion(+)drivers/gpu/drm/amd/pm/powerplay/amd_powerplay.c +1
-0@@ -102,6 +102,7 @@ static void pp_swctf_delayed_work_handler(struct work_struct *work)uint32_t gpu_temperature, size;int ret; + size =sizeof (gpu_temperature);/* * If the hotspot/edge temperature is confirmed as below SW CTF setting point
* after the delay enforced, nothing will be done.
--
2.25.1
[AMD Official Use Only - General]
-----Original Message-----
From: amd-gfx <[email protected]> On Behalf Of Jesse Zhang
Sent: Friday, April 26, 2024 5:52 PM
To: [email protected]
Cc: Deucher, Alexander <[email protected]>; Koenig, Christian <[email protected]>; Huang, Tim <[email protected]>; Zhang, Jesse(Jie) <[email protected]>; Zhang, Jesse(Jie) <[email protected]>
Subject: [PATCH 1/2] drm/amd/pm: fix the uninitialized scalar variable waring
Initialize variable size before calling hwmgr->hwmgr_func->iread_sensor, such as smu7_read_sensor.
--- drivers/gpu/drm/amd/pm/powerplay/amd_powerplay.c | 1 + 1 file changed, 1 insertion(+)
drivers/gpu/drm/amd/pm/powerplay/amd_powerplay.c +1 -0
@@ -102,6 +102,7 @@ static void pp_swctf_delayed_work_handler(struct work_struct *work)uint32_t gpu_temperature, size;int ret; + size =sizeof (gpu_temperature);
[Kevin]:
You can directly initialize during the declaration phase to avoid reassignment.
With fixed, the patch is
Best Regards,
Kevin
/*
* If the hotspot/edge temperature is confirmed as below SW CTF setting point
* after the delay enforced, nothing will be done.
--
2.25.1