Skip to contentSkip to conversation

arm64: dts: ti: k3-am625-sk: Add bootph-all property in phy_gmii_sel node

PATCH Superseded Chintan Vankar 2 participants 6 messages Apr 29, 2024

Subsystems (2)

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 arm64: dts: ti: k3-am625-sk: Add bootph-all property in phy_gmii_sel node

Add missing bootph-all property for CPSW MAC's PHY node phy_gmii_sel.

---

This patch is based on linux-next tagged next-20240426.

Link to v1:
https://lore.kernel.org/r/[email protected]/

Changes from v1 to v2:
- Removed "bootph-all" property from "k3-am62-main.dtsi" and added it to "k3-am625-sk.dts".

 arch/arm64/boot/dts/ti/k3-am625-sk.dts | 4 ++++
 1 file changed, 4 insertions(+)
arch/arm64/boot/dts/ti/k3-am625-sk.dts +4 -0
index ae81ebb39d02..58b70a760648 100644
@@ -297,3 +297,7 @@ partition@3fc0000 {
 &tlv320aic3106 {
 	DVDD-supply = <&vcc_1v8>;
 };
+
+&phy_gmii_sel {
+	bootph-all;
+};
Signature · 1 line
2.34.1
#1 lore raw

arch/arm64/boot/dts/ti/k3-am625-sk.dts partition@3fc0000 { · line 303

Quoted 13 lines · Chintan Vankar
arch/arm64/boot/dts/ti/k3-am625-sk.dts +4 -0
index ae81ebb39d02..58b70a760648 100644
@@ -297,3 +297,7 @@ partition@3fc0000 {
 &tlv320aic3106 {
 	DVDD-supply = <&vcc_1v8>;
 };
+
+&phy_gmii_sel {
+	bootph-all;
+};

Are you sure you kept proper ordering of nodes or just stuffed this to the end?

Best regards,
Krzysztof

#2 lore raw
Quoted 2 lines · Krzysztof Kozlowski

Are you sure you kept proper ordering of nodes or just stuffed this to the end?

Yes, I added this node at the end.

#3 lore raw
Quoted 7 lines · Chintan Vankar
Quoted 2 lines · Krzysztof Kozlowski

Are you sure you kept proper ordering of nodes or just stuffed this to the end?

Yes, I added this node at the end.

Is it okay to add it at the end or it should be defined after "cpsw3g" node ?

#4 lore raw
Quoted 5 lines · Chintan Vankar
Quoted 2 lines · Chintan Vankar
Quoted 8 lines
Quoted 5 lines · Krzysztof Kozlowski
Quoted 2 lines

Are you sure you kept proper ordering of nodes or just stuffed this to the end?

Yes, I added this node at the end.

Is it okay to add it at the end or it should be defined after "cpsw3g" node ?

What is the ordering for this subarch? What does the DTS coding style say?

Best regards,
Krzysztof

#5 lore raw
Quoted 10 lines · Krzysztof Kozlowski
Quoted 9 lines · Chintan Vankar
Quoted 6 lines · Chintan Vankar
Quoted 2 lines · Krzysztof Kozlowski

Are you sure you kept proper ordering of nodes or just stuffed this to the end?

Quoted 7 lines
Quoted 4 lines
Quoted 1 line

Yes, I added this node at the end.

Is it okay to add it at the end or it should be defined after "cpsw3g" node ?

What is the ordering for this subarch? What does the DTS coding style say?

I tried to verify the order this file is following from DTS coding style documentation, but it seems it is not following the order mentioned in Documentation.

Since we will need the same functionality for "am62x-lpsk" board I am planning to add this node in "k3-am62x-sk-common.dtsi". In that file I will follow the same order as it is followed in "k3-am62-main.dtsi".

Quoted 3 lines

Best regards,
Krzysztof