Skip to contentSkip to conversation

drm/amd/pm: fix warning using uninitialized value of max_vid_step

PATCH In review Jesse Zhang 2 participants 2 messages Apr 29, 2024

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 drm/amd/pm: fix warning using uninitialized value of max_vid_step

Check the return of pp_atomfwctrl_get_Voltage_table_v4 as it may fail to initialize max_vid_step
V2: change the check condition (Tim Huang)

---
 drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega10_hwmgr.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega10_hwmgr.c +4 -1
index b602059436a8..d004cdbe97b4 100644
@@ -2573,8 +2573,11 @@ static int vega10_init_smc_table(struct pp_hwmgr *hwmgr)
 		}
 	}
 
-	pp_atomfwctrl_get_voltage_table_v4(hwmgr, VOLTAGE_TYPE_VDDC,
+	result = pp_atomfwctrl_get_voltage_table_v4(hwmgr, VOLTAGE_TYPE_VDDC,
 			VOLTAGE_OBJ_SVID2,  &voltage_table);
+	PP_ASSERT_WITH_CODE(!result,
+			"Failed to get voltage table!",
+			return result);
 	pp_table->MaxVidStep = voltage_table.max_vid_step;
 
 	pp_table->GfxDpmVoltageMode =
Signature · 1 line
2.25.1
Reviewed-by on v2 1/1
#1 lore raw

[Public]

Best Regards,
Tim Huang

Quoted 41 lines

-----Original Message-----
From: Jesse Zhang <[email protected]>
Sent: Monday, April 29, 2024 3:29 PM
To: [email protected]
Cc: Deucher, Alexander <[email protected]>; Koenig, Christian <[email protected]>; Huang, Tim <[email protected]>; Zhang, Jesse(Jie) <[email protected]>; Zhang, Jesse(Jie) <[email protected]>
Subject: [PATCH V2] drm/amd/pm: fix warning using uninitialized value of max_vid_step

Check the return of pp_atomfwctrl_get_Voltage_table_v4 as it may fail to initialize max_vid_step
V2: change the check condition (Tim Huang)

---
 drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega10_hwmgr.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega10_hwmgr.c +4 -1
index b602059436a8..d004cdbe97b4 100644
@@ -2573,8 +2573,11 @@ static int vega10_init_smc_table(struct pp_hwmgr
 *hwmgr)
              }
      }
 
-     pp_atomfwctrl_get_voltage_table_v4(hwmgr, VOLTAGE_TYPE_VDDC,
+     result = pp_atomfwctrl_get_voltage_table_v4(hwmgr,
 VOLTAGE_TYPE_VDDC,
                      VOLTAGE_OBJ_SVID2,  &voltage_table);
+     PP_ASSERT_WITH_CODE(!result,
+                     "Failed to get voltage table!",
+                     return result);
      pp_table->MaxVidStep = voltage_table.max_vid_step;
      pp_table->GfxDpmVoltageMode =

--
2.25.1