hw/char/stm32l4x5_usart: Fix memory corruption by adding correct class_size
PATCH 1/1 hw/char/stm32l4x5_usart: Fix memory corruption by adding correct class_size
"make check-qtest-aarch64" recently started failing on FreeBSD builds, and valgrind on Linux also detected that there is something fishy with the new stm32l4x5-usart: The code forgot to set the correct class_size here, so the various class_init functions in this file wrote beyond the allocated buffer when setting the subc->type field.
--- hw/char/stm32l4x5_usart.c | 1 + 1 file changed, 1 insertion(+)
hw/char/stm32l4x5_usart.c +1 -0
@@ -617,6 +617,7 @@ static const TypeInfo stm32l4x5_usart_types[] = { .parent = TYPE_SYS_BUS_DEVICE, .instance_size = sizeof(Stm32l4x5UsartBaseState), .instance_init = stm32l4x5_usart_base_init, + .class_size = sizeof(Stm32l4x5UsartBaseClass), .class_init = stm32l4x5_usart_base_class_init, .abstract = true, }, {
Signature · 1 line
2.44.0
Quoted 11 lines · Thomas Huth
"make check-qtest-aarch64" recently started failing on FreeBSD builds, and valgrind on Linux also detected that there is something fishy with the new stm32l4x5-usart: The code forgot to set the correct
class_sizehere, so the variousclass_initfunctions in this file wrote beyond the allocated buffer when setting thesubc->typefield.Fixes 4fb37aea7e ("hw/char: Implement STM32L4x5 USART skeleton")Signed-off-by Thomas Huth <[email protected]>--- hw/char/stm32l4x5_usart.c | 1 + 1 file changed, 1 insertion(+)
Peter Maydell
AppliedQuoted 10 lines · Thomas Huth
"make check-qtest-aarch64" recently started failing on FreeBSD builds, and valgrind on Linux also detected that there is something fishy with the new stm32l4x5-usart: The code forgot to set the correct
class_sizehere, so the variousclass_initfunctions in this file wrote beyond the allocated buffer when setting thesubc->typefield.Fixes 4fb37aea7e ("hw/char: Implement STM32L4x5 USART skeleton")Signed-off-by Thomas Huth <[email protected]>---
Applied to target-arm.next, thanks.
-- PMM