Skip to contentSkip to conversation

target/sh4: Fix ADDV opcode

PATCH New Philippe Mathieu-Daudé 1 participant 1 message Apr 30, 2024

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 target/sh4: Fix ADDV opcode

The documentation says:

ADDV Rm, Rn Rn + Rm -> Rn, overflow -> T

But QEMU implementation was:

ADDV Rm, Rn Rn + Rm -> Rm, overflow -> T

Fix by filling the correct Rm register.

Fixes ad8d25a11f ("target-sh4: implement addv and subv using TCG")

Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2317

---
 target/sh4/translate.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
target/sh4/translate.c +1 -1
index ebb6c901bf..4a1dd0d1f4 100644
@@ -714,7 +714,7 @@ static void _decode_opc(DisasContext * ctx)
             tcg_gen_xor_i32(t2, REG(B7_4), REG(B11_8));
             tcg_gen_andc_i32(cpu_sr_t, t1, t2);
             tcg_gen_shri_i32(cpu_sr_t, cpu_sr_t, 31);
-            tcg_gen_mov_i32(REG(B7_4), t0);
+            tcg_gen_mov_i32(REG(B11_8), t0);
         }
         return;
     case 0x2009: /* and Rm,Rn */
Signature · 1 line
2.41.0