Skip to contentSkip to conversation

wifi: iwlwifi: Use request_module_nowait

PATCH New [email protected] 1 participant 1 message Apr 30, 2024 Intel wireless wifi link (iwlwifi)

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 wifi: iwlwifi: Use request_module_nowait

From: Ben Greear <[email protected]>

This appears to work around a deadlock regression that came in with the LED merge in 6.9.

The deadlock happens on my system with 24 iwlwifi radios, so maybe it something like all worker threads are busy and some work that needs to complete cannot complete.

Fixes f5c31bcf604d ("Merge tag 'leds-next-6.9' of git://git.kernel.org/pub/scm/linux/kernel/git/lee/leds")

---

v2: Add Link: and remove newline between tags.

 drivers/net/wireless/intel/iwlwifi/iwl-drv.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/wireless/intel/iwlwifi/iwl-drv.c +1 -1
index 4696d73c8971..993177e1de27 100644
@@ -1744,7 +1744,7 @@ static void iwl_req_fw_callback(const struct firmware *ucode_raw, void *context)
 	 * or hangs loading.
 	 */
 	if (load_module)
-		request_module("%s", op->name);
+		request_module_nowait("%s", op->name);
 	failure = false;
 	goto free;
 
Signature · 1 line
2.42.0