selftests/vDSO: Fix assignment in condition without parentheses
Subsystems (2)
PATCH v2 1/1 selftests/vDSO: Fix assignment in condition without parentheses
Fixes clang compiler warnings by adding parentheses:
parse_vdso.c:65:9: warning: using the result of an assignment as a
condition without parentheses [-Wparentheses]
if (g = h & 0xf0000000)
~~^~~~~~~~~~~~~~~~
parse_vdso.c:65:9: note: place parentheses around the assignment to
silence this warning
if (g = h & 0xf0000000)
^
( )
parse_vdso.c:65:9: note: use '==' to turn this assignment into an
equality comparison
if (g = h & 0xf0000000)
^
==Fixes 98eedc3a9dbf ("Document the vDSO and add a reference parser")
Reviewed-by Justin Stitt <[email protected]>
Signed-off-by Edward Liaw <[email protected]>
---
v2: separated assignment from predicate
--- tools/testing/selftests/vDSO/parse_vdso.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
tools/testing/selftests/vDSO/parse_vdso.c +2 -1
@@ -62,7 +62,8 @@ static unsigned long elf_hash(const unsigned char *name)while (*name) { h = (h <<4 ) + *name++; -if (g = h &0xf0000000 ) + g = h &0xf0000000 ; +if (g) h ^= g >>24 ; h &= ~g; }
--
2.45.0.rc0.197.gbae5840b3b-goog