Skip to contentSkip to conversation

selftests/bpf: Fix spelling mistake "{GET|SET}SOCKOP" -> "{GET|SET}SOCKOPT"

PATCH In review Colin Ian King 2 participants 2 messages May 1, 2024 – May 7, 2024

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 selftests/bpf: Fix spelling mistake "{GET|SET}SOCKOP" -> "{GET|SET}SOCKOPT"

There are two spelling mistakes in .descr literal strings. Fix them.

---
 tools/testing/selftests/bpf/prog_tests/sockopt.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
tools/testing/selftests/bpf/prog_tests/sockopt.c +2 -2
index eaac83a7f388..ecf5a7a047a4 100644
@@ -933,7 +933,7 @@ static struct sockopt_test {
 	/* ==================== prog_type ====================  */
 
 	{
-		.descr = "can attach only BPF_CGROUP_SETSOCKOP",
+		.descr = "can attach only BPF_CGROUP_SETSOCKOPT",
 		.insns = {
 			/* return 1 */
 			BPF_MOV64_IMM(BPF_REG_0, 1),
@@ -947,7 +947,7 @@ static struct sockopt_test {
 	},
 
 	{
-		.descr = "can attach only BPF_CGROUP_GETSOCKOP",
+		.descr = "can attach only BPF_CGROUP_GETSOCKOPT",
 		.insns = {
 			/* return 1 */
 			BPF_MOV64_IMM(BPF_REG_0, 1),
Signature · 1 line
2.39.2
#1 lore raw
Quoted 8 lines · Colin Ian King

There are two spelling mistakes in .descr literal strings. Fix them.

---
 tools/testing/selftests/bpf/prog_tests/sockopt.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

This doesn't apply cleanly onto bpf-next/master, unfortunately. Can you please rebase and resend?

pw-bot: cr

Quoted 25 lines
tools/testing/selftests/bpf/prog_tests/sockopt.c +2 -3
index eaac83a7f388..ecf5a7a047a4 100644
@@ -933,7 +933,7 @@ static struct sockopt_test {
        /* ==================== prog_type ====================  */
 
        {
-               .descr = "can attach only BPF_CGROUP_SETSOCKOP",
+               .descr = "can attach only BPF_CGROUP_SETSOCKOPT",
                .insns = {
                        /* return 1 */
                        BPF_MOV64_IMM(BPF_REG_0, 1),
@@ -947,7 +947,7 @@ static struct sockopt_test {
        },
 
        {
-               .descr = "can attach only BPF_CGROUP_GETSOCKOP",
+               .descr = "can attach only BPF_CGROUP_GETSOCKOPT",
                .insns = {
                        /* return 1 */
                        BPF_MOV64_IMM(BPF_REG_0, 1),
--

2.39.2