ALSA: hda/realtek: Fix build error without CONFIG_PM
PATCH v2 1/1 ALSA: hda/realtek: Fix build error without CONFIG_PM
The alc_spec.power_hook is defined only with CONFIG_PM, and the recent fix overlooked it, resulting in a build error without CONFIG_PM. Fix it with the simple ifdef and set __maybe_unused for the function.
We may drop the whole CONFIG_PM dependency there, but it should be done in a separate cleanup patch later.
Fixes 1e707769df07 ("ALSA: hda/realtek - Set GPIO3 to default at S4 state for Thinkpad with ALC1318")
Reported-by kernel test robot <[email protected]>
Signed-off-by Takashi Iwai <[email protected]>
---v1->v2: add __maybe_unused for another warning
sound/pci/hda/patch_realtek.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
sound/pci/hda/patch_realtek.c +3 -1
@@ -7204,7 +7204,7 @@ static void alc287_alc1318_playback_pcm_hook(struct hda_pcm_stream *hinfo, } } -static void alc287_s4_power_gpio3_default (struct hda_codec *codec) +static void __maybe_unused alc287_s4_power_gpio3_default (struct hda_codec *codec) {if (is_s4_suspend (codec)) {alc_write_coef_idx (codec,0x10 ,0x8806 );/* Change MLK to GPIO3 */
@@ -7219,7 +7219,9 @@ static void alc287_fixup_lenovo_thinkpad_with_alc1318(struct hda_codec *codec,if (action !=HDA_FIXUP_ACT_PRE_PROBE )return ; +#ifdef CONFIG_PM spec->power_hook = alc287_s4_power_gpio3_default; +#endif spec->gen.pcm_playback_hook = alc287_alc1318_playback_pcm_hook; }
Signature · 1 line
2.43.0