Skip to contentSkip to conversation

hwmon (max6639): Use regmap

PATCH Applied Naresh Solanki 2 participants 2 messages May 3, 2024 Hardware monitoring

lore
Share & tools
lore
#0 lore raw

PATCH v4 1/1 hwmon (max6639): Use regmap

Add regmap support & remove local caching.

---
Changes in V4:
- Rename MAX6639_NDEV to MAX6639_NUM_CHANNELS
- Add comment for MAX6639_REG_TEMP register read
- Add MAX6639_REG_TARGTDUTY as volatile
- Remove unused variable ret in max6639_suspend function

Changes in V3:
- Remove mutex lock
- Remove caching of variable pwm in max6639_data
- Use regmap_write_bits in suspend & resume
- Remove error check for data in attrube show/store functions.
- Remove goto

Changes in V2:
- Remove local caching in max6639_data struct.
- Use define MAX6639_NDEV wherever possible

---
 drivers/hwmon/Kconfig   |   1 +
 drivers/hwmon/max6639.c | 339 ++++++++++++++++++----------------------
 2 files changed, 150 insertions(+), 190 deletions(-)
drivers/hwmon/Kconfig +1 -0
index bafc0058c728..e14ae18a973b 100644
@@ -1233,6 +1233,7 @@ config SENSORS_MAX6621
 config SENSORS_MAX6639
 	tristate "Maxim MAX6639 sensor chip"
 	depends on I2C
+	select REGMAP_I2C
 	help
 	  If you say yes here you get support for the MAX6639
 	  sensor chips.
drivers/hwmon/max6639.c +149 -190

563 lines not on this page · raw message

base-commit: 1d4d6733594d407e54153b8e031ba6356ceba81e

Signature · 1 line
2.42.0