Skip to contentSkip to conversation

ubd: Remove unused mutex 'ubd_mutex'

PATCH In review [email protected] 3 participants 6 messages May 5, 2024 – May 23, 2024 User-mode Linux (UML)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ubd: Remove unused mutex 'ubd_mutex'

From: "Dr. David Alan Gilbert" <[email protected]>

Commit fb5d1d389c9e ("ubd: open the backing files in ubd_add")

removed the last use of ubd_mutex.
Remove it.

Build and kernel startup test only.

---
 arch/um/drivers/ubd_kern.c | 1 -
 1 file changed, 1 deletion(-)
arch/um/drivers/ubd_kern.c +0 -1
index 63fc062add708..2b855240fbabf 100644
@@ -106,7 +106,6 @@ static inline void ubd_set_bit(__u64 bit, unsigned char *data)
 #define DRIVER_NAME "uml-blkdev"
 
 static DEFINE_MUTEX(ubd_lock);
-static DEFINE_MUTEX(ubd_mutex); /* replaces BKL, might not be needed */
 
 static int ubd_ioctl(struct block_device *bdev, blk_mode_t mode,
 		     unsigned int cmd, unsigned long arg);
Signature · 1 line
2.45.0
#2 lore raw
Quoted 3 lines · * Christoph Hellwig ([email protected]) wrote:

Looks good:

Thanks Christoph; any ideas who might take this?

Dave

Signature · 4 lines
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/
#4 lore raw

----- Ursprüngliche Mail -----

Quoted 8 lines

Von: "hch" <[email protected]>
An: "Dr. David Alan Gilbert" <[email protected]>
CC: "hch" <[email protected]>, "richard" <[email protected]>, "linux-um" <[email protected]>, "linux-kernel" <[email protected]>
Gesendet: Montag, 20. Mai 2024 17:20:49
Betreff: Re: [PATCH] ubd: Remove unused mutex 'ubd_mutex'

On Mon, May 20, 2024 at 03:12:20PM +0000, Dr. David Alan Gilbert wrote:

Quoted 8 lines
Quoted 6 lines · * Christoph Hellwig ([email protected]) wrote:
Quoted 3 lines

Looks good:

Thanks Christoph; any ideas who might take this?

Probably Richard who is alredy on Cc.

Yes, after the merge window.

Thanks,
//richard

#5 lore raw
Quoted 12 lines · * Richard Weinberger ([email protected]) wrote:

----- Ursprüngliche Mail -----

Quoted 11 lines

Von: "hch" <[email protected]>
An: "Dr. David Alan Gilbert" <[email protected]>
CC: "hch" <[email protected]>, "richard" <[email protected]>, "linux-um" <[email protected]>, "linux-kernel" <[email protected]>
Gesendet: Montag, 20. Mai 2024 17:20:49
Betreff: Re: [PATCH] ubd: Remove unused mutex 'ubd_mutex'

Quoted 3 lines · Dr. David Alan Gilbert
Quoted 2 lines · * Christoph Hellwig ([email protected]) wrote:

Looks good:

Quoted 7 lines
Quoted 5 lines
Quoted 3 lines
Quoted 1 line

Thanks Christoph; any ideas who might take this?

Probably Richard who is alredy on Cc.

Yes, after the merge window.

Thanks; no rush, just trying to keep an eye on where each patch is going.

Dave

Quoted 3 lines

Thanks,
//richard

Signature · 4 lines
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/