Skip to contentSkip to conversation

scripts-gdb-fix-parameter-handling-in-lx_per_cpu.patch removed from -mm tree

merged mm-nonmm-stable Andrew Morton 1 participant 1 message May 6, 2024

lore
Share & tools
lore

Andrew Morton

author tree notice Applied
#0 lore raw

The quilt patch titled
Subject: scripts/gdb: fix parameter handling in $lx_per_cpu
has been removed from the -mm tree. Its filename was
scripts-gdb-fix-parameter-handling-in-lx_per_cpu.patch

This patch was dropped because it was merged into the mm-nonmm-stable branch of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm

------------------------------------------------------
From: Florian Rommel <[email protected]>
Subject: scripts/gdb: fix parameter handling in $lx_per_cpu
Date: Thu, 25 Apr 2024 17:34:59 +0200

Before, the script tried to get the address by constructing a pointer to the parameter (by name). However, since GDB now passes the parameter as a GdbValue, we cannot get its name. Instead, we retrieve the address through GdbValue's address attribute.

Before:

Quoted 1 line
Quoted 1 line
Quoted 1 line

p $lx_per_cpu(cpu_info)

Traceback (most recent call last):
File "./scripts/gdb/linux/cpus.py", line 152, in invoke

    var_ptr = gdb.parse_and_eval("&" + var_name.string())
                                       ^^^^^^^^^^^^^^^^^

gdb.error: Trying to read string with inappropriate type `struct cpuinfo_x86'.

---

 scripts/gdb/linux/cpus.py |    5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
scripts/gdb/linux/cpus.py renamed from scripts/gdb/linux/cpus.py~scripts-gdb-fix-parameter-handling-in-lx_per_cpu +2 -3
@@ -152,9 +152,8 @@ Note that VAR has to be quoted as string
     def __init__(self):
         super(PerCpu, self).__init__("lx_per_cpu")
 
-    def invoke(self, var_name, cpu=-1):
-        var_ptr = gdb.parse_and_eval("&" + var_name.string())
-        return per_cpu(var_ptr, cpu)
+    def invoke(self, var, cpu=-1):
+        return per_cpu(var.address, cpu)
 
 
 PerCpu()

_

Patches currently in -mm which might be from [email protected] are