selftests/exec: build with -fPIE instead of -pie, to make clang happy
Subsystems (3)
PATCH 1/1 selftests/exec: build with -fPIE instead of -pie, to make clang happy
clang doesn't deal well with "-pie -static": it warns that -pie is an unused option here. Changing to "-fPIE -static" solves this problem for clang, while keeping the gcc results identical.
The problem is visible when building via:
make LLVM=1 -C tools/testing/selftests
Again: gcc 13 produces identical binaries for all of these programs, both before and after this commit (using "-pie"), and after (using "-fPIE").
Also, the runtime results are the same for both clang and gcc builds.
--- tools/testing/selftests/exec/Makefile | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
tools/testing/selftests/exec/Makefile +3 -3
@@ -29,8 +29,8 @@ $(OUTPUT)/execveat.denatured: $(OUTPUT)/execveat cp $< $@ chmod -x $@ $(OUTPUT)/load_address_4096: load_address.c - $(CC) $(CFLAGS) $(LDFLAGS) -Wl,-z,max-page-size=0x1000 -pie -static $< -o $@ + $(CC) $(CFLAGS) $(LDFLAGS) -Wl,-z,max-page-size=0x1000 -fPIE -static $< -o $@ $(OUTPUT)/load_address_2097152: load_address.c - $(CC) $(CFLAGS) $(LDFLAGS) -Wl,-z,max-page-size=0x200000 -pie -static $< -o $@ + $(CC) $(CFLAGS) $(LDFLAGS) -Wl,-z,max-page-size=0x200000 -fPIE -static $< -o $@ $(OUTPUT)/load_address_16777216: load_address.c - $(CC) $(CFLAGS) $(LDFLAGS) -Wl,-z,max-page-size=0x1000000 -pie -static $< -o $@ + $(CC) $(CFLAGS) $(LDFLAGS) -Wl,-z,max-page-size=0x1000000 -fPIE -static $< -o $@
base-commit: ddb4c3f25b7b95df3d6932db0b379d768a6ebdf7
prerequisite-patch-id: b901ece2a5b78503e2fb5480f20e304d36a0ea27
Signature · 1 line
2.45.0
Quoted 6 lines · John Hubbard
clang doesn't deal well with "-pie -static": it warns that -pie is an unused option here. Changing to "-fPIE -static" solves this problem for clang, while keeping the gcc results identical.
The problem is visible when building via:
Quoted 7 lines
make LLVM=1 -C
tools/testing/selftestsAgain: gcc 13 produces identical binaries for all of these programs, both before and after this commit (using "-pie"), and after (using "-fPIE").
Also, the runtime results are the same for both clang and gcc builds.
Thanks for this! It got solved differently here:
https://lkml.kernel.org/r/[email protected]
Does that work for you as well?
-Kees
Signature · 1 line
Kees Cook
Quoted 13 lines · Kees Cook
Quoted 12 lines · John Hubbard
clang doesn't deal well with "-pie -static": it warns that -pie is an unused option here. Changing to "-fPIE -static" solves this problem for clang, while keeping the gcc results identical.
The problem is visible when building via:
make LLVM=1 -C
tools/testing/selftestsAgain: gcc 13 produces identical binaries for all of these programs, both before and after this commit (using "-pie"), and after (using "-fPIE").
Quoted 7 lines
Quoted 1 line
Also, the runtime results are the same for both clang and gcc builds.
Thanks for this! It got solved differently here:
https://lkml.kernel.org/r/[email protected]Does that work for you as well?
Yes it does. Please drop my patch and let's use yours instead, thanks!
(As an aside, outside of the compiler sources themselves, it has proven quite difficult to find any in-depth documentation of linking options and behavior--now, and in the past.)
thanks,
Signature · 2 lines
John Hubbard NVIDIA