more lbs test fixes
cover more lbs test fixes
From: Pankaj Raghav <[email protected]>
These are some of the tests that failed when we were working on LBS patches [1].
generic/436 and xfs/008 are adapted to work with bs > ps systems.
xfs/161 is an upstream failure, and it happens even on bs <= ps systems.
[1] https://lore.kernel.org/linux-xfs/[email protected]/
Pankaj Raghav (3):
xfs/161: adapt the test case for 64k FS blocksize generic/436: round up bufsz to nearest filesystem blksz xfs/008: use block size instead of the pagesize
src/seek_sanity_test.c | 8 ++++---- tests/xfs/008 | 19 ++++++++++--------- tests/xfs/008.out | 8 ++++---- tests/xfs/161 | 10 ++++++++-- 4 files changed, 26 insertions(+), 19 deletions(-)
base-commit: b26d68da08e47e6508a96bee72b25823040ab67e
Signature · 1 line
2.34.1
PATCH 1/3 xfs/161: adapt the test case for 64k FS blocksize
From: Pankaj Raghav <[email protected]>
This test fails when xfs is formatted with 64k filesystem block size*. It fails because the soft quota is not exceeded with the hardcoded 64k pwrite, thereby, the grace time is not set. Even though soft quota is set to 12k for uid1, it is rounded up to the nearest blocksize.
*** Report for user quotas on device /dev/sdb3
Block grace time: 7days; Inode grace time: 7days
Block limits File limits
User used soft hard grace used soft hard grace
----------------------------------------------------------------------
0 -- 0 0 0 0 3 0 0 0 1 -- 64 64 1024 0 1 0 0 0 2 -- 64 0 0 0 1 0 0 0
Adapt the pwrite to do more than 64k write when the FS blocksize is 64k.
Cap the blksz to be at least 64k to retain the same behaviour as before for smaller filesystem blocksizes.
* This happens even on a 64k pagesize system and it is not related to LBS effort.
--- tests/xfs/161 | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-)
tests/xfs/161 +8 -2
@@ -38,9 +38,15 @@ _qmount_option "usrquota" _scratch_xfs_db -c 'version' -c 'sb 0' -c 'p' >> $seqres.full _scratch_mount >> $seqres.full +min_blksz=65536 +file_blksz=$(_get_file_block_size "$SCRATCH_MNT") +# Write more than one block to exceed the soft block quota limit. +blksz=$(( 2 * $file_blksz)) + +blksz=$(( blksz > min_blksz ? blksz : min_blksz )) # Force the block counters for uid 1 and 2 above zero -_pwrite_byte 0x61 0 64k $SCRATCH_MNT/a >> $seqres.full -_pwrite_byte 0x61 0 64k $SCRATCH_MNT/b >> $seqres.full +_pwrite_byte 0x61 0 $blksz $SCRATCH_MNT/a >> $seqres.full +_pwrite_byte 0x61 0 $blksz $SCRATCH_MNT/b >> $seqres.full sync chown 1 $SCRATCH_MNT/a chown 2 $SCRATCH_MNT/b
Signature · 1 line
2.34.1
Re: [PATCH 1/3] xfs/161: adapt the test case for 64k FS blocksize
Quoted 34 lines · Pankaj Raghav (Samsung)
From: Pankaj Raghav <[email protected]>
This test fails when xfs is formatted with 64k filesystem block size*. It fails because the soft quota is not exceeded with the hardcoded 64k pwrite, thereby, the grace time is not set. Even though soft quota is set to 12k for uid1, it is rounded up to the nearest blocksize.
*** Report for user quotas on device
/dev/sdb3
Block grace time: 7days; Inode grace time: 7days
Block limits File limits
User used soft hard grace used soft hard grace
----------------------------------------------------------------------0 -- 0 0 0 0 3 0 0 0 1 -- 64 64 1024 0 1 0 0 0 2 -- 64 0 0 0 1 0 0 0Adapt the pwrite to do more than 64k write when the FS blocksize is 64k.
Cap the blksz to be at least 64k to retain the same behaviour as before for smaller filesystem blocksizes.
* This happens even on a 64k pagesize system and it is not related to LBS effort.
Signed-off-by Pankaj Raghav <[email protected]>--- tests/xfs/161 | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-)tests/xfs/161 +0
-0
tests/xfs/161 _qmount_option "usrquota" · line 46
Quoted 9 lines
tests/xfs/161 +6
-0@@ -38,9 +38,15 @@ _qmount_option "usrquota" _scratch_xfs_db -c 'version' -c 'sb 0' -c 'p' >> $seqres.full _scratch_mount >> $seqres.full +min_blksz=65536 +file_blksz=$(_get_file_block_size "$SCRATCH_MNT") +# Write more than one block to exceed the soft block quota limit. +blksz=$(( 2 * $file_blksz)) + +blksz=$(( blksz > min_blksz ? blksz : min_blksz ))
If we don't set $min_blksize and always write (2 * $file_blksz) does the test still work?
--D
Quoted 11 lines
tests/xfs/161 +2
-2# Force the block counters for uid 1 and 2 above zero -_pwrite_byte 0x61 0 64k $SCRATCH_MNT/a >> $seqres.full -_pwrite_byte 0x61 0 64k $SCRATCH_MNT/b >> $seqres.full +_pwrite_byte 0x61 0 $blksz $SCRATCH_MNT/a >> $seqres.full +_pwrite_byte 0x61 0 $blksz $SCRATCH_MNT/b >> $seqres.full sync chown 1 $SCRATCH_MNT/a chown 2 $SCRATCH_MNT/bSignature · 1 line
2.34.1
Re: [PATCH 1/3] xfs/161: adapt the test case for 64k FS blocksize
Quoted 39 lines · Darrick J. Wong
Quoted 37 lines · Pankaj Raghav (Samsung)
From: Pankaj Raghav <[email protected]>
This test fails when xfs is formatted with 64k filesystem block size*. It fails because the soft quota is not exceeded with the hardcoded 64k pwrite, thereby, the grace time is not set. Even though soft quota is set to 12k for uid1, it is rounded up to the nearest blocksize.
*** Report for user quotas on device
/dev/sdb3
Block grace time: 7days; Inode grace time: 7days
Block limits File limits
User used soft hard grace used soft hard grace
----------------------------------------------------------------------0 -- 0 0 0 0 3 0 0 0 1 -- 64 64 1024 0 1 0 0 0 2 -- 64 0 0 0 1 0 0 0Adapt the pwrite to do more than 64k write when the FS blocksize is 64k.
Cap the blksz to be at least 64k to retain the same behaviour as before for smaller filesystem blocksizes.
* This happens even on a 64k pagesize system and it is not related to LBS effort.
Signed-off-by Pankaj Raghav <[email protected]>--- tests/xfs/161 | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-)tests/xfs/161 +0
-0@@ -38,9 +38,15 @@ _qmount_option "usrquota" _scratch_xfs_db -c 'version' -c 'sb 0' -c 'p' >> $seqres.full _scratch_mount >> $seqres.full
Quoted 3 lines
tests/xfs/161 _qmount_option "usrquota" · line 43
Quoted 3 lines
tests/xfs/161 +3
-0+min_blksz=65536 +file_blksz=$(_get_file_block_size "$SCRATCH_MNT") +# Write more than one block to exceed the soft block quota limit.
Maybe we should improve this comment to -
# Write more than the soft block quota limit of 12k which is set later via xfs_quota
# On 64k bs this will get rounded to the nearest blocksize which is 64k
Quoted 6 lines
tests/xfs/161 _qmount_option "usrquota" · line 46
Quoted 3 lines
tests/xfs/161 +3
-0+blksz=$(( 2 * $file_blksz)) + +blksz=$(( blksz > min_blksz ? blksz : min_blksz ))If we don't set $min_blksize and always write (2 * $file_blksz) does the test still work?
I guess it won't (even for bs=4k), because we set the bsoft=12k via xfs_quota. So we have to write more than 12k to trigger the grace timer.
-ritesh
Re: [PATCH 1/3] xfs/161: adapt the test case for 64k FS blocksize
Quoted 57 lines · Ritesh Harjani
Quoted 39 lines · Darrick J. Wong
Quoted 37 lines · Pankaj Raghav (Samsung)
From: Pankaj Raghav <[email protected]>
This test fails when xfs is formatted with 64k filesystem block size*. It fails because the soft quota is not exceeded with the hardcoded 64k pwrite, thereby, the grace time is not set. Even though soft quota is set to 12k for uid1, it is rounded up to the nearest blocksize.
*** Report for user quotas on device
/dev/sdb3
Block grace time: 7days; Inode grace time: 7days
Block limits File limits
User used soft hard grace used soft hard grace
----------------------------------------------------------------------0 -- 0 0 0 0 3 0 0 0 1 -- 64 64 1024 0 1 0 0 0 2 -- 64 0 0 0 1 0 0 0Adapt the pwrite to do more than 64k write when the FS blocksize is 64k.
Cap the blksz to be at least 64k to retain the same behaviour as before for smaller filesystem blocksizes.
* This happens even on a 64k pagesize system and it is not related to LBS effort.
Signed-off-by Pankaj Raghav <[email protected]>--- tests/xfs/161 | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-)tests/xfs/161 +0
-0@@ -38,9 +38,15 @@ _qmount_option "usrquota" _scratch_xfs_db -c 'version' -c 'sb 0' -c 'p' >> $seqres.full _scratch_mount >> $seqres.fullQuoted 3 lines
tests/xfs/161 _qmount_option "usrquota" · line 43
Quoted 3 lines
tests/xfs/161 +3
-0+min_blksz=65536 +file_blksz=$(_get_file_block_size "$SCRATCH_MNT") +# Write more than one block to exceed the soft block quota limit.Maybe we should improve this comment to -
# Write more than the soft block quota limit of 12k which is set later via
xfs_quota
# On 64k bs this will get rounded to the nearest blocksize which is 64kQuoted 6 lines
tests/xfs/161 _qmount_option "usrquota" · line 46
Quoted 3 lines
tests/xfs/161 +3
-0+blksz=$(( 2 * $file_blksz)) + +blksz=$(( blksz > min_blksz ? blksz : min_blksz ))If we don't set $min_blksize and always write (2 * $file_blksz) does the test still work?
Quoted 2 lines
I guess it won't (even for bs=4k), because we set the bsoft=12k via
xfs_quota. So we have to write more than 12k to trigger the grace timer.
Ah, ok. Yes, that makes sense with the improved comment. :)
--D
Quoted 2 lines
-ritesh
Re: [PATCH 1/3] xfs/161: adapt the test case for 64k FS blocksize
Quoted 58 lines · Darrick J. Wong
Quoted 57 lines · Ritesh Harjani
Quoted 39 lines · Darrick J. Wong
Quoted 37 lines · Pankaj Raghav (Samsung)
From: Pankaj Raghav <[email protected]>
This test fails when xfs is formatted with 64k filesystem block size*. It fails because the soft quota is not exceeded with the hardcoded 64k pwrite, thereby, the grace time is not set. Even though soft quota is set to 12k for uid1, it is rounded up to the nearest blocksize.
*** Report for user quotas on device
/dev/sdb3
Block grace time: 7days; Inode grace time: 7days
Block limits File limits
User used soft hard grace used soft hard grace
----------------------------------------------------------------------0 -- 0 0 0 0 3 0 0 0 1 -- 64 64 1024 0 1 0 0 0 2 -- 64 0 0 0 1 0 0 0Adapt the pwrite to do more than 64k write when the FS blocksize is 64k.
Cap the blksz to be at least 64k to retain the same behaviour as before for smaller filesystem blocksizes.
* This happens even on a 64k pagesize system and it is not related to LBS effort.
Signed-off-by Pankaj Raghav <[email protected]>--- tests/xfs/161 | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-)tests/xfs/161 +0
-0@@ -38,9 +38,15 @@ _qmount_option "usrquota" _scratch_xfs_db -c 'version' -c 'sb 0' -c 'p' >> $seqres.full _scratch_mount >> $seqres.fullQuoted 3 lines
tests/xfs/161 _qmount_option "usrquota" · line 43
Quoted 3 lines
tests/xfs/161 +3
-0+min_blksz=65536 +file_blksz=$(_get_file_block_size "$SCRATCH_MNT") +# Write more than one block to exceed the soft block quota limit.Maybe we should improve this comment to -
# Write more than the soft block quota limit of 12k which is set later via
xfs_quota
# On 64k bs this will get rounded to the nearest blocksize which is 64kQuoted 6 lines
tests/xfs/161 _qmount_option "usrquota" · line 46
Quoted 3 lines
tests/xfs/161 +3
-0+blksz=$(( 2 * $file_blksz)) + +blksz=$(( blksz > min_blksz ? blksz : min_blksz ))If we don't set $min_blksize and always write (2 * $file_blksz) does the test still work?
Quoted 4 lines
Quoted 2 lines
I guess it won't (even for bs=4k), because we set the bsoft=12k via
xfs_quota. So we have to write more than 12k to trigger the grace timer.Ah, ok. Yes, that makes sense with the improved comment. :)
@ritesh and @darrick: I think we can also change the bsoft right? In the follow up email [1], I made pwrite to 2 fs block and bsoft to be 1 fsblock.
That looks like a cleaner solution than having hardcoded values. Let me know what you all think.
[1] https://lore.kernel.org/fstests/20240508105852.nfjtlp53v24xb3tw@quentin/
Quoted 5 lines
--D
Quoted 2 lines
-ritesh
Signature · 1 line
Pankaj Raghav
Re: [PATCH 1/3] xfs/161: adapt the test case for 64k FS blocksize
In reply to Darrick J. WongQuoted 38 lines · Darrick J. Wong
Quoted 37 lines · Pankaj Raghav (Samsung)
From: Pankaj Raghav <[email protected]>
This test fails when xfs is formatted with 64k filesystem block size*. It fails because the soft quota is not exceeded with the hardcoded 64k pwrite, thereby, the grace time is not set. Even though soft quota is set to 12k for uid1, it is rounded up to the nearest blocksize.
*** Report for user quotas on device
/dev/sdb3
Block grace time: 7days; Inode grace time: 7days
Block limits File limits
User used soft hard grace used soft hard grace
----------------------------------------------------------------------0 -- 0 0 0 0 3 0 0 0 1 -- 64 64 1024 0 1 0 0 0 2 -- 64 0 0 0 1 0 0 0Adapt the pwrite to do more than 64k write when the FS blocksize is 64k.
Cap the blksz to be at least 64k to retain the same behaviour as before for smaller filesystem blocksizes.
* This happens even on a 64k pagesize system and it is not related to LBS effort.
Signed-off-by Pankaj Raghav <[email protected]>--- tests/xfs/161 | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-)tests/xfs/161 +0
-0@@ -38,9 +38,15 @@ _qmount_option "usrquota" _scratch_xfs_db -c 'version' -c 'sb 0' -c 'p' >> $seqres.full _scratch_mount >> $seqres.full
Quoted 9 lines
tests/xfs/161 _qmount_option "usrquota" · line 46
Quoted 6 lines
tests/xfs/161 +6
-0+min_blksz=65536 +file_blksz=$(_get_file_block_size "$SCRATCH_MNT") +# Write more than one block to exceed the soft block quota limit. +blksz=$(( 2 * $file_blksz)) + +blksz=$(( blksz > min_blksz ? blksz : min_blksz ))If we don't set $min_blksize and always write (2 * $file_blksz) does the test still work?
I think something like this is more clean where we don't have anymore hardcoded variables:
Author: Pankaj Raghav <[email protected]> Date: Thu Jan 18 18:40:39 2024 +0100
xfs/161: adapt the test case for 64k FS blocksize
This test fails when xfs is formatted with 64k filesystem block size*. It fails because the soft quota is not exceeded with the hardcoded 64k pwrite, thereby, the grace time is not set. Even though soft quota is set to 12k for uid1, it is rounded up to the nearest blocksize.
*** Report for user quotas on device /dev/sdb3 Block grace time: 7days; Inode grace time: 7days
Block limits File limits
User used soft hard grace used soft hard grace
----------------------------------------------------------------------
0 -- 0 0 0 0 3 0 0 0
1 -- 64 64 1024 0 1 0 0 0
2 -- 64 0 0 0 1 0 0 0
Adapt the pwrite to do twice the FS block size and set the soft limit to be 1 FS block.
* This happens even on a 64k pagesize system and it is not related to LBS effort.
tests/xfs/161 +10 -4
@@ -38,15 +38,21 @@ _qmount_option "usrquota" _scratch_xfs_db -c 'version' -c 'sb 0' -c 'p' >> $seqres.full _scratch_mount >> $seqres.full + +pgsize=`$here/src/feature -s` +file_blksz=$(_get_file_block_size "$SCRATCH_MNT") +# Write more than one block to exceed the soft block quota limit. +blksz=$(( 2 * $file_blksz)) + # Force the block counters for uid 1 and 2 above zero -_pwrite_byte 0x61 0 64k $SCRATCH_MNT/a >> $seqres.full -_pwrite_byte 0x61 0 64k $SCRATCH_MNT/b >> $seqres.full +_pwrite_byte 0x61 0 $blksz $SCRATCH_MNT/a >> $seqres.full +_pwrite_byte 0x61 0 $blksz $SCRATCH_MNT/b >> $seqres.full sync chown 1 $SCRATCH_MNT/a chown 2 $SCRATCH_MNT/b # Set quota limits on uid 1 before upgrading -$XFS_QUOTA_PROG -x -c 'limit -u bsoft=12k bhard=1m 1' $SCRATCH_MNT +$XFS_QUOTA_PROG -x -c 'limit -u bsoft='"$file_blksz"' bhard=1m 1' $SCRATCH_MNT # Make sure the grace period is at /some/ point in the future. We have to # use bc because not all bashes can handle integer comparisons with 64-bit
@@ -71,7 +77,7 @@ _scratch_mount # Set a very generous grace period and quota limits on uid 2 after upgrading $XFS_QUOTA_PROG -x -c 'timer -u -b -d 2147483647' $SCRATCH_MNT -$XFS_QUOTA_PROG -x -c 'limit -u bsoft=10000 bhard=150000 2' $SCRATCH_MNT +$XFS_QUOTA_PROG -x -c 'limit -u bsoft='"$file_blksz"' bhard=150000 2' $SCRATCH_MNT # Query the grace periods to see if they got set properly after the upgrade. repquota -upn $SCRATCH_MNT > $tmp.repquota
Quoted 14 lines
--D
Quoted 11 lines
tests/xfs/161 +2
-2# Force the block counters for uid 1 and 2 above zero -_pwrite_byte 0x61 0 64k $SCRATCH_MNT/a >> $seqres.full -_pwrite_byte 0x61 0 64k $SCRATCH_MNT/b >> $seqres.full +_pwrite_byte 0x61 0 $blksz $SCRATCH_MNT/a >> $seqres.full +_pwrite_byte 0x61 0 $blksz $SCRATCH_MNT/b >> $seqres.full sync chown 1 $SCRATCH_MNT/a chown 2 $SCRATCH_MNT/bSignature · 1 line
2.34.1
Signature · 1 line
Pankaj Raghav
Re: [PATCH 1/3] xfs/161: adapt the test case for 64k FS blocksize
tests/xfs/161 _qmount_option "usrquota" · line 42
Quoted 11 lines
tests/xfs/161 +2
-0@@ -38,15 +38,21 @@ _qmount_option "usrquota" _scratch_xfs_db -c 'version' -c 'sb 0' -c 'p' >> $seqres.full _scratch_mount >> $seqres.full + +pgsize=`$here/src/feature -s`
Stale pgsize variable.
Quoted 46 lines
tests/xfs/161 +8
-4+file_blksz=$(_get_file_block_size "$SCRATCH_MNT") +# Write more than one block to exceed the soft block quota limit. +blksz=$(( 2 * $file_blksz)) + # Force the block counters for uid 1 and 2 above zero -_pwrite_byte 0x61 0 64k $SCRATCH_MNT/a >> $seqres.full -_pwrite_byte 0x61 0 64k $SCRATCH_MNT/b >> $seqres.full +_pwrite_byte 0x61 0 $blksz $SCRATCH_MNT/a >> $seqres.full +_pwrite_byte 0x61 0 $blksz $SCRATCH_MNT/b >> $seqres.full sync chown 1 $SCRATCH_MNT/a chown 2 $SCRATCH_MNT/b # Set quota limits on uid 1 before upgrading -$XFS_QUOTA_PROG -x -c 'limit -u bsoft=12k bhard=1m 1' $SCRATCH_MNT +$XFS_QUOTA_PROG -x -c 'limit -u bsoft='"$file_blksz"' bhard=1m 1' $SCRATCH_MNT # Make sure the grace period is at /some/ point in the future. We have to # use bc because not all bashes can handle integer comparisons with 64-bit@@ -71,7 +77,7 @@ _scratch_mount # Set a very generous grace period and quota limits on uid 2 after upgrading $XFS_QUOTA_PROG -x -c 'timer -u -b -d 2147483647' $SCRATCH_MNT -$XFS_QUOTA_PROG -x -c 'limit -u bsoft=10000 bhard=150000 2' $SCRATCH_MNT +$XFS_QUOTA_PROG -x -c 'limit -u bsoft='"$file_blksz"' bhard=150000 2' $SCRATCH_MNT # Query the grace periods to see if they got set properly after the upgrade. repquota -upn $SCRATCH_MNT > $tmp.repquotaQuoted 15 lines
--D
Quoted 11 lines
# Force the block counters for uid 1 and 2 above zero
tests/xfs/161 +2
-2-_pwrite_byte 0x61 0 64k $SCRATCH_MNT/a >> $seqres.full -_pwrite_byte 0x61 0 64k $SCRATCH_MNT/b >> $seqres.full +_pwrite_byte 0x61 0 $blksz $SCRATCH_MNT/a >> $seqres.full +_pwrite_byte 0x61 0 $blksz $SCRATCH_MNT/b >> $seqres.full sync chown 1 $SCRATCH_MNT/a chown 2 $SCRATCH_MNT/bSignature · 1 line
2.34.1Signature · 1 line
Pankaj Raghav
Re: [PATCH 1/3] xfs/161: adapt the test case for 64k FS blocksize
In reply to Pankaj Raghav (Samsung)Quoted 49 lines · Pankaj Raghav (Samsung)
Quoted 38 lines · Darrick J. Wong
Quoted 37 lines · Pankaj Raghav (Samsung)
From: Pankaj Raghav <[email protected]>
This test fails when xfs is formatted with 64k filesystem block size*. It fails because the soft quota is not exceeded with the hardcoded 64k pwrite, thereby, the grace time is not set. Even though soft quota is set to 12k for uid1, it is rounded up to the nearest blocksize.
*** Report for user quotas on device
/dev/sdb3
Block grace time: 7days; Inode grace time: 7days
Block limits File limits
User used soft hard grace used soft hard grace
----------------------------------------------------------------------0 -- 0 0 0 0 3 0 0 0 1 -- 64 64 1024 0 1 0 0 0 2 -- 64 0 0 0 1 0 0 0Adapt the pwrite to do more than 64k write when the FS blocksize is 64k.
Cap the blksz to be at least 64k to retain the same behaviour as before for smaller filesystem blocksizes.
* This happens even on a 64k pagesize system and it is not related to LBS effort.
Signed-off-by Pankaj Raghav <[email protected]>--- tests/xfs/161 | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-)tests/xfs/161 +0
-0@@ -38,9 +38,15 @@ _qmount_option "usrquota" _scratch_xfs_db -c 'version' -c 'sb 0' -c 'p' >> $seqres.full _scratch_mount >> $seqres.fullQuoted 9 lines
tests/xfs/161 _qmount_option "usrquota"
Quoted 6 lines
tests/xfs/161 +6
-0+min_blksz=65536 +file_blksz=$(_get_file_block_size "$SCRATCH_MNT") +# Write more than one block to exceed the soft block quota limit. +blksz=$(( 2 * $file_blksz)) + +blksz=$(( blksz > min_blksz ? blksz : min_blksz ))If we don't set $min_blksize and always write (2 * $file_blksz) does the test still work?
Quoted 3 lines
I think something like this is more clean where we don't have anymore hardcoded variables:
Yes, why not.
Quoted 32 lines
Author: Pankaj Raghav <[email protected]> Date: Thu Jan 18 18:40:39 2024 +0100xfs/161: adapt the test case for 64k FS blocksize
This test fails when xfs is formatted with 64k filesystem block size*. It fails because the soft quota is not exceeded with the hardcoded 64k pwrite, thereby, the grace time is not set. Even though soft quota is set to 12k for uid1, it is rounded up to the nearest blocksize.
*** Report for user quotas on device
/dev/sdb3Block grace time: 7days; Inode grace time: 7days
Block limits File limits
User used soft hard grace used soft hard grace
----------------------------------------------------------------------
0 -- 0 0 0 0 3 0 0 0
1 -- 64 64 1024 0 1 0 0 0
2 -- 64 0 0 0 1 0 0 0Adapt the pwrite to do twice the FS block size and set the soft limit to be 1 FS block.
* This happens even on a 64k pagesize system and it is not related to LBS effort.
Signed-off-by Pankaj Raghav <[email protected]>tests/xfs/161 +0
-0
tests/xfs/161 _qmount_option "usrquota" · line 43
Quoted 6 lines
tests/xfs/161 +3
-0@@ -38,15 +38,21 @@ _qmount_option "usrquota" _scratch_xfs_db -c 'version' -c 'sb 0' -c 'p' >> $seqres.full _scratch_mount >> $seqres.full + +pgsize=`$here/src/feature -s` +file_blksz=$(_get_file_block_size "$SCRATCH_MNT")
small bit: maybe just $blksz is fine.
tests/xfs/161 _qmount_option "usrquota" · line 45
Quoted 2 lines
tests/xfs/161 +2
-0+# Write more than one block to exceed the soft block quota limit. +blksz=$(( 2 * $file_blksz))
small nit: Instead of blksz here maybe writesz or filesz then?
Then let's make:
lim_bsoft=$blksz, lim_bhard=$(( 10 * blksz )) and writesz=$(( 2 * blksz ))
tests/xfs/161 _qmount_option "usrquota" · line 55
Quoted 13 lines
tests/xfs/161 +4
-3+ # Force the block counters for uid 1 and 2 above zero -_pwrite_byte 0x61 0 64k $SCRATCH_MNT/a >> $seqres.full -_pwrite_byte 0x61 0 64k $SCRATCH_MNT/b >> $seqres.full +_pwrite_byte 0x61 0 $blksz $SCRATCH_MNT/a >> $seqres.full +_pwrite_byte 0x61 0 $blksz $SCRATCH_MNT/b >> $seqres.full sync chown 1 $SCRATCH_MNT/a chown 2 $SCRATCH_MNT/b # Set quota limits on uid 1 before upgrading -$XFS_QUOTA_PROG -x -c 'limit -u bsoft=12k bhard=1m 1' $SCRATCH_MNT +$XFS_QUOTA_PROG -x -c 'limit -u bsoft='"$file_blksz"' bhard=1m 1' $SCRATCH_MNT
Then we can use $lim_bsoft and $lim_bhard here.
tests/xfs/161 _scratch_mount · line 83
Quoted 13 lines
tests/xfs/161 +1
-1# Make sure the grace period is at /some/ point in the future. We have to # use bc because not all bashes can handle integer comparisons with 64-bit@@ -71,7 +77,7 @@ _scratch_mount # Set a very generous grace period and quota limits on uid 2 after upgrading $XFS_QUOTA_PROG -x -c 'timer -u -b -d 2147483647' $SCRATCH_MNT -$XFS_QUOTA_PROG -x -c 'limit -u bsoft=10000 bhard=150000 2' $SCRATCH_MNT +$XFS_QUOTA_PROG -x -c 'limit -u bsoft='"$file_blksz"' bhard=150000 2' $SCRATCH_MNT # Query the grace periods to see if they got set properly after the upgrade. repquota -upn $SCRATCH_MNT > $tmp.repquota
-ritesh
PATCH 2/3 generic/436: round up bufsz to nearest filesystem blksz
In reply to Pankaj Raghav (Samsung)From: Pankaj Raghav <[email protected]>
SEEK_HOLE and SEEK_DATA work in filesystem block size granularity. So while filling up the buffer for test 13 - 16, round up the bufsz to the closest filesystem blksz.
As we only allowed blocksizes lower than the pagesize, this was never an issue and it always aligned. Once we have blocksize > pagesize, this assumption will break.
Fixes the test for LBS configuration.
--- src/seek_sanity_test.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
src/seek_sanity_test.c +4 -4
@@ -541,7 +541,7 @@ static int test16(int fd, int testnum) {int ret =0 ;char *buf =NULL ; -int bufsz =sysconf (_SC_PAGE_SIZE); +int bufsz =roundup (sysconf (_SC_PAGE_SIZE) *14 , alloc_size);int filsz =4 <<20 ;if (!unwritten_extents) {
@@ -591,7 +591,7 @@ static int test15(int fd, int testnum) {int ret =0 ;char *buf =NULL ; -int bufsz =sysconf (_SC_PAGE_SIZE); +int bufsz =roundup (sysconf (_SC_PAGE_SIZE) *14 , alloc_size);int filsz =4 <<20 ;if (!unwritten_extents) {
@@ -643,7 +643,7 @@ static int test14(int fd, int testnum) {int ret =0 ;char *buf =NULL ; -int bufsz =sysconf (_SC_PAGE_SIZE) *14 ; +int bufsz =roundup (sysconf (_SC_PAGE_SIZE) *14 , alloc_size);int filsz =4 <<20 ;if (!unwritten_extents) {
@@ -692,7 +692,7 @@ static int test13(int fd, int testnum) {int ret =0 ;char *buf =NULL ; -int bufsz =sysconf (_SC_PAGE_SIZE) *14 ; +int bufsz =roundup (sysconf (_SC_PAGE_SIZE) *14 , alloc_size);int filsz =4 <<20 ;if (!unwritten_extents) {
Signature · 1 line
2.34.1
Re: [PATCH 2/3] generic/436: round up bufsz to nearest filesystem blksz
Quoted 6 lines · Pankaj Raghav (Samsung)
From: Pankaj Raghav <[email protected]>
SEEK_HOLEandSEEK_DATAwork in filesystem block size granularity. So while filling up the buffer for test 13 - 16, round up the bufsz to the closest filesystem blksz.
Quoted 8 lines
As we only allowed blocksizes lower than the pagesize, this was never an issue and it always aligned. Once we have blocksize > pagesize, this assumption will break.
Fixes the test for LBS configuration.
Signed-off-by Pankaj Raghav <[email protected]>---
Makes sense to me,
Quoted 46 lines
src/seek_sanity_test.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)src/seek_sanity_test.c +4
-4@@ -541,7 +541,7 @@ static int test16(int fd, int testnum) {int ret =0 ;char *buf =NULL ; -int bufsz =sysconf (_SC_PAGE_SIZE); +int bufsz =roundup (sysconf (_SC_PAGE_SIZE) *14 , alloc_size);int filsz =4 <<20 ;if (!unwritten_extents) {@@ -591,7 +591,7 @@ static int test15(int fd, int testnum) {int ret =0 ;char *buf =NULL ; -int bufsz =sysconf (_SC_PAGE_SIZE); +int bufsz =roundup (sysconf (_SC_PAGE_SIZE) *14 , alloc_size);int filsz =4 <<20 ;if (!unwritten_extents) {@@ -643,7 +643,7 @@ static int test14(int fd, int testnum) {int ret =0 ;char *buf =NULL ; -int bufsz =sysconf (_SC_PAGE_SIZE) *14 ; +int bufsz =roundup (sysconf (_SC_PAGE_SIZE) *14 , alloc_size);int filsz =4 <<20 ;if (!unwritten_extents) {@@ -692,7 +692,7 @@ static int test13(int fd, int testnum) {int ret =0 ;char *buf =NULL ; -int bufsz =sysconf (_SC_PAGE_SIZE) *14 ; +int bufsz =roundup (sysconf (_SC_PAGE_SIZE) *14 , alloc_size);int filsz =4 <<20 ;if (!unwritten_extents) {Signature · 1 line
2.34.1
Re: [PATCH 2/3] generic/436: round up bufsz to nearest filesystem blksz
In reply to Pankaj Raghav (Samsung)Quoted 22 lines · Pankaj Raghav (Samsung)
From: Pankaj Raghav <[email protected]>
SEEK_HOLEandSEEK_DATAwork in filesystem block size granularity. So while filling up the buffer for test 13 - 16, round up the bufsz to the closest filesystem blksz.As we only allowed blocksizes lower than the pagesize, this was never an issue and it always aligned. Once we have blocksize > pagesize, this assumption will break.
Fixes the test for LBS configuration.
Signed-off-by Pankaj Raghav <[email protected]>--- src/seek_sanity_test.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)src/seek_sanity_test.c +0
-0
src/seek_sanity_test.c static int test16(int fd, int testnum) · line 544
Quoted 5 lines
src/seek_sanity_test.c +1
-1@@ -541,7 +541,7 @@ static int test16(int fd, int testnum) {int ret =0 ;char *buf =NULL ; -int bufsz =sysconf (_SC_PAGE_SIZE); +int bufsz =roundup (sysconf (_SC_PAGE_SIZE) *14 , alloc_size);
Why is the page size multiplied by 14?
--D
Quoted 33 lines
src/seek_sanity_test.c +3
-3int filsz =4 <<20 ;if (!unwritten_extents) {@@ -591,7 +591,7 @@ static int test15(int fd, int testnum) {int ret =0 ;char *buf =NULL ; -int bufsz =sysconf (_SC_PAGE_SIZE); +int bufsz =roundup (sysconf (_SC_PAGE_SIZE) *14 , alloc_size);int filsz =4 <<20 ;if (!unwritten_extents) {@@ -643,7 +643,7 @@ static int test14(int fd, int testnum) {int ret =0 ;char *buf =NULL ; -int bufsz =sysconf (_SC_PAGE_SIZE) *14 ; +int bufsz =roundup (sysconf (_SC_PAGE_SIZE) *14 , alloc_size);int filsz =4 <<20 ;if (!unwritten_extents) {@@ -692,7 +692,7 @@ static int test13(int fd, int testnum) {int ret =0 ;char *buf =NULL ; -int bufsz =sysconf (_SC_PAGE_SIZE) *14 ; +int bufsz =roundup (sysconf (_SC_PAGE_SIZE) *14 , alloc_size);int filsz =4 <<20 ;if (!unwritten_extents) {Signature · 1 line
2.34.1
Re: [PATCH 2/3] generic/436: round up bufsz to nearest filesystem blksz
Quoted 18 lines · Darrick J. Wong
Quoted 17 lines · Pankaj Raghav (Samsung)
From: Pankaj Raghav <[email protected]>
SEEK_HOLEandSEEK_DATAwork in filesystem block size granularity. So while filling up the buffer for test 13 - 16, round up the bufsz to the closest filesystem blksz.As we only allowed blocksizes lower than the pagesize, this was never an issue and it always aligned. Once we have blocksize > pagesize, this assumption will break.
Fixes the test for LBS configuration.
Signed-off-by Pankaj Raghav <[email protected]>--- src/seek_sanity_test.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
Quoted 12 lines
src/seek_sanity_test.c static int test16(int fd, int testnum) · line 544
Quoted 10 lines
src/seek_sanity_test.c +1
-1@@ -541,7 +541,7 @@ static int test16(int fd, int testnum) {int ret =0 ;char *buf =NULL ; -int bufsz =sysconf (_SC_PAGE_SIZE); +int bufsz =roundup (sysconf (_SC_PAGE_SIZE) *14 , alloc_size);Why is the page size multiplied by 14?
Ah, that is a copy pasta error from test 14 and test 15. I will change it in the next version. Thanks.
Quoted 36 lines
--D
Quoted 33 lines
src/seek_sanity_test.c +3
-3int filsz =4 <<20 ;if (!unwritten_extents) {@@ -591,7 +591,7 @@ static int test15(int fd, int testnum) {int ret =0 ;char *buf =NULL ; -int bufsz =sysconf (_SC_PAGE_SIZE); +int bufsz =roundup (sysconf (_SC_PAGE_SIZE) *14 , alloc_size);int filsz =4 <<20 ;if (!unwritten_extents) {@@ -643,7 +643,7 @@ static int test14(int fd, int testnum) {int ret =0 ;char *buf =NULL ; -int bufsz =sysconf (_SC_PAGE_SIZE) *14 ; +int bufsz =roundup (sysconf (_SC_PAGE_SIZE) *14 , alloc_size);int filsz =4 <<20 ;if (!unwritten_extents) {@@ -692,7 +692,7 @@ static int test13(int fd, int testnum) {int ret =0 ;char *buf =NULL ; -int bufsz =sysconf (_SC_PAGE_SIZE) *14 ; +int bufsz =roundup (sysconf (_SC_PAGE_SIZE) *14 , alloc_size);int filsz =4 <<20 ;if (!unwritten_extents) {Signature · 1 line
2.34.1
Signature · 1 line
Pankaj Raghav
PATCH 3/3 xfs/008: use block size instead of the pagesize
In reply to Pankaj Raghav (Samsung)From: Pankaj Raghav <[email protected]>
The testcase estimates to have ratio of 1:3/4 for holes:filesize. This holds true where the blocksize is always less than or equal to pagesize and the total size of the file is calculated based on the pagesize. There is an implicit assumption that blocksize will always be less than the pagesize.
LBS support will enable bs > ps where a minimum IO size is one block, which can be greater than a page. Adjust the size calculation to be based on the blocksize and not the pagesize.
--- tests/xfs/008 | 19 ++++++++++--------- tests/xfs/008.out | 8 ++++---- 2 files changed, 14 insertions(+), 13 deletions(-)
tests/xfs/008 +10 -9
@@ -11,7 +11,8 @@ _begin_fstest rw ioctl auto quick status=0 # success is the default! pgsize=`$here/src/feature -s` - +fileblksize=$(_get_file_block_size "$TEST_DIR") +blksize=$((fileblksize > pgsize ? fileblksize : pgsize)) # Override the default cleanup function. _cleanup() {
@@ -21,7 +22,7 @@ _cleanup() _filter() { - sed -e "s/-b $pgsize/-b PGSIZE/g" \ + sed -e "s/-b $blksize/-b BLKSIZE/g" \ -e "s/-l .* -c/-l FSIZE -c/g" }
@@ -73,17 +74,17 @@ _require_test # We are trying to create roughly 50 or 100 holes in a file # using random writes. Assuming a good distribution of 50 writes # in a file, the file only needs to be 3-4x the size of the write -# size muliplied by the number of writes. Hence we use 200 * pgsize -# for files we want 50 holes in and 400 * pgsize for files we want +# size muliplied by the number of writes. Hence we use 200 * blksize +# for files we want 50 holes in and 400 * blksize for files we want # 100 holes in. This keeps the runtime down as low as possible. # -_do_test 1 50 "-l `expr 200 \* $pgsize` -c 50 -b $pgsize" -_do_test 2 100 "-l `expr 400 \* $pgsize` -c 100 -b $pgsize" -_do_test 3 100 "-l `expr 400 \* $pgsize` -c 100 -b 512" # test partial pages +_do_test 1 50 "-l `expr 200 \* $blksize` -c 50 -b $blksize" +_do_test 2 100 "-l `expr 400 \* $blksize` -c 100 -b $blksize" +_do_test 3 100 "-l `expr 400 \* $blksize` -c 100 -b 512" # test partial blocks # rinse, lather, repeat for direct IO -_do_test 4 50 "-d -l `expr 200 \* $pgsize` -c 50 -b $pgsize" -_do_test 5 100 "-d -l `expr 400 \* $pgsize` -c 100 -b $pgsize" +_do_test 4 50 "-d -l `expr 200 \* $blksize` -c 50 -b $blksize" +_do_test 5 100 "-d -l `expr 400 \* $blksize` -c 100 -b $blksize" # note: direct IO requires page aligned IO # todo: realtime.
tests/xfs/008.out +4 -4
@@ -1,10 +1,10 @@ QA output created by 008 -randholes.1 : -l FSIZE -c 50 -b PGSIZE +randholes.1 : -l FSIZE -c 50 -b BLKSIZE ------------------------------------------ holes is in range -randholes.2 : -l FSIZE -c 100 -b PGSIZE +randholes.2 : -l FSIZE -c 100 -b BLKSIZE ------------------------------------------ holes is in range
@@ -12,10 +12,10 @@ randholes.3 : -l FSIZE -c 100 -b 512 ------------------------------------------ holes is in range -randholes.4 : -d -l FSIZE -c 50 -b PGSIZE +randholes.4 : -d -l FSIZE -c 50 -b BLKSIZE ------------------------------------------ holes is in range -randholes.5 : -d -l FSIZE -c 100 -b PGSIZE +randholes.5 : -d -l FSIZE -c 100 -b BLKSIZE ------------------------------------------ holes is in range
Signature · 1 line
2.34.1
Re: [PATCH 3/3] xfs/008: use block size instead of the pagesize
Quoted 8 lines · Pankaj Raghav (Samsung)
From: Pankaj Raghav <[email protected]>
The testcase estimates to have ratio of 1:3/4 for holes:filesize. This holds true where the blocksize is always less than or equal to pagesize and the total size of the file is calculated based on the pagesize. There is an implicit assumption that blocksize will always be less than the pagesize.
Quoted 6 lines
LBS support will enable bs > ps where a minimum IO size is one block, which can be greater than a page. Adjust the size calculation to be based on the blocksize and not the pagesize.
Signed-off-by Pankaj Raghav <[email protected]>---
Looks good to me, thanks!
Quoted 85 lines
tests/xfs/008 | 19 ++++++++++--------- tests/xfs/008.out | 8 ++++---- 2 files changed, 14 insertions(+), 13 deletions(-)tests/xfs/008 +10
-9@@ -11,7 +11,8 @@ _begin_fstest rw ioctl auto quick status=0 # success is the default! pgsize=`$here/src/feature -s` - +fileblksize=$(_get_file_block_size "$TEST_DIR") +blksize=$((fileblksize > pgsize ? fileblksize : pgsize)) # Override the default cleanup function. _cleanup() {@@ -21,7 +22,7 @@ _cleanup() _filter() { - sed -e "s/-b $pgsize/-b PGSIZE/g" \ + sed -e "s/-b $blksize/-b BLKSIZE/g" \ -e "s/-l .* -c/-l FSIZE -c/g" }@@ -73,17 +74,17 @@ _require_test # We are trying to create roughly 50 or 100 holes in a file # using random writes. Assuming a good distribution of 50 writes # in a file, the file only needs to be 3-4x the size of the write -# size muliplied by the number of writes. Hence we use 200 * pgsize -# for files we want 50 holes in and 400 * pgsize for files we want +# size muliplied by the number of writes. Hence we use 200 * blksize +# for files we want 50 holes in and 400 * blksize for files we want # 100 holes in. This keeps the runtime down as low as possible. # -_do_test 1 50 "-l `expr 200 \* $pgsize` -c 50 -b $pgsize" -_do_test 2 100 "-l `expr 400 \* $pgsize` -c 100 -b $pgsize" -_do_test 3 100 "-l `expr 400 \* $pgsize` -c 100 -b 512" # test partial pages +_do_test 1 50 "-l `expr 200 \* $blksize` -c 50 -b $blksize" +_do_test 2 100 "-l `expr 400 \* $blksize` -c 100 -b $blksize" +_do_test 3 100 "-l `expr 400 \* $blksize` -c 100 -b 512" # test partial blocks # rinse, lather, repeat for direct IO -_do_test 4 50 "-d -l `expr 200 \* $pgsize` -c 50 -b $pgsize" -_do_test 5 100 "-d -l `expr 400 \* $pgsize` -c 100 -b $pgsize" +_do_test 4 50 "-d -l `expr 200 \* $blksize` -c 50 -b $blksize" +_do_test 5 100 "-d -l `expr 400 \* $blksize` -c 100 -b $blksize" # note: direct IO requires page aligned IO # todo: realtime.tests/xfs/008.out +4
-4@@ -1,10 +1,10 @@ QA output created by 008 -randholes.1 : -l FSIZE -c 50 -b PGSIZE +randholes.1 : -l FSIZE -c 50 -b BLKSIZE ------------------------------------------ holes is in range -randholes.2 : -l FSIZE -c 100 -b PGSIZE +randholes.2 : -l FSIZE -c 100 -b BLKSIZE ------------------------------------------ holes is in range@@ -12,10 +12,10 @@ randholes.3 : -l FSIZE -c 100 -b 512 ------------------------------------------ holes is in range -randholes.4 : -d -l FSIZE -c 50 -b PGSIZE +randholes.4 : -d -l FSIZE -c 50 -b BLKSIZE ------------------------------------------ holes is in range -randholes.5 : -d -l FSIZE -c 100 -b PGSIZE +randholes.5 : -d -l FSIZE -c 100 -b BLKSIZE ------------------------------------------ holes is in rangeSignature · 1 line
2.34.1
Hi Pankaj,
Although this patchset got RVB, but looks like you still want to change it a bit, so I won't merge this patchset this week, will wait for your next version :)
Thanks,
Zorro
Quoted 28 lines · Pankaj Raghav (Samsung)
From: Pankaj Raghav <[email protected]>
These are some of the tests that failed when we were working on LBS patches [1].
generic/436 and xfs/008 are adapted to work with bs > ps systems.
xfs/161 is an upstream failure, and it happens even on bs <= ps systems.
[1] https://lore.kernel.org/linux-xfs/[email protected]/
Pankaj Raghav (3):
xfs/161: adapt the test case for 64k FS blocksize generic/436: round up bufsz to nearest filesystem blksz xfs/008: use block size instead of the pagesizesrc/seek_sanity_test.c | 8 ++++---- tests/xfs/008 | 19 ++++++++++--------- tests/xfs/008.out | 8 ++++---- tests/xfs/161 | 10 ++++++++-- 4 files changed, 26 insertions(+), 19 deletions(-)base-commit:
b26d68da08e47e6508a96bee72b25823040ab67eSignature · 1 line
2.34.1