selftests/vDSO: change elf_hash parameter to signed char
Subsystems (2)
PATCH v4 1/1 selftests/vDSO: change elf_hash parameter to signed char
Fixes clang compilation warnings by changing elf_hash's parameter type to char * and casting to unsigned char * inside elf_hash:
parse_vdso.c:206:22: warning: passing 'const char *' to parameter of
type 'const unsigned char *' converts between pointers to integer types where one is of the unique plain 'char' type and the other is not [-Wpointer-sign]
ver_hash = elf_hash(version);
^~~~~~~
parse_vdso.c:59:52: note: passing argument to parameter 'name' here
static unsigned long elf_hash(const unsigned char *name)
^parse_vdso.c:207:46: warning: passing 'const char *' to parameter of
type 'const unsigned char *' converts between pointers to integer types where one is of the unique plain 'char' type and the other is not [-Wpointer-sign]
ELF(Word) chain = vdso_info.bucket[elf_hash(name) % vdso_info.nbucket];
^~~~parse_vdso.c:59:52: note: passing argument to parameter 'name' here static unsigned long elf_hash(const unsigned char *name)
---
v2: updated commit message with correct compiler warning
v3: fixed checkpatch errors and indentation
https://lore.kernel.org/all/[email protected]/
v4: moved the typecast into elf_hash based on libelf
https://sourceforge.net/p/elftoolchain/code/HEAD/tree/trunk/libelf/elf_hash.c#l47
--- tools/testing/selftests/vDSO/parse_vdso.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-)
tools/testing/selftests/vDSO/parse_vdso.c +6 -3
@@ -56,12 +56,15 @@ static struct vdso_info } vdso_info;/* Straight from the ELF specification. */ -static unsigned long elf_hash (const unsigned char *name) +static unsigned long elf_hash (const char *name) {unsigned long h =0 , g; -while (*name) +const unsigned char *s; + + s = (const unsigned char *) name; +while (*s) { - h = (h <<4 ) + *name++; + h = (h <<4 ) + *s++;if (g = h &0xf0000000 ) h ^= g >>24 ; h &= ~g;
--
2.45.0.rc1.225.g2a3ae87e7f-goog