Reduce overhead of LSMs with static calls
Subsystems (4)
KP Singh
maintainerv10 cover Reduce overhead of LSMs with static calls
# Background
LSM hooks (callbacks) are currently invoked as indirect function calls. These callbacks are registered into a linked list at boot time as the order of the LSMs can be configured on the kernel command line with the "lsm=" command line parameter.
Indirect function calls have a high overhead due to retpoline mitigation for various speculative execution attacks.
Retpolines remain relevant even with newer generation CPUs as recently discovered speculative attacks, like Spectre BHB need Retpolines to mitigate against branch history injection and still need to be used in combination with newer mitigation features like eIBRS.
This overhead is especially significant for the "bpf" LSM which allows the user to implement LSM functionality with eBPF program. In order to facilitate this the "bpf" LSM provides a default callback for all LSM hooks. When enabled, the "bpf" LSM incurs an unnecessary / avoidable indirect call. This is especially bad in OS hot paths (e.g. in the networking stack). This overhead prevents the adoption of bpf LSM on performance critical systems, and also, in general, slows down all LSMs.
Since we know the address of the enabled LSM callbacks at compile time and only the order is determined at boot time, the LSM framework can allocate static calls for each of the possible LSM callbacks and these calls can be updated once the order is determined at boot.
This series is a respin of the RFC proposed by Paul Renauld ([email protected]) and Brendan Jackman ([email protected]) [1]
# Performance improvement
With this patch-set some syscalls with lots of LSM hooks in their path benefitted at an average of ~3% and I/O and Pipe based system calls benefitting the most.
Here are the results of the relevant Unixbench system benchmarks with BPF LSM and SELinux enabled with default policies enabled with and without these patches.
Benchmark Delta(%): (+ is better)
===============================================================================
Execl Throughput +1.9356 File Write 1024 bufsize 2000 maxblocks +6.5953 Pipe Throughput +9.5499 Pipe-based Context Switching +3.0209 Process Creation +2.3246 Shell Scripts (1 concurrent) +1.4975 System Call Overhead +2.7815 System Benchmarks Index Score (Partial Only): +3.4859
In the best case, some syscalls like eventfd_create benefitted to about ~10%. The full analysis can be viewed at https://kpsingh.ch/lsm-perf
[1] https://lore.kernel.org/linux-security-module/[email protected]/
# BPF LSM Side effects
Patch 4 of the series also addresses the issues with the side effects of the default value return values of the BPF LSM callbacks and also removes the overheads associated with them making it deployable at hyperscale.
# v9 to v10
* Addressed Paul's comments for Patch 3. I did not remove the acks from this one as changes were minor.
* Moved BPF LSM specific hook toggling logic bpf_lsm_toggle_hook to s security_toggle_hook as a generic API. I removed the Ack's from this patch as it's worth another look.
* Refactored the non-standard hooks to use static calls.
# v8 to v9
Paul, I removed the 5th patch about CONFIG_SECURITY_HOOK_LIKELY and went through all the feedback. I believe it all should be addressed now.
But, please let me know if I missed anything.
The patches are based on https://git.kernel.org/pub/scm/linux/kernel/git/pcmoore/lsm.git
(next branch as of 2024-02-07) and resolved a bunch of conflicts.
I also added Andrii's series ack to indidividual patches.
# v7 to v8
* Addressed Andrii's feedback
* Rebased (this seems to have removed the syscall changes). v7 has the required conflict resolution incase the conflicts need to be resolved again.
# v6 -> v7
* Rebased with latest LSM id changes merged
NOTE: The warning shown by the kernel test bot is spurious, there is no flex array and it seems to come from an older tool chain.
https://lore.kernel.org/bpf/[email protected]/
# v5 -> v6
* Fix a bug in BPF LSM hook toggle logic.
# v4 -> v5
* Rebase to linux-next/master
* Fixed the case where MAX_LSM_COUNT comes to zero when just CONFIG_SECURITY is compiled in without any other LSM enabled as reported here:
https://lore.kernel.org/bpf/[email protected]
# v3 -> v4
* Refactor LSM count macros to use COUNT_ARGS
* Change CONFIG_SECURITY_HOOK_LIKELY likely's default value to be based on the LSM enabled and have it depend on CONFIG_EXPERT. There are a lot of subtle options behind CONFIG_EXPERT and this should, hopefully alleviate concerns about yet another knob.
* __randomize_layout for struct lsm_static_call and, in addition to the cover letter add performance numbers to 3rd patch and some minor commit message updates.
* Rebase to linux-next.
# v2 -> v3
* Fixed a build issue on archs which don't have static calls and enable CONFIG_SECURITY.
* Updated the LSM_COUNT macros based on Andrii's suggestions.
* Changed the security_ prefix to lsm_prefix based on Casey's suggestion.
* Inlined static_branch_maybe into lsm_for_each_hook on Kees' feedback.
# v1 -> v2 (based on linux-next, next-20230614)
* Incorporated suggestions from Kees
* Changed the way MAX_LSMs are counted from a binary based generator to a clever header.
* Add CONFIG_SECURITY_HOOK_LIKELY to configure the likelihood of LSM hooks.
KP Singh (5):
kernel: Add helper macros for loop unrolling
security: Count the LSMs enabled at compile time
security: Replace indirect LSM hook calls with static calls
security: Update non standard hooks to use static calls
bpf: Only enable BPF LSM hooks when an LSM program is attached
include/linux/args.h | 6 +- include/linux/lsm_count.h | 128 +++++++++++++ include/linux/lsm_hooks.h | 94 +++++++++- include/linux/unroll.h | 36 ++++ kernel/bpf/trampoline.c | 40 +++- security/bpf/hooks.c | 2 +- security/security.c | 382 +++++++++++++++++++++++++------------- 7 files changed, 542 insertions(+), 146 deletions(-) create mode 100644 include/linux/lsm_count.h create mode 100644 include/linux/unroll.h
Signature · 1 line
2.45.0.rc1.225.g2a3ae87e7f-goog
KP Singh
maintainerPATCH v10 1/5 kernel: Add helper macros for loop unrolling
This helps in easily initializing blocks of code (e.g. static calls and keys).
UNROLL(N, MACRO, __VA_ARGS__) calls MACRO N times with the first argument as the index of the iteration. This allows string pasting to create unique tokens for variable names, function calls etc.
As an example:
#include <linux/unroll.h>
#define MACRO(N, a, b) \
int add_##N(int a, int b) \
{ \
return a + b + N; \
}
UNROLL(2, MACRO, x, y)expands to:
int add_0(int x, int y)
{
return x + y + 0;
}
int add_1(int x, int y)
{
return x + y + 1;
}--- include/linux/unroll.h | 36 ++++++++++++++++++++++++++++++++++++ 1 file changed, 36 insertions(+) create mode 100644 include/linux/unroll.h
include/linux/unroll.h new file +36 -0
@@ -0,0 +1,36 @@ +/* SPDX-License-Identifier: GPL-2.0 */ + +/* +* Copyright (C) 2023 Google LLC. +*/ + +#ifndef __UNROLL_H +#define __UNROLL_H + +#include <linux/args.h> + +#define UNROLL(N, MACRO, args...) CONCATENATE(__UNROLL_, N)(MACRO, args) + +#define __UNROLL_0(MACRO, args...) +#define __UNROLL_1(MACRO, args...) __UNROLL_0(MACRO, args) MACRO(0, args) +#define __UNROLL_2(MACRO, args...) __UNROLL_1(MACRO, args) MACRO(1, args) +#define __UNROLL_3(MACRO, args...) __UNROLL_2(MACRO, args) MACRO(2, args) +#define __UNROLL_4(MACRO, args...) __UNROLL_3(MACRO, args) MACRO(3, args) +#define __UNROLL_5(MACRO, args...) __UNROLL_4(MACRO, args) MACRO(4, args) +#define __UNROLL_6(MACRO, args...) __UNROLL_5(MACRO, args) MACRO(5, args) +#define __UNROLL_7(MACRO, args...) __UNROLL_6(MACRO, args) MACRO(6, args) +#define __UNROLL_8(MACRO, args...) __UNROLL_7(MACRO, args) MACRO(7, args) +#define __UNROLL_9(MACRO, args...) __UNROLL_8(MACRO, args) MACRO(8, args) +#define __UNROLL_10(MACRO, args...) __UNROLL_9(MACRO, args) MACRO(9, args) +#define __UNROLL_11(MACRO, args...) __UNROLL_10(MACRO, args) MACRO(10, args) +#define __UNROLL_12(MACRO, args...) __UNROLL_11(MACRO, args) MACRO(11, args) +#define __UNROLL_13(MACRO, args...) __UNROLL_12(MACRO, args) MACRO(12, args) +#define __UNROLL_14(MACRO, args...) __UNROLL_13(MACRO, args) MACRO(13, args) +#define __UNROLL_15(MACRO, args...) __UNROLL_14(MACRO, args) MACRO(14, args) +#define __UNROLL_16(MACRO, args...) __UNROLL_15(MACRO, args) MACRO(15, args) +#define __UNROLL_17(MACRO, args...) __UNROLL_16(MACRO, args) MACRO(16, args) +#define __UNROLL_18(MACRO, args...) __UNROLL_17(MACRO, args) MACRO(17, args) +#define __UNROLL_19(MACRO, args...) __UNROLL_18(MACRO, args) MACRO(18, args) +#define __UNROLL_20(MACRO, args...) __UNROLL_19(MACRO, args) MACRO(19, args) + +#endif /* __UNROLL_H */
Signature · 1 line
2.45.0.rc1.225.g2a3ae87e7f-goog
KP Singh
maintainerPATCH v10 2/5 security: Count the LSMs enabled at compile time
In reply to KP SinghThese macros are a clever trick to determine a count of the number of LSMs that are enabled in the config to ascertain the maximum number of static calls that need to be configured per LSM hook.
Without this one would need to generate static calls for the total number of LSMs in the kernel (even if they are not compiled) times the number of LSM hooks which ends up being quite wasteful.
--- include/linux/args.h | 6 +- include/linux/lsm_count.h | 128 ++++++++++++++++++++++++++++++++++++++ 2 files changed, 131 insertions(+), 3 deletions(-) create mode 100644 include/linux/lsm_count.h
include/linux/args.h +3 -3
@@ -17,9 +17,9 @@* that as _n. */ -/* This counts to 12. Any more, it will return 13th argument. */ -#define __COUNT_ARGS(_0, _1, _2, _3, _4, _5, _6, _7, _8, _9, _10, _11, _12, _n, X...) _n -#define COUNT_ARGS(X...) __COUNT_ARGS(, ##X, 12, 11, 10, 9, 8, 7, 6, 5, 4, 3, 2, 1, 0) +/* This counts to 15. Any more, it will return 16th argument. */ +#define __COUNT_ARGS(_0, _1, _2, _3, _4, _5, _6, _7, _8, _9, _10, _11, _12, _13, _14, _15, _n, X...) _n +#define COUNT_ARGS(X...) __COUNT_ARGS(, ##X, 15, 14, 13, 12, 11, 10, 9, 8, 7, 6, 5, 4, 3, 2, 1, 0)/* Concatenate two parameters, but allow them to be expanded beforehand. */ #define __CONCAT (a, b) a ## b
include/linux/lsm_count.h new file +128 -0
128 lines not on this page · raw message
Signature · 1 line
2.45.0.rc1.225.g2a3ae87e7f-goog
KP Singh
maintainerPATCH v10 3/5 security: Replace indirect LSM hook calls with static calls
In reply to KP SinghLSM hooks are currently invoked from a linked list as indirect calls which are invoked using retpolines as a mitigation for speculative attacks (Branch History / Target injection) and add extra overhead which is especially bad in kernel hot paths:
security_file_ioctl:
0xff...0320 <+0>: endbr64
0xff...0324 <+4>: push %rbp 0xff...0325 <+5>: push %r15 0xff...0327 <+7>: push %r14 0xff...0329 <+9>: push %rbx 0xff...032a <+10>: mov %rdx,%rbx 0xff...032d <+13>: mov %esi,%ebp 0xff...032f <+15>: mov %rdi,%r14 0xff...0332 <+18>: mov $0xff...7030,%r15 0xff...0339 <+25>: mov (%r15),%r15 0xff...033c <+28>: test %r15,%r15 0xff...033f <+31>: je 0xff...0358 <security_file_ioctl+56> 0xff...0341 <+33>: mov 0x18(%r15),%r11 0xff...0345 <+37>: mov %r14,%rdi 0xff...0348 <+40>: mov %ebp,%esi 0xff...034a <+42>: mov %rbx,%rdx
0xff...034d <+45>: call 0xff...2e0 <__x86_indirect_thunk_array+352>
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Indirect calls that use retpolines leading to overhead, not just due to extra instruction but also branch misses.
0xff...0352 <+50>: test %eax,%eax 0xff...0354 <+52>: je 0xff...0339 <security_file_ioctl+25> 0xff...0356 <+54>: jmp 0xff...035a <security_file_ioctl+58> 0xff...0358 <+56>: xor %eax,%eax 0xff...035a <+58>: pop %rbx 0xff...035b <+59>: pop %r14 0xff...035d <+61>: pop %r15 0xff...035f <+63>: pop %rbp 0xff...0360 <+64>: jmp 0xff...47c4 <__x86_return_thunk>
The indirect calls are not really needed as one knows the addresses of enabled LSM callbacks at boot time and only the order can possibly change at boot time with the lsm= kernel command line parameter.
An array of static calls is defined per LSM hook and the static calls are updated at boot time once the order has been determined.
A static key guards whether an LSM static call is enabled or not, without this static key, for LSM hooks that return an int, the presence of the hook that returns a default value can create side-effects which has resulted in bugs [1].
With the hook now exposed as a static call, one can see that the retpolines are no longer there and the LSM callbacks are invoked directly:
security_file_ioctl:
0xff...0ca0 <+0>: endbr64
0xff...0ca4 <+4>: nopl 0x0(%rax,%rax,1)
0xff...0ca9 <+9>: push %rbp
0xff...0caa <+10>: push %r14 0xff...0cac <+12>: push %rbx 0xff...0cad <+13>: mov %rdx,%rbx 0xff...0cb0 <+16>: mov %esi,%ebp 0xff...0cb2 <+18>: mov %rdi,%r14 0xff...0cb5 <+21>: jmp 0xff...0cc7 <security_file_ioctl+39>
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Static key enabled for SELinux
0xffffffff818f0cb7 <+23>: jmp 0xff...0cde <security_file_ioctl+62>
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Static key enabled for BPF LSM. This is something that is changed to default to false to avoid the existing side effect issues of BPF LSM
[1] in a subsequent patch.
0xff...0cb9 <+25>: xor %eax,%eax 0xff...0cbb <+27>: xchg %ax,%ax 0xff...0cbd <+29>: pop %rbx 0xff...0cbe <+30>: pop %r14 0xff...0cc0 <+32>: pop %rbp 0xff...0cc1 <+33>: cs jmp 0xff...0000 <__x86_return_thunk> 0xff...0cc7 <+39>: endbr64 0xff...0ccb <+43>: mov %r14,%rdi 0xff...0cce <+46>: mov %ebp,%esi 0xff...0cd0 <+48>: mov %rbx,%rdx 0xff...0cd3 <+51>: call 0xff...3230 <selinux_file_ioctl>
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Direct call to SELinux.
0xff...0cd8 <+56>: test %eax,%eax 0xff...0cda <+58>: jne 0xff...0cbd <security_file_ioctl+29> 0xff...0cdc <+60>: jmp 0xff...0cb7 <security_file_ioctl+23> 0xff...0cde <+62>: endbr64 0xff...0ce2 <+66>: mov %r14,%rdi 0xff...0ce5 <+69>: mov %ebp,%esi 0xff...0ce7 <+71>: mov %rbx,%rdx 0xff...0cea <+74>: call 0xff...e220 <bpf_lsm_file_ioctl>
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Direct call to BPF LSM.
0xff...0cef <+79>: test %eax,%eax 0xff...0cf1 <+81>: jne 0xff...0cbd <security_file_ioctl+29> 0xff...0cf3 <+83>: jmp 0xff...0cb9 <security_file_ioctl+25> 0xff...0cf5 <+85>: endbr64 0xff...0cf9 <+89>: mov %r14,%rdi 0xff...0cfc <+92>: mov %ebp,%esi 0xff...0cfe <+94>: mov %rbx,%rdx 0xff...0d01 <+97>: pop %rbx 0xff...0d02 <+98>: pop %r14
0xff...0d04 <+100>: pop %rbp
0xff...0d05 <+101>: ret
0xff...0d06 <+102>: int3
0xff...0d07 <+103>: int3
0xff...0d08 <+104>: int3
0xff...0d09 <+105>: int3
While this patch uses static_branch_unlikely indicating that an LSM hook is likely to be not present. In most cases this is still a better choice as even when an LSM with one hook is added, empty slots are created for all LSM hooks (especially when many LSMs that do not initialize most hooks are present on the system).
There are some hooks that don't use the call_int_hook and call_void_hook. These hooks are updated to use a new macro called lsm_for_each_hook where the lsm_callback is directly invoked as an indirect call. These are updated in a subsequent patch to also use static calls.
Below are results of the relevant Unixbench system benchmarks with BPF LSM and SELinux enabled with default policies enabled with and without these patches.
Benchmark Delta(%): (+ is better)
===============================================================================
Execl Throughput +1.9356 File Write 1024 bufsize 2000 maxblocks +6.5953 Pipe Throughput +9.5499 Pipe-based Context Switching +3.0209 Process Creation +2.3246 Shell Scripts (1 concurrent) +1.4975 System Call Overhead +2.7815 System Benchmarks Index Score (Partial Only): +3.4859
In the best case, some syscalls like eventfd_create benefitted to about ~10%.
--- include/linux/lsm_hooks.h | 70 ++++++++++++-- security/security.c | 198 ++++++++++++++++++++++++++------------ 2 files changed, 196 insertions(+), 72 deletions(-)
include/linux/lsm_hooks.h +62 -8
@@ -30,16 +30,63 @@#include <linux/init.h> #include <linux/rculist.h> #include <linux/xattr.h> +#include <linux/static_call.h> +#include <linux/unroll.h> +#include <linux/jump_label.h> +#include <linux/lsm_count.h> + +#define SECURITY_HOOK_ACTIVE_KEY (HOOK ,IDX ) security_hook_active_##HOOK##_##IDX + +/* +* Identifier for the LSM static calls. +* HOOK is an LSM hook as defined in linux/lsm_hookdefs.h +* IDX is the index of the static call. 0 <= NUM < MAX_LSM_COUNT +*/ +#define LSM_STATIC_CALL (HOOK ,IDX ) lsm_static_call_##HOOK##_##IDX + +/* +* Call the macro M for each LSM hook MAX_LSM_COUNT times. +*/ +#define LSM_LOOP_UNROLL (M , ...) \ +do { \ + UNROLL(MAX_LSM_COUNT, M, __VA_ARGS__) \ +} while (0) + +#define LSM_DEFINE_UNROLL (M , ...) UNROLL(MAX_LSM_COUNT, M, __VA_ARGS__)union security_list_options {#define LSM_HOOK (RET ,DEFAULT ,NAME , ...) RET (*NAME)(__VA_ARGS__);#include "lsm_hook_defs.h"#undef LSM_HOOK +void *lsm_func_addr; }; -struct security_hook_heads { -#define LSM_HOOK (RET ,DEFAULT ,NAME , ...) struct hlist_head NAME; -#include "lsm_hook_defs.h" +/* +* @key: static call key as defined by STATIC_CALL_KEY +* @trampoline: static call trampoline as defined by STATIC_CALL_TRAMP +* @hl: The security_hook_list as initialized by the owning LSM. +* @active: Enabled when the static call has an LSM hook associated. +*/ +struct lsm_static_call { +struct static_call_key *key; +void *trampoline; +struct security_hook_list *hl; +/* this needs to be true or false based on what the key defaults to */ +struct static_key_false *active; +} __randomize_layout; + +/* +* Table of the static calls for each LSM hook. +* Once the LSMs are initialized, their callbacks will be copied to these +* tables such that the calls are filled backwards (from last to first). +* This way, we can jump directly to the first used static call, and execute +* all of them after. This essentially makes the entry point +* dynamic to adapt the number of static calls to the number of callbacks. +*/ +struct lsm_static_calls_table { +#define LSM_HOOK (RET ,DEFAULT ,NAME , ...) \ + struct lsm_static_call NAME[MAX_LSM_COUNT]; +#include <linux/lsm_hook_defs.h>#undef LSM_HOOK } __randomize_layout;
@@ -58,10 +105,14 @@ struct lsm_id {/* * Security module hook list structure. * For use with generic list macros for common operations. +* +* struct security_hook_list - Contents of a cacheable, mappable object. +* @scalls: The beginning of the array of static calls assigned to this hook. +* @hook: The callback for the hook. +* @lsm: The name of the lsm that owns this hook. */ struct security_hook_list { -struct hlist_node list; -struct hlist_head *head; +struct lsm_static_call *scalls;union security_list_options hook;const struct lsm_id *lsmid; } __randomize_layout;
@@ -110,10 +161,12 @@ static inline struct xattr *lsm_get_xattr_slot(struct xattr *xattrs,* care of the common case and reduces the amount of * text involved. */ -#define LSM_HOOK_INIT (HEAD ,HOOK ) \ - { .head = &security_hook_heads.HEAD, .hook = { .HEAD = HOOK } } +#define LSM_HOOK_INIT (NAME ,HOOK ) \ + { \ + .scalls = static_calls_table.NAME, \ + .hook = { .NAME = HOOK } \ + } -extern struct security_hook_heads security_hook_heads;extern char *lsm_names; extern void security_add_hooks(struct security_hook_list *hooks, int count,
@@ -151,5 +204,6 @@ extern struct lsm_info __start_early_lsm_info[], __end_early_lsm_info[];__aligned(sizeof(unsigned long)) extern int lsm_inode_alloc (struct inode *inode); +extern struct lsm_static_calls_table static_calls_table__ro_after_init ;#endif /* ! __LINUX_LSM_HOOKS_H */
security/security.c +134 -64
355 lines not on this page · raw message
Signature · 1 line
2.45.0.rc1.225.g2a3ae87e7f-goog
KP Singh
maintainerPATCH v10 4/5 security: Update non standard hooks to use static calls
In reply to KP SinghThere are some LSM hooks which do not use the common pattern followed by other LSM hooks and thus cannot use call_{int, void}_hook macros and instead use lsm_for_each_hook macro which still results in indirect call.
There is one additional generalizable pattern where a hook matching an lsmid is called and the indirect calls for these are addressed with the newly added call_hook_with_lsmid macro which internally uses an implementation similar to call_int_hook but has an additional check that matches the lsmid.
For the generic case the lsm_for_each_hook macro is updated to accept logic before and after the invocation of the LSM hook (static call) in the unrolled loop.
--- security/security.c | 229 ++++++++++++++++++++++++-------------------- 1 file changed, 125 insertions(+), 104 deletions(-)
security/security.c +125 -104
@@ -945,10 +945,41 @@ out: \RC ; \ }) -#define lsm_for_each_hook (scall,NAME ) \ - for (scall = static_calls_table.NAME; \ - scall - static_calls_table.NAME < MAX_LSM_COUNT; scall++) \ - if (static_key_enabled(&scall->active->key)) +/* +* Can be used in the context passed to lsm_for_each_hook to get the lsmid of the +* current hook +*/ +#define current_lsmid () _hook_lsmid + +#define __CALL_HOOK (NUM ,HOOK ,RC ,BODY_BEFORE ,BODY_AFTER , ...) \ +do { \ + int __maybe_unused _hook_lsmid; \ + \ + if (static_branch_unlikely(&SECURITY_HOOK_ACTIVE_KEY(HOOK, NUM))) { \ + _hook_lsmid = static_calls_table.HOOK[NUM].hl->lsmid->id; \ + BODY_BEFORE \ + RC = static_call(LSM_STATIC_CALL(HOOK, NUM))(__VA_ARGS__); \ + BODY_AFTER \ + } \ +} while (0); + +#define lsm_for_each_hook (HOOK ,RC ,BODY , ...) \ + LSM_LOOP_UNROLL(__CALL_HOOK, HOOK, RC, ;, BODY, __VA_ARGS__) + +#define call_hook_with_lsmid (HOOK ,LSMID , ...) \ +({ \ + __label__ out; \ + int RC = LSM_RET_DEFAULT(HOOK); \ + \ + LSM_LOOP_UNROLL(__CALL_HOOK, HOOK, RC, { \ + if (current_lsmid() != LSMID) \ + continue; \ + }, { \ + goto out; \ + }, __VA_ARGS__); \ +out: \ + RC; \ +})/* Security operations */
@@ -1184,7 +1215,6 @@ int security_settime64(const struct timespec64 *ts, const struct timezone *tz)*/ int security_vm_enough_memory_mm (struct mm_struct *mm,long pages) { -struct lsm_static_call *scall;int cap_sys_admin =1 ;int rc;
@@ -1195,13 +1225,18 @@ int security_vm_enough_memory_mm(struct mm_struct *mm, long pages)* agree that it should be set it will. If any module * thinks it should not be set it won't. */ -lsm_for_each_hook (scall, vm_enough_memory) { - rc = scall->hl->hook.vm_enough_memory (mm, pages); -if (rc <=0 ) { - cap_sys_admin =0 ; -break ; - } - } + +lsm_for_each_hook ( + vm_enough_memory, rc, + { + if (rc <= 0) { + cap_sys_admin =0 ; + goto out; + } + }, + mm, pages); + +out:return __vm_enough_memory (mm, pages, cap_sys_admin); }
@@ -1343,17 +1378,19 @@ int security_fs_context_dup(struct fs_context *fc, struct fs_context *src_fc)int security_fs_context_parse_param (struct fs_context *fc,struct fs_parameter *param) { -struct lsm_static_call *scall; -int trc; +int trc =LSM_RET_DEFAULT (fs_context_parse_param);int rc = -ENOPARAM ; -lsm_for_each_hook (scall, fs_context_parse_param) { - trc = scall->hl->hook.fs_context_parse_param (fc, param); -if (trc ==0 ) - rc =0 ; -else if (trc != -ENOPARAM ) -return trc; - } +lsm_for_each_hook ( + fs_context_parse_param, trc, + { + if (trc == 0) + rc = 0; + else if (trc != -ENOPARAM) + return trc; + }, + fc, param); +return rc; }
@@ -1578,15 +1615,17 @@ int security_sb_set_mnt_opts(struct super_block *sb,unsigned long kern_flags, unsigned long *set_kern_flags) { - struct lsm_static_call *scall; int rc = mnt_opts ? -EOPNOTSUPP : LSM_RET_DEFAULT(sb_set_mnt_opts); -lsm_for_each_hook (scall, sb_set_mnt_opts) { - rc = scall->hl->hook.sb_set_mnt_opts (sb, mnt_opts, kern_flags, - set_kern_flags); -if (rc !=LSM_RET_DEFAULT (sb_set_mnt_opts)) -break ; - } +lsm_for_each_hook ( + sb_set_mnt_opts, rc, + { + if (rc != LSM_RET_DEFAULT(sb_set_mnt_opts)) + goto out; + }, + sb, mnt_opts, kern_flags, set_kern_flags); + +out:return rc; }EXPORT_SYMBOL (security_sb_set_mnt_opts);
@@ -1777,7 +1816,6 @@ int security_inode_init_security(struct inode *inode, struct inode *dir,const struct qstr *qstr, const initxattrs initxattrs, void *fs_data) { - struct lsm_static_call *scall; struct xattr *new_xattrs = NULL;int ret = -EOPNOTSUPP , xattr_count =0 ;
@@ -1795,18 +1833,19 @@ int security_inode_init_security(struct inode *inode, struct inode *dir,return -ENOMEM ; } -lsm_for_each_hook (scall, inode_init_security) { - ret = scall->hl->hook.inode_init_security (inode, dir, qstr, new_xattrs, - &xattr_count); -if (ret && ret != -EOPNOTSUPP ) - goto out; +lsm_for_each_hook ( + inode_init_security, ret, + { /* * As documented in lsm_hooks.h, -EOPNOTSUPP in this context * means that the LSM is not willing to provide an xattr, not * that it wants to signal an error. Thus, continue to invoke * the remaining LSMs. */ - } + if (ret && ret != -EOPNOTSUPP) + goto out; + }, + inode, dir, qstr, new_xattrs, &xattr_count);/* If initxattrs() is NULL, xattr_count is zero, skip the call. */ if (!xattr_count)
@@ -3601,16 +3640,19 @@ int security_task_prctl(int option, unsigned long arg2, unsigned long arg3, {int thisrc;int rc =LSM_RET_DEFAULT (task_prctl); -struct lsm_static_call *scall; - -lsm_for_each_hook (scall, task_prctl) { - thisrc = scall->hl->hook.task_prctl (option, arg2, arg3, arg4, arg5); -if (thisrc !=LSM_RET_DEFAULT (task_prctl)) { - rc = thisrc; -if (thisrc !=0 ) -break ; - } - } + +lsm_for_each_hook ( + task_prctl, thisrc, + { + if (thisrc != LSM_RET_DEFAULT(task_prctl)) { + rc = thisrc; +if (thisrc !=0 ) + goto out; + } + }, + option, arg2, arg3, arg4, arg5); + +out:return rc; }
@@ -4010,7 +4052,6 @@ EXPORT_SYMBOL(security_d_instantiate);int security_getselfattr (unsigned int attr,struct lsm_ctx __user *uctx,u32 __user *size,u32 flags) { -struct lsm_static_call *scall;struct lsm_ctx lctx = { .id =LSM_ID_UNDEF , };u8 __user *base = (u8 __user *)uctx;u32 entrysize;
@@ -4048,31 +4089,40 @@ int security_getselfattr(unsigned int attr, struct lsm_ctx __user *uctx,* In the usual case gather all the data from the LSMs. * In the single case only get the data from the LSM specified. */ -lsm_for_each_hook (scall, getselfattr) { -if (single && lctx.id != scall->hl->lsmid->id) -continue ; - entrysize = left; -if (base) - uctx = (struct lsm_ctx __user *)(base + total); - rc = scall->hl->hook.getselfattr (attr, uctx, &entrysize, flags); -if (rc == -EOPNOTSUPP ) { - rc =0 ; -continue ; - } -if (rc == -E2BIG ) { - rc =0 ; - left =0 ; - toobig = true; - }else if (rc <0 ) -return rc; -else - left -= entrysize; +LSM_LOOP_UNROLL ( + __CALL_HOOK, getselfattr, rc, +/* BODY_BEFORE */ + { +if (single && lctx.id !=current_lsmid ()) +continue ; + entrysize = left; +if (base) + uctx = (struct lsm_ctx __user *)(base + total); + }, +/* BODY_AFTER */ + { +if (rc == -EOPNOTSUPP ) { + rc =0 ; + }else { +if (rc == -E2BIG ) { + rc =0 ; + left =0 ; + toobig = true; + }else if (rc <0 ) +return rc; +else + left -= entrysize; + + total += entrysize; + count += rc; +if (single) + goto out; + } + }, + attr, uctx, &entrysize, flags); + +out: - total += entrysize; - count += rc; -if (single) -break ; - }if (put_user (total, size))return -EFAULT ;if (toobig)
@@ -4103,9 +4153,8 @@ int security_getselfattr(unsigned int attr, struct lsm_ctx __user *uctx,int security_setselfattr (unsigned int attr,struct lsm_ctx __user *uctx,u32 size,u32 flags) { -struct lsm_static_call *scall;struct lsm_ctx *lctx; -int rc =LSM_RET_DEFAULT (setselfattr); +int rc;u64 required_len;if (flags)
@@ -4126,11 +4175,7 @@ int security_setselfattr(unsigned int attr, struct lsm_ctx __user *uctx, goto free_out; } -lsm_for_each_hook (scall, setselfattr) -if ((scall->hl->lsmid->id) == lctx->id) { - rc = scall->hl->hook.setselfattr (attr, lctx, size, flags); -break ; - } + rc =call_hook_with_lsmid (setselfattr, lctx->id, attr, lctx, size, flags); free_out:kfree (lctx);
@@ -4151,14 +4196,7 @@ int security_setselfattr(unsigned int attr, struct lsm_ctx __user *uctx,int security_getprocattr (struct task_struct *p,int lsmid,const char *name,char **value) { -struct lsm_static_call *scall; - -lsm_for_each_hook (scall, getprocattr) { -if (lsmid !=0 && lsmid != scall->hl->lsmid->id) -continue ; -return scall->hl->hook.getprocattr (p, name, value); - } -return LSM_RET_DEFAULT (getprocattr); +return call_hook_with_lsmid (getprocattr, lsmid, p, name, value); }/**
@@ -4175,14 +4213,7 @@ int security_getprocattr(struct task_struct *p, int lsmid, const char *name,*/ int security_setprocattr (int lsmid,const char *name,void *value,size_t size) { -struct lsm_static_call *scall; - -lsm_for_each_hook (scall, setprocattr) { -if (lsmid !=0 && lsmid != scall->hl->lsmid->id) -continue ; -return scall->hl->hook.setprocattr (name, value, size); - } -return LSM_RET_DEFAULT (setprocattr); +return call_hook_with_lsmid (setprocattr, lsmid, name, value, size); }/**
@@ -5267,23 +5298,13 @@ int security_xfrm_state_pol_flow_match(struct xfrm_state *x, struct xfrm_policy *xp, const struct flowi_common *flic) { - struct lsm_static_call *scall; -int rc =LSM_RET_DEFAULT (xfrm_state_pol_flow_match); -/* * Since this function is expected to return 0 or 1, the judgment * becomes difficult if multiple LSMs supply this call. Fortunately, * we can use the first LSM's judgment because currently only SELinux * supplies this call. -* -* For speed optimization, we explicitly break the loop rather than -* using the macro */ -lsm_for_each_hook (scall, xfrm_state_pol_flow_match) { - rc = scall->hl->hook.xfrm_state_pol_flow_match (x, xp, flic); -break ; - } -return rc; +return call_int_hook (xfrm_state_pol_flow_match, x, xp, flic); }/**
Signature · 1 line
2.45.0.rc1.225.g2a3ae87e7f-goog
KP Singh
maintainerPATCH v10 5/5 bpf: Only enable BPF LSM hooks when an LSM program is attached
In reply to KP SinghBPF LSM hooks have side-effects (even when a default value is returned), as some hooks end up behaving differently due to the very presence of the hook.
The static keys guarding the BPF LSM hooks are disabled by default and enabled only when a BPF program is attached implementing the hook logic. This avoids the issue of the side-effects and also the minor overhead associated with the empty callback.
security_file_ioctl:
0xffffffff818f0e30 <+0>: endbr64
0xffffffff818f0e34 <+4>: nopl 0x0(%rax,%rax,1)
0xffffffff818f0e39 <+9>: push %rbp
0xffffffff818f0e3a <+10>: push %r14 0xffffffff818f0e3c <+12>: push %rbx 0xffffffff818f0e3d <+13>: mov %rdx,%rbx 0xffffffff818f0e40 <+16>: mov %esi,%ebp 0xffffffff818f0e42 <+18>: mov %rdi,%r14 0xffffffff818f0e45 <+21>: jmp 0xffffffff818f0e57 <security_file_ioctl+39>
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Static key enabled for SELinux
0xffffffff818f0e47 <+23>: xchg %ax,%ax
^^^^^^^^^^^^^^
Static key disabled for BPF. This gets patched when a BPF LSM program is attached
0xffffffff818f0e49 <+25>: xor %eax,%eax 0xffffffff818f0e4b <+27>: xchg %ax,%ax 0xffffffff818f0e4d <+29>: pop %rbx 0xffffffff818f0e4e <+30>: pop %r14 0xffffffff818f0e50 <+32>: pop %rbp 0xffffffff818f0e51 <+33>: cs jmp 0xffffffff82c00000 <__x86_return_thunk> 0xffffffff818f0e57 <+39>: endbr64 0xffffffff818f0e5b <+43>: mov %r14,%rdi 0xffffffff818f0e5e <+46>: mov %ebp,%esi 0xffffffff818f0e60 <+48>: mov %rbx,%rdx 0xffffffff818f0e63 <+51>: call 0xffffffff819033c0 <selinux_file_ioctl> 0xffffffff818f0e68 <+56>: test %eax,%eax 0xffffffff818f0e6a <+58>: jne 0xffffffff818f0e4d <security_file_ioctl+29> 0xffffffff818f0e6c <+60>: jmp 0xffffffff818f0e47 <security_file_ioctl+23> 0xffffffff818f0e6e <+62>: endbr64 0xffffffff818f0e72 <+66>: mov %r14,%rdi 0xffffffff818f0e75 <+69>: mov %ebp,%esi 0xffffffff818f0e77 <+71>: mov %rbx,%rdx 0xffffffff818f0e7a <+74>: call 0xffffffff8141e3b0 <bpf_lsm_file_ioctl> 0xffffffff818f0e7f <+79>: test %eax,%eax 0xffffffff818f0e81 <+81>: jne 0xffffffff818f0e4d <security_file_ioctl+29> 0xffffffff818f0e83 <+83>: jmp 0xffffffff818f0e49 <security_file_ioctl+25> 0xffffffff818f0e85 <+85>: endbr64 0xffffffff818f0e89 <+89>: mov %r14,%rdi 0xffffffff818f0e8c <+92>: mov %ebp,%esi 0xffffffff818f0e8e <+94>: mov %rbx,%rdx 0xffffffff818f0e91 <+97>: pop %rbx 0xffffffff818f0e92 <+98>: pop %r14
0xffffffff818f0e94 <+100>: pop %rbp
0xffffffff818f0e95 <+101>: ret
--- include/linux/lsm_hooks.h | 26 ++++++++++++++++++++++++- kernel/bpf/trampoline.c | 40 +++++++++++++++++++++++++++++++++++---- security/bpf/hooks.c | 2 +- security/security.c | 33 +++++++++++++++++++++++++++++++- 4 files changed, 94 insertions(+), 7 deletions(-)
include/linux/lsm_hooks.h +25 -1
@@ -110,11 +110,14 @@ struct lsm_id {* @scalls: The beginning of the array of static calls assigned to this hook. * @hook: The callback for the hook. * @lsm: The name of the lsm that owns this hook. +* @default_state: The state of the LSM hook when initialized. If set to false, +* the static key guarding the hook will be set to disabled. */ struct security_hook_list {struct lsm_static_call *scalls;union security_list_options hook;const struct lsm_id *lsmid; +bool default_enabled; } __randomize_layout;/*
@@ -164,7 +167,15 @@ static inline struct xattr *lsm_get_xattr_slot(struct xattr *xattrs,#define LSM_HOOK_INIT (NAME ,HOOK ) \ { \ .scalls = static_calls_table.NAME, \ - .hook = { .NAME = HOOK } \ + .hook = { .NAME = HOOK }, \ + .default_enabled = true \ + } + +#define LSM_HOOK_INIT_DISABLED (NAME ,HOOK ) \ + { \ + .scalls = static_calls_table.NAME, \ + .hook = { .NAME = HOOK }, \ + .default_enabled = false \ }extern char *lsm_names;
@@ -206,4 +217,17 @@ extern struct lsm_info __start_early_lsm_info[], __end_early_lsm_info[];extern int lsm_inode_alloc (struct inode *inode);extern struct lsm_static_calls_table static_calls_table__ro_after_init ; +#ifdef CONFIG_SECURITY + +int security_toggle_hook (void *addr,bool value); + +#else + +static inline int security_toggle_hook (void *addr,bool value) +{ +return -EINVAL ; +} + +#endif /* CONFIG_SECURITY */ +#endif /* ! __LINUX_LSM_HOOKS_H */
kernel/bpf/trampoline.c +36 -4
@@ -521,6 +521,21 @@ static enum bpf_tramp_prog_type bpf_attach_type_to_tramp(struct bpf_prog *prog) } } +static int bpf_trampoline_toggle_lsm (struct bpf_trampoline *tr, +enum bpf_tramp_prog_type kind) +{ +struct bpf_tramp_link *link; +bool found = false; + +hlist_for_each_entry (link, &tr->progs_hlist[kind], tramp_hlist) { +if (link->link.prog->type ==BPF_PROG_TYPE_LSM ) { + found = true; +break ; + } + } +return security_toggle_hook (tr->func.addr, found); +} +static int __bpf_trampoline_link_prog (struct bpf_tramp_link *link,struct bpf_trampoline *tr) {enum bpf_tramp_prog_type kind;
@@ -560,11 +575,22 @@ static int __bpf_trampoline_link_prog(struct bpf_tramp_link *link, struct bpf_trhlist_add_head (&link->tramp_hlist, &tr->progs_hlist[kind]); tr->progs_cnt[kind]++; - err =bpf_trampoline_update (tr, true/* lock_direct_mutex */ ); -if (err) { -hlist_del_init (&link->tramp_hlist); - tr->progs_cnt[kind]--; + +if (link->link.prog->type ==BPF_PROG_TYPE_LSM ) { + err =bpf_trampoline_toggle_lsm (tr, kind); +if (err) + goto cleanup; } + + err =bpf_trampoline_update (tr, true/* lock_direct_mutex */ ); +if (err) + goto cleanup; + +return 0 ; + +cleanup: +hlist_del_init (&link->tramp_hlist); + tr->progs_cnt[kind]--;return err; }
@@ -593,6 +619,12 @@ static int __bpf_trampoline_unlink_prog(struct bpf_tramp_link *link, struct bpf_ }hlist_del_init (&link->tramp_hlist); tr->progs_cnt[kind]--; + +if (link->link.prog->type ==BPF_PROG_TYPE_LSM ) { + err =bpf_trampoline_toggle_lsm (tr, kind); +WARN (err,"BUG: unable to toggle BPF LSM hook" ); + } +return bpf_trampoline_update (tr, true/* lock_direct_mutex */ ); }
security/bpf/hooks.c +1 -1
@@ -9,7 +9,7 @@static struct security_hook_list bpf_lsm_hooks[]__ro_after_init = { #define LSM_HOOK(RET, DEFAULT, NAME, ...) \ - LSM_HOOK_INIT(NAME, bpf_lsm_##NAME), + LSM_HOOK_INIT_DISABLED(NAME, bpf_lsm_##NAME), #include <linux/lsm_hook_defs.h> #undef LSM_HOOK LSM_HOOK_INIT(inode_free_security, bpf_inode_storage_free),
security/security.c +32 -1
@@ -407,7 +407,8 @@ static void __init lsm_static_call_init(struct security_hook_list *hl)__static_call_update (scall->key, scall->trampoline, hl->hook.lsm_func_addr); scall->hl = hl; -static_branch_enable (scall->active); +if (hl->default_enabled) +static_branch_enable (scall->active);return ; } scall++;
@@ -885,6 +886,36 @@ int lsm_fill_user_ctx(struct lsm_ctx __user *uctx, u32 *uctx_len,return rc; } +/** +* security_toggle_hook - Toggle the state of the LSM hook. +* @hook_addr: The address of the hook to be toggled. +* @state: Whether to enable for disable the hook. +* +* Returns 0 on success, -EINVAL if the address is not found. +*/ +int security_toggle_hook (void *hook_addr,bool state) +{ +struct lsm_static_call *scalls = ((void *)&static_calls_table); +unsigned long num_entries = + (sizeof (static_calls_table) /sizeof (struct lsm_static_call )); +int i; + +for (i =0 ; i < num_entries; i++) { +if (!scalls[i].hl) +continue ; + +if (scalls[i].hl->hook.lsm_func_addr != hook_addr) +continue ; + +if (state) +static_branch_enable (scalls[i].active); +else +static_branch_disable (scalls[i].active); +return 0 ; + } +return -EINVAL ; +} +/* * The default value of the LSM hook is defined in linux/lsm_hook_defs.h and * can be accessed with:
Signature · 1 line
2.45.0.rc1.225.g2a3ae87e7f-goog
Re: [PATCH bpf-next v10 5/5] bpf: Only enable BPF LSM hooks when an LSM program is attached
Quoted 20 lines · KP Singh
[...]
security/security.c +19
-0+/** +* security_toggle_hook - Toggle the state of the LSM hook. +* @hook_addr: The address of the hook to be toggled. +* @state: Whether to enable for disable the hook. +* +* Returns 0 on success, -EINVAL if the address is not found. +*/ +int security_toggle_hook (void *hook_addr,bool state) +{ +struct lsm_static_call *scalls = ((void *)&static_calls_table); +unsigned long num_entries = + (sizeof (static_calls_table) /sizeof (struct lsm_static_call )); +int i; + +for (i =0 ; i < num_entries; i++) { +if (!scalls[i].hl) +continue ; + +if (scalls[i].hl->hook.lsm_func_addr != hook_addr)
security/security.c int lsm_fill_user_ctx(struct lsm_ctx __user *uctx, u32 *uctx_len, · line 917
Quoted 10 lines
security/security.c +10
-0+continue ; + +if (state) +static_branch_enable (scalls[i].active); +else +static_branch_disable (scalls[i].active); +return 0 ; + } +return -EINVAL ; +}
First of all: patches 1-4 are great. They have a measurable performance benefit; let's get those in.
But here I come to patch 5 where I will suggest the exact opposite of what Paul said in v9 for patch 5. :P
I don't want to have a global function that can be used to disable LSMs. We got an entire distro (RedHat) to change their SELinux configurations to get rid of CONFIG_SECURITY_SELINUX_DISABLE (and therefore CONFIG_SECURITY_WRITABLE_HOOKS), via commit f22f9aaf6c3d ("selinux:
remove the runtime disable functionality"). We cannot reintroduce that, and I'm hoping Paul will agree, given this reminder of LSM history. :)
Run-time hook changing should be BPF_LSM specific, if it exists at all.
Signature · 1 line
Kees Cook
Paul Moore
maintainerRe: [PATCH bpf-next v10 5/5] bpf: Only enable BPF LSM hooks when an LSM program is attached
Quoted 36 lines · Kees Cook
Quoted 20 lines · KP Singh
[...]
security/security.c +19
-0+/** +* security_toggle_hook - Toggle the state of the LSM hook. +* @hook_addr: The address of the hook to be toggled. +* @state: Whether to enable for disable the hook. +* +* Returns 0 on success, -EINVAL if the address is not found. +*/ +int security_toggle_hook (void *hook_addr,bool state) +{ +struct lsm_static_call *scalls = ((void *)&static_calls_table); +unsigned long num_entries = + (sizeof (static_calls_table) /sizeof (struct lsm_static_call )); +int i; + +for (i =0 ; i < num_entries; i++) { +if (!scalls[i].hl) +continue ; + +if (scalls[i].hl->hook.lsm_func_addr != hook_addr)security/security.c int lsm_fill_user_ctx(struct lsm_ctx __user *uctx, u32 *uctx_len, · line 917
Quoted 10 lines
security/security.c +10
-0+continue ; + +if (state) +static_branch_enable (scalls[i].active); +else +static_branch_disable (scalls[i].active); +return 0 ; + } +return -EINVAL ; +}First of all: patches 1-4 are great. They have a measurable performance benefit; let's get those in.
Quoted 2 lines
But here I come to patch 5 where I will suggest the exact opposite of what Paul said in v9 for patch 5. :P
For those looking up v9 of the patchset, you'll be looking for patch *4*, not patch 5, as there were only four patches in the v9 series. Patch 4/5 in the v10 series is a new addition to the stack.
Beyond that, I'm guessing you are referring to my comment regarding bpf_lsm_toggle_hook() Kees? The one that starts with "More ugh. If we are going to solve things this way ..."?
Quoted 8 lines
I don't want to have a global function that can be used to disable LSMs. We got an entire distro (RedHat) to change their SELinux configurations to get rid of
CONFIG_SECURITY_SELINUX_DISABLE(and thereforeCONFIG_SECURITY_WRITABLE_HOOKS), via commitf22f9aaf6c3d("selinux:
remove the runtime disable functionality"). We cannot reintroduce that, and I'm hoping Paul will agree, given this reminder of LSM history. :)Run-time hook changing should be
BPF_LSMspecific, if it exists at all.
I don't want individual LSMs manipulating the LSM hook state directly; they go through the LSM layer to register their hooks, they should go through the LSM layer to unregister or enable/disable their hooks. I'm going to be pretty inflexible on this point.
Honestly, I see this more as a problem in the BPF LSM design (although one might argue it's an implementation issue?), just as I saw the SELinux runtime disable as a problem. If you're upset with the runtime hook disable, and you should be, fix the BPF LSM, don't force more bad architecture on the LSM layer.
Signature · 1 line
paul-moore.com
Re: [PATCH bpf-next v10 5/5] bpf: Only enable BPF LSM hooks when an LSM program is attached
Quoted 4 lines · Paul Moore
I don't want individual LSMs manipulating the LSM hook state directly; they go through the LSM layer to register their hooks, they should go through the LSM layer to unregister or enable/disable their hooks. I'm going to be pretty inflexible on this point.
No other LSMs unregister or disable hooks. :) Let's drop patch 5; 1-4 stand alone.
Quoted 5 lines
Honestly, I see this more as a problem in the BPF LSM design (although one might argue it's an implementation issue?), just as I saw the SELinux runtime disable as a problem. If you're upset with the runtime hook disable, and you should be, fix the BPF LSM, don't force more bad architecture on the LSM layer.
We'll have to come back to this later. It's a separate (but closely related) issue.
Signature · 1 line
Kees Cook
Paul Moore
maintainerRe: [PATCH bpf-next v10 5/5] bpf: Only enable BPF LSM hooks when an LSM program is attached
Quoted 8 lines · Kees Cook
Quoted 4 lines · Paul Moore
I don't want individual LSMs manipulating the LSM hook state directly; they go through the LSM layer to register their hooks, they should go through the LSM layer to unregister or enable/disable their hooks. I'm going to be pretty inflexible on this point.
No other LSMs unregister or disable hooks. :)
To be clear, it doesn't really matter if it is all of the LSMs or just one; preserving the interface abstraction as much as possible is worthwhile and good.
Quoted 8 lines
Quoted 5 lines
Honestly, I see this more as a problem in the BPF LSM design (although one might argue it's an implementation issue?), just as I saw the SELinux runtime disable as a problem. If you're upset with the runtime hook disable, and you should be, fix the BPF LSM, don't force more bad architecture on the LSM layer.
We'll have to come back to this later. It's a separate (but closely related) issue.
It's a moot point given KP's latest suggestion, but just to give some insight on priorities, correctness is always my primary concern and while the performance improvement in this patchset is a nice win, the most interesting part to me was that it provided a solution for the empty-BPF-LSM-hook problem that has been an ongoing source of problems. Yes, we have made a number of improvements in that area, and I expect those to continue, but selectively enabling/disabling the BPF LSM hook implementations is a big step forward.
Signature · 1 line
paul-moore.com
KP Singh
maintainerRe: [PATCH bpf-next v10 5/5] bpf: Only enable BPF LSM hooks when an LSM program is attached
In reply to Paul MooreQuoted 44 lines · Paul Moore
Quoted 36 lines · Kees Cook
Quoted 20 lines · KP Singh
[...]
(quoted diff) +19
-0+/** + * security_toggle_hook - Toggle the state of the LSM hook. + * @hook_addr: The address of the hook to be toggled. + * @state: Whether to enable for disable the hook. + * + * Returns 0 on success, -EINVAL if the address is not found. + */ +int security_toggle_hook(void *hook_addr, bool state) +{ + struct lsm_static_call *scalls = ((void *)&static_calls_table); + unsigned long num_entries = + (sizeof(static_calls_table) / sizeof(struct lsm_static_call)); + int i; + + for (i = 0; i < num_entries; i++) { + if (!scalls[i].hl) + continue; + + if (scalls[i].hl->hook.lsm_func_addr != hook_addr)Review
Quoted 10 lines
(quoted diff) +10
-0+ continue; + + if (state) + static_branch_enable(scalls[i].active); + else + static_branch_disable(scalls[i].active); + return 0; + } + return -EINVAL; +}First of all: patches 1-4 are great. They have a measurable performance benefit; let's get those in.
Quoted 2 lines
But here I come to patch 5 where I will suggest the exact opposite of what Paul said in v9 for patch 5. :P
Quoted 16 lines
For those looking up v9 of the patchset, you'll be looking for patch *4*, not patch 5, as there were only four patches in the v9 series. Patch 4/5 in the v10 series is a new addition to the stack.
Beyond that, I'm guessing you are referring to my comment regarding
bpf_lsm_toggle_hook()Kees? The one that starts with "More ugh. If we are going to solve things this way ..."?Quoted 8 lines
I don't want to have a global function that can be used to disable LSMs. We got an entire distro (RedHat) to change their SELinux configurations to get rid of
CONFIG_SECURITY_SELINUX_DISABLE(and thereforeCONFIG_SECURITY_WRITABLE_HOOKS), via commitf22f9aaf6c3d("selinux:
remove the runtime disable functionality"). We cannot reintroduce that, and I'm hoping Paul will agree, given this reminder of LSM history. :)Run-time hook changing should be
BPF_LSMspecific, if it exists at all.
One idea here is that only LSM hooks with default_state = false can be toggled.
This would also any ROPs that try to abuse this function. Maybe we can call "default_disabled" .toggleable (or dynamic)
and change the corresponding LSM_INIT_TOGGLEABLE. Kees, Paul, this may be a fair middle ground?
Something like:
include/linux/lsm_hooks.h +8 -4
@@ -117,7 +117,7 @@ struct security_hook_list {struct lsm_static_call *scalls;union security_list_options hook;const struct lsm_id *lsmid; -bool default_enabled; +bool toggleable; } __randomize_layout;/*
@@ -168,14 +168,18 @@ static inline struct xattr *lsm_get_xattr_slot(struct xat> { \ .scalls = static_calls_table.NAME, \ .hook = { .NAME = HOOK }, \ - .default_enabled = true \ + .toggleable = false \ } -#define LSM_HOOK_INIT_DISABLED (NAME ,HOOK ) \ +/* +* Toggleable LSM hooks are enabled at runtime with +* security_toggle_hook and are initialized as inactive. +*/ +#define LSM_HOOK_INIT_TOGGLEABLE (NAME ,HOOK ) \ { \ .scalls = static_calls_table.NAME, \ .hook = { .NAME = HOOK }, \ - .default_enabled = false \ + .toggleable = true \ }extern char *lsm_names;
security/bpf/hooks.c +1 -1
@@ -9,7 +9,7 @@static struct security_hook_list bpf_lsm_hooks[]__ro_after_init = { #define LSM_HOOK(RET, DEFAULT, NAME, ...) \ - LSM_HOOK_INIT_DISABLED(NAME, bpf_lsm_##NAME), + LSM_HOOK_INIT_TOGGLEABLE(NAME, bpf_lsm_##NAME), #include <linux/lsm_hook_defs.h> #undef LSM_HOOK LSM_HOOK_INIT(inode_free_security, bpf_inode_storage_free),
+ * security_toggle_hook and are initialized as inactive.
+ */
+#define LSM_HOOK_INIT_TOGGLEABLE(NAME, HOOK) \
{ \
.scalls = static_calls_table.NAME, \
.hook = { .NAME = HOOK }, \
- .default_enabled = false \
+ .toggleable = true \
} extern char *lsm_names;
security/bpf/hooks.c +1 -1
@@ -9,7 +9,7 @@static struct security_hook_list bpf_lsm_hooks[]__ro_after_init = { #define LSM_HOOK(RET, DEFAULT, NAME, ...) \ - LSM_HOOK_INIT_DISABLED(NAME, bpf_lsm_##NAME), + LSM_HOOK_INIT_TOGGLEABLE(NAME, bpf_lsm_##NAME), #include <linux/lsm_hook_defs.h> #undef LSM_HOOK LSM_HOOK_INIT(inode_free_security, bpf_inode_storage_free),
kpsingh@kpsingh:~/projects/linux$ git diff
include/linux/lsm_hooks.h +8 -4
@@ -117,7 +117,7 @@ struct security_hook_list {struct lsm_static_call *scalls;union security_list_options hook;const struct lsm_id *lsmid; -bool default_enabled; +bool toggleable; } __randomize_layout;/*
@@ -168,14 +168,18 @@ static inline struct xattr *lsm_get_xattr_slot(struct xattr *xattrs, { \ .scalls = static_calls_table.NAME, \ .hook = { .NAME = HOOK }, \ - .default_enabled = true \ + .toggleable = false \ } -#define LSM_HOOK_INIT_DISABLED (NAME ,HOOK ) \ +/* +* Toggleable LSM hooks are enabled at runtime with +* security_toggle_hook and are initialized as inactive. +*/ +#define LSM_HOOK_INIT_TOGGLEABLE (NAME ,HOOK ) \ { \ .scalls = static_calls_table.NAME, \ .hook = { .NAME = HOOK }, \ - .default_enabled = false \ + .toggleable = true \ }extern char *lsm_names;
security/bpf/hooks.c +1 -1
@@ -9,7 +9,7 @@static struct security_hook_list bpf_lsm_hooks[]__ro_after_init = { #define LSM_HOOK(RET, DEFAULT, NAME, ...) \ - LSM_HOOK_INIT_DISABLED(NAME, bpf_lsm_##NAME), + LSM_HOOK_INIT_TOGGLEABLE(NAME, bpf_lsm_##NAME), #include <linux/lsm_hook_defs.h> #undef LSM_HOOK LSM_HOOK_INIT(inode_free_security, bpf_inode_storage_free),
security/security.c +5 -1
@@ -407,7 +407,8 @@ static void __init lsm_static_call_init(struct security_hook_list *hl)__static_call_update (scall->key, scall->trampoline, hl->hook.lsm_func_addr); scall->hl = hl; -if (hl->default_enabled) +/* Toggleable hooks are inactive by default */ +if (!hl->toggleable)static_branch_enable (scall->active);return ; }
@@ -901,6 +902,9 @@ int security_toggle_hook(void *hook_addr, bool state)int i;for (i =0 ; i < num_entries; i++) { +if (!scalls[i].hl->toggleable) +continue ; +if (!scalls[i].hl)continue ;
- KP
Quoted 14 lines
I don't want individual LSMs manipulating the LSM hook state directly; they go through the LSM layer to register their hooks, they should go through the LSM layer to unregister or enable/disable their hooks. I'm going to be pretty inflexible on this point.
Honestly, I see this more as a problem in the BPF LSM design (although one might argue it's an implementation issue?), just as I saw the SELinux runtime disable as a problem. If you're upset with the runtime hook disable, and you should be, fix the BPF LSM, don't force more bad architecture on the LSM layer.
Signature · 1 line
paul-moore.com
Re: [PATCH bpf-next v10 5/5] bpf: Only enable BPF LSM hooks when an LSM program is attached
Quoted 133 lines · KP Singh
Quoted 44 lines · Paul Moore
Quoted 36 lines · Kees Cook
Quoted 20 lines · KP Singh
[...]
(quoted diff) +19
-0+/** + * security_toggle_hook - Toggle the state of the LSM hook. + * @hook_addr: The address of the hook to be toggled. + * @state: Whether to enable for disable the hook. + * + * Returns 0 on success, -EINVAL if the address is not found. + */ +int security_toggle_hook(void *hook_addr, bool state) +{ + struct lsm_static_call *scalls = ((void *)&static_calls_table); + unsigned long num_entries = + (sizeof(static_calls_table) / sizeof(struct lsm_static_call)); + int i; + + for (i = 0; i < num_entries; i++) { + if (!scalls[i].hl) + continue; + + if (scalls[i].hl->hook.lsm_func_addr != hook_addr)Review
Quoted 10 lines
(quoted diff) +10
-0+ continue; + + if (state) + static_branch_enable(scalls[i].active); + else + static_branch_disable(scalls[i].active); + return 0; + } + return -EINVAL; +}First of all: patches 1-4 are great. They have a measurable performance benefit; let's get those in.
Quoted 2 lines
But here I come to patch 5 where I will suggest the exact opposite of what Paul said in v9 for patch 5. :P
Quoted 16 lines
For those looking up v9 of the patchset, you'll be looking for patch *4*, not patch 5, as there were only four patches in the v9 series. Patch 4/5 in the v10 series is a new addition to the stack.
Beyond that, I'm guessing you are referring to my comment regarding
bpf_lsm_toggle_hook()Kees? The one that starts with "More ugh. If we are going to solve things this way ..."?Quoted 8 lines
I don't want to have a global function that can be used to disable LSMs. We got an entire distro (RedHat) to change their SELinux configurations to get rid of
CONFIG_SECURITY_SELINUX_DISABLE(and thereforeCONFIG_SECURITY_WRITABLE_HOOKS), via commitf22f9aaf6c3d("selinux:
remove the runtime disable functionality"). We cannot reintroduce that, and I'm hoping Paul will agree, given this reminder of LSM history. :)Run-time hook changing should be
BPF_LSMspecific, if it exists at all.One idea here is that only LSM hooks with
default_state= false can be toggled.This would also any ROPs that try to abuse this function. Maybe we can call "
default_disabled" .toggleable (or dynamic)and change the corresponding
LSM_INIT_TOGGLEABLE. Kees, Paul, this may be a fair middle ground?Something like:
include/linux/lsm_hooks.h +8
-4@@ -117,7 +117,7 @@ struct security_hook_list {struct lsm_static_call *scalls;union security_list_options hook;const struct lsm_id *lsmid; -bool default_enabled; +bool toggleable; } __randomize_layout;/* @@ -168,14 +168,18 @@ static inline struct xattr *lsm_get_xattr_slot(struct xattr *xattrs, { \ .scalls = static_calls_table.NAME, \ .hook = { .NAME = HOOK }, \ - .default_enabled = true \ + .toggleable = false \ } -#define LSM_HOOK_INIT_DISABLED (NAME ,HOOK ) \ +/* +* Toggleable LSM hooks are enabled at runtime with +* security_toggle_hook and are initialized as inactive. +*/ +#define LSM_HOOK_INIT_TOGGLEABLE (NAME ,HOOK ) \ { \ .scalls = static_calls_table.NAME, \ .hook = { .NAME = HOOK }, \ - .default_enabled = false \ + .toggleable = true \ }extern char *lsm_names;security/bpf/hooks.c +1
-1@@ -9,7 +9,7 @@static struct security_hook_list bpf_lsm_hooks[]__ro_after_init = { #define LSM_HOOK(RET, DEFAULT, NAME, ...) \ - LSM_HOOK_INIT_DISABLED(NAME, bpf_lsm_##NAME), + LSM_HOOK_INIT_TOGGLEABLE(NAME, bpf_lsm_##NAME), #include <linux/lsm_hook_defs.h> #undef LSM_HOOK LSM_HOOK_INIT(inode_free_security, bpf_inode_storage_free),security/security.c +2
-1@@ -407,7 +407,8 @@ static void __init lsm_static_call_init(struct security_hook_list *hl)__static_call_update (scall->key, scall->trampoline, hl->hook.lsm_func_addr); scall->hl = hl; -if (hl->default_enabled) +/* Toggleable hooks are inactive by default */ +if (!hl->toggleable)static_branch_enable (scall->active);return ; }
security/security.c int security_toggle_hook(void *hook_addr, bool state) · line 909
Quoted 8 lines
security/security.c +3
-0@@ -901,6 +902,9 @@ int security_toggle_hook(void *hook_addr, bool state)int i;for (i =0 ; i < num_entries; i++) { +if (!scalls[i].hl->toggleable) +continue ; +if (!scalls[i].hl)continue ;
Yeah, I like this! It's a routine that is walking read-only data to make the choice, and it's specific to a pre-defined characteristic that an LSM would need to opt into. My concerns are addressed! Thanks! :)
Signature · 1 line
Kees Cook
Paul Moore
maintainerRe: [PATCH bpf-next v10 5/5] bpf: Only enable BPF LSM hooks when an LSM program is attached
In reply to KP SinghQuoted 5 lines · KP Singh
One idea here is that only LSM hooks with
default_state= false can be toggled.This would also any ROPs that try to abuse this function. Maybe we can call "
default_disabled" .toggleable (or dynamic)and change the corresponding
LSM_INIT_TOGGLEABLE. Kees, Paul, this may be a fair middle ground?
Seems reasonable to me, although I think it's worth respinning to get a proper look at it in context. Some naming bikeshedding below ...
include/linux/lsm_hooks.h struct security_hook_list { · line 121
Quoted 11 lines
include/linux/lsm_hooks.h +1
-1@@ -117,7 +117,7 @@ struct security_hook_list {struct lsm_static_call *scalls;union security_list_options hook;const struct lsm_id *lsmid; -bool default_enabled; +bool toggleable; } __randomize_layout;
How about inverting the boolean and using something like 'fixed' instead of 'toggleable'?
Signature · 1 line
paul-moore.com
KP Singh
maintainerRe: [PATCH bpf-next v10 5/5] bpf: Only enable BPF LSM hooks when an LSM program is attached
Quoted 14 lines · Paul Moore
Quoted 5 lines · KP Singh
One idea here is that only LSM hooks with
default_state= false can be toggled.This would also any ROPs that try to abuse this function. Maybe we can call "
default_disabled" .toggleable (or dynamic)and change the corresponding
LSM_INIT_TOGGLEABLE. Kees, Paul, this may be a fair middle ground?Seems reasonable to me, although I think it's worth respinning to get a proper look at it in context. Some naming bikeshedding below ...
Quoted 15 lines
include/linux/lsm_hooks.h struct security_hook_list { · line 121
Quoted 11 lines
include/linux/lsm_hooks.h +1
-1@@ -117,7 +117,7 @@ struct security_hook_list {struct lsm_static_call *scalls;union security_list_options hook;const struct lsm_id *lsmid; -bool default_enabled; +bool toggleable; } __randomize_layout;How about inverting the boolean and using something like 'fixed' instead of 'toggleable'?
I would prefer not changing the all the other LSM_HOOK_INIT calls as we change the default behaviour then. How about calling it "dynamic"
LSM_HOOK_INIT_DYNAMIC and call the boolean dynamic
- KP
Quoted 2 lines
Signature · 1 line
paul-moore.com
KP Singh
maintainerRe: [PATCH bpf-next v10 5/5] bpf: Only enable BPF LSM hooks when an LSM program is attached
Quoted 31 lines · KP Singh
Quoted 15 lines · Paul Moore
Quoted 5 lines · KP Singh
One idea here is that only LSM hooks with
default_state= false can be toggled.This would also any ROPs that try to abuse this function. Maybe we can call "
default_disabled" .toggleable (or dynamic)and change the corresponding
LSM_INIT_TOGGLEABLE. Kees, Paul, this may be a fair middle ground?Seems reasonable to me, although I think it's worth respinning to get a proper look at it in context. Some naming bikeshedding below ...
Quoted 15 lines
include/linux/lsm_hooks.h struct security_hook_list { · line 121
Quoted 11 lines
include/linux/lsm_hooks.h +1
-1@@ -117,7 +117,7 @@ struct security_hook_list {struct lsm_static_call *scalls;union security_list_options hook;const struct lsm_id *lsmid; -bool default_enabled; +bool toggleable; } __randomize_layout;How about inverting the boolean and using something like 'fixed' instead of 'toggleable'?
Quoted 4 lines
I would prefer not changing the all the other
LSM_HOOK_INITcalls as we change the default behaviour then. How about calling it "dynamic"
LSM_HOOK_INIT_DYNAMICand call the boolean dynamic
Paul, others, any preferences here?
- KP
Quoted 5 lines
- KP
Quoted 2 lines
--
paul-moore.com
KP Singh
maintainerRe: [PATCH bpf-next v10 5/5] bpf: Only enable BPF LSM hooks when an LSM program is attached
Quoted 36 lines · KP Singh
Quoted 31 lines · KP Singh
Quoted 30 lines · Paul Moore
Quoted 5 lines · KP Singh
One idea here is that only LSM hooks with
default_state= false can be toggled.This would also any ROPs that try to abuse this function. Maybe we can call "
default_disabled" .toggleable (or dynamic)and change the corresponding
LSM_INIT_TOGGLEABLE. Kees, Paul, this may be a fair middle ground?Seems reasonable to me, although I think it's worth respinning to get a proper look at it in context. Some naming bikeshedding below ...
include/linux/lsm_hooks.h struct security_hook_list { · line 121
Quoted 11 lines
include/linux/lsm_hooks.h +1
-1@@ -117,7 +117,7 @@ struct security_hook_list {struct lsm_static_call *scalls;union security_list_options hook;const struct lsm_id *lsmid; -bool default_enabled; +bool toggleable; } __randomize_layout;How about inverting the boolean and using something like 'fixed' instead of 'toggleable'?
Quoted 6 lines
Quoted 4 lines
I would prefer not changing the all the other
LSM_HOOK_INITcalls as we change the default behaviour then. How about calling it "dynamic"
LSM_HOOK_INIT_DYNAMICand call the boolean dynamicPaul, others, any preferences here?
I will throw another in the mix, LSM_HOOK_RUNTIME which captures the nature nicely. (i.e. these hooks are enabled / disabled at runtime). Thoughts?
Quoted 7 lines
- KP
Quoted 4 lines
- KP
Quoted 2 lines
--
paul-moore.com
Re: [PATCH bpf-next v10 5/5] bpf: Only enable BPF LSM hooks when an LSM program is attached
Quoted 31 lines · KP Singh
Quoted 31 lines · KP Singh
Quoted 27 lines · KP Singh
Quoted 27 lines · Paul Moore
Quoted 5 lines · KP Singh
One idea here is that only LSM hooks with
default_state= false can be toggled.This would also any ROPs that try to abuse this function. Maybe we can call "
default_disabled" .toggleable (or dynamic)and change the corresponding
LSM_INIT_TOGGLEABLE. Kees, Paul, this may be a fair middle ground?Seems reasonable to me, although I think it's worth respinning to get a proper look at it in context. Some naming bikeshedding below ...
include/linux/lsm_hooks.h struct security_hook_list { · line 121
Quoted 11 lines
include/linux/lsm_hooks.h +1
-1@@ -117,7 +117,7 @@ struct security_hook_list {struct lsm_static_call *scalls;union security_list_options hook;const struct lsm_id *lsmid; -bool default_enabled; +bool toggleable; } __randomize_layout;How about inverting the boolean and using something like 'fixed' instead of 'toggleable'?
Quoted 6 lines
Quoted 5 lines
Quoted 4 lines
I would prefer not changing the all the other
LSM_HOOK_INITcalls as we change the default behaviour then. How about calling it "dynamic"
LSM_HOOK_INIT_DYNAMICand call the boolean dynamicPaul, others, any preferences here?
I will throw another in the mix,
LSM_HOOK_RUNTIMEwhich captures the nature nicely. (i.e. these hooks are enabled / disabled at runtime). Thoughts?
I think the bike shed should be painted blue.
Sorry. Seriously, I like LSM_HOOK_RUNTIME.