Skip to contentSkip to conversation

lockd: Use *-y instead of *-objs in Makefile

PATCH Applied Andy Shevchenko 3 participants 5 messages May 8, 2024 – Jun 6, 2024

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 lockd: Use *-y instead of *-objs in Makefile

*-objs suffix is reserved rather for (user-space) host programs while usually *-y suffix is used for kernel drivers (although *-objs works for that purpose for now).

Let's correct the old usages of *-objs in Makefiles.

---

Note, the original approach is weirdest from the existing. Only a few drivers use this (-objs-y) one most likely by mistake.

 fs/lockd/Makefile | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)
fs/lockd/Makefile +4 -5
index ac9f9d84510e..fe3e23dd29c3 100644
@@ -7,8 +7,7 @@ ccflags-y += -I$(src)			# needed for trace events
 
 obj-$(CONFIG_LOCKD) += lockd.o
 
-lockd-objs-y += clntlock.o clntproc.o clntxdr.o host.o svc.o svclock.o \
-	        svcshare.o svcproc.o svcsubs.o mon.o trace.o xdr.o
-lockd-objs-$(CONFIG_LOCKD_V4) += clnt4xdr.o xdr4.o svc4proc.o
-lockd-objs-$(CONFIG_PROC_FS) += procfs.o
-lockd-objs		      := $(lockd-objs-y)
+lockd-y := clntlock.o clntproc.o clntxdr.o host.o svc.o svclock.o \
+	   svcshare.o svcproc.o svcsubs.o mon.o trace.o xdr.o
+lockd-$(CONFIG_LOCKD_V4) += clnt4xdr.o xdr4.o svc4proc.o
+lockd-$(CONFIG_PROC_FS) += procfs.o
Signature · 1 line
2.43.0.rc1.1336.g36b5255a03ac
Acked-by on v1 1/1
#2 lore raw
In reply to Andy Shevchenko
Quoted 35 lines · Andy Shevchenko

*-objs suffix is reserved rather for (user-space) host programs while usually *-y suffix is used for kernel drivers (although *-objs works for that purpose for now).

Let's correct the old usages of *-objs in Makefiles.

---

Note, the original approach is weirdest from the existing. Only a few drivers use this (-objs-y) one most likely by mistake.

 fs/lockd/Makefile | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)
fs/lockd/Makefile +4 -5
index ac9f9d84510e..fe3e23dd29c3 100644
@@ -7,8 +7,7 @@ ccflags-y += -I$(src)			# needed for trace events
 
 obj-$(CONFIG_LOCKD) += lockd.o
 
-lockd-objs-y += clntlock.o clntproc.o clntxdr.o host.o svc.o svclock.o \
-	        svcshare.o svcproc.o svcsubs.o mon.o trace.o xdr.o
-lockd-objs-$(CONFIG_LOCKD_V4) += clnt4xdr.o xdr4.o svc4proc.o
-lockd-objs-$(CONFIG_PROC_FS) += procfs.o
-lockd-objs		      := $(lockd-objs-y)
+lockd-y := clntlock.o clntproc.o clntxdr.o host.o svc.o svclock.o \
+	   svcshare.o svcproc.o svcsubs.o mon.o trace.o xdr.o
+lockd-$(CONFIG_LOCKD_V4) += clnt4xdr.o xdr4.o svc4proc.o
+lockd-$(CONFIG_PROC_FS) += procfs.o
Signature · 1 line
2.43.0.rc1.1336.g36b5255a03ac

Unless, of course, you'd like me to take this through the nfsd tree.

Signature · 1 line
Chuck Lever
#3 lore raw
Quoted 6 lines · Chuck Lever
Quoted 5 lines · Andy Shevchenko

*-objs suffix is reserved rather for (user-space) host programs while usually *-y suffix is used for kernel drivers (although *-objs works for that purpose for now).

Let's correct the old usages of *-objs in Makefiles.

...

Quoted 3 lines

Unless, of course, you'd like me to take this through the nfsd tree.

Why not? Otherwise it seems nobody have taken it so far.

Signature · 2 lines
With Best Regards,
Andy Shevchenko
Applied
#4 lore raw
Quoted 8 lines · Andy Shevchenko
Quoted 6 lines · Chuck Lever
Quoted 5 lines · Andy Shevchenko

*-objs suffix is reserved rather for (user-space) host programs while usually *-y suffix is used for kernel drivers (although *-objs works for that purpose for now).

Let's correct the old usages of *-objs in Makefiles.

Quoted 7 lines

...

Quoted 3 lines

Unless, of course, you'd like me to take this through the nfsd tree.

Why not? Otherwise it seems nobody have taken it so far.

Applied to nfsd-next (for v6.11). Thanks!

Signature · 1 line
Chuck Lever