Skip to contentSkip to conversation

drm/msm/dpu: fix encoder irq wait skip

PATCH Superseded Barnabás Czémán 2 participants 2 messages May 9, 2024

Subsystems (3)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/msm/dpu: fix encoder irq wait skip

The irq_idx is unsigned so it cannot be lower than zero, better to change the condition to check if it is equal with zero. It could not cause any issue because a valid irq index starts from one.

---
 drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c +1 -1
index 119f3ea50a7c..cf7d769ab3b9 100644
@@ -428,7 +428,7 @@ int dpu_encoder_helper_wait_for_irq(struct dpu_encoder_phys *phys_enc,
 		return -EWOULDBLOCK;
 	}
 
-	if (irq_idx < 0) {
+	if (irq_idx == 0) {
 		DRM_DEBUG_KMS("skip irq wait id=%u, callback=%ps\n",
 			      DRMID(phys_enc->parent), func);
 		return 0;

---
base-commit: 704ba27ac55579704ba1289392448b0c66b56258
change-id: 20240509-irq_wait-49444cea77e2

Best regards,

Signature · 1 line
Barnabás Czémán <[email protected]>
Reviewed-by on v1 1/1
#1 lore raw
Quoted 9 lines · Barnabás Czémán

The irq_idx is unsigned so it cannot be lower than zero, better to change the condition to check if it is equal with zero. It could not cause any issue because a valid irq index starts from one.

---
  drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

I think we also need

Fixes 5a9d50150c2c ("drm/msm/dpu: shift IRQ indices by 1")

With that,

Quoted 19 lines
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c +1 -2
index 119f3ea50a7c..cf7d769ab3b9 100644
@@ -428,7 +428,7 @@ int dpu_encoder_helper_wait_for_irq(struct dpu_encoder_phys *phys_enc,
  		return -EWOULDBLOCK;
  	}
 
-	if (irq_idx < 0) {
+	if (irq_idx == 0) {
  		DRM_DEBUG_KMS("skip irq wait id=%u, callback=%ps\n",
  			      DRMID(phys_enc->parent), func);
  		return 0;
 
---

base-commit: 704ba27ac55579704ba1289392448b0c66b56258
change-id: 20240509-irq_wait-49444cea77e2

Best regards,