Skip to contentSkip to conversation

linux-yocto: Enable team net driver

PATCH Superseded Khem Raj 2 participants 4 messages May 9, 2024

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Khem Raj

author
#0 lore raw

PATCH 1/1 linux-yocto: Enable team net driver

Cc Bruce Ashfield <[email protected]>
---
 meta/recipes-kernel/linux/linux-yocto_6.6.bb | 1 +
 1 file changed, 1 insertion(+)
meta/recipes-kernel/linux/linux-yocto_6.6.bb +1 -0
index 71bfbf9e032..4503ec94ae9 100644
@@ -66,6 +66,7 @@ KERNEL_FEATURES:append:qemux86-64=" cfg/sound.scc cfg/paravirt_kvm.scc"
 KERNEL_FEATURES:append = " ${@bb.utils.contains("TUNE_FEATURES", "mx32", " cfg/x32.scc", "", d)}"
 KERNEL_FEATURES:append = " ${@bb.utils.contains("DISTRO_FEATURES", "ptest", " features/scsi/scsi-debug.scc features/nf_tables/nft_test.scc", "", d)}"
 KERNEL_FEATURES:append = " ${@bb.utils.contains("DISTRO_FEATURES", "ptest", " features/gpio/mockup.scc features/gpio/sim.scc", "", d)}"
+KERNEL_FEATURES:append = " ${@bb.utils.contains("DISTRO_FEATURES", "ptest", " features/net/team/team.scc", "", d)}"
 KERNEL_FEATURES:append:powerpc =" arch/powerpc/powerpc-debug.scc"
 KERNEL_FEATURES:append:powerpc64 =" arch/powerpc/powerpc-debug.scc"
 KERNEL_FEATURES:append:powerpc64le =" arch/powerpc/powerpc-debug.scc"
Signature · 1 line
2.45.0
#1 lore raw
Quoted 12 lines · Khem Raj
Cc Bruce Ashfield <[email protected]>
---
 meta/recipes-kernel/linux/linux-yocto_6.6.bb | 1 +
 1 file changed, 1 insertion(+)
meta/recipes-kernel/linux/linux-yocto_6.6.bb +0 -0
index 71bfbf9e032..4503ec94ae9 100644

meta/recipes-kernel/linux/linux-yocto_6.6.bb KERNEL_FEATURES:append:qemux86-64=" cfg/sound.scc cfg/paravirt_kvm.scc" · line 68

Quoted 3 lines
meta/recipes-kernel/linux/linux-yocto_6.6.bb +0 -0
@@ -66,6 +66,7 @@ KERNEL_FEATURES:append:qemux86-64=" cfg/sound.scc cfg/paravirt_kvm.scc"
 KERNEL_FEATURES:append = " ${@bb.utils.contains("TUNE_FEATURES", "mx32", " cfg/x32.scc", "", d)}"
 KERNEL_FEATURES:append = " ${@bb.utils.contains("DISTRO_FEATURES", "ptest", " features/scsi/scsi-debug.scc features/nf_tables/nft_test.scc", "", d)}"
 KERNEL_FEATURES:append = " ${@bb.utils.contains("DISTRO_FEATURES", "ptest", " features/gpio/mockup.scc features/gpio/sim.scc", "", d)}"

We are getting quite a few of these now and that isn't a problem. But I think we should
probably start putting comments above the enable lines so casual users will know why
the various fragments are being enabled.

For example, I don't really know what the team driver is, and why ptest needs it!

Bruce

Quoted 7 lines
meta/recipes-kernel/linux/linux-yocto_6.6.bb +1 -1
+KERNEL_FEATURES:append = " ${@bb.utils.contains("DISTRO_FEATURES", "ptest", " features/net/team/team.scc", "", d)}"
 KERNEL_FEATURES:append:powerpc =" arch/powerpc/powerpc-debug.scc"
 KERNEL_FEATURES:append:powerpc64 =" arch/powerpc/powerpc-debug.scc"
 KERNEL_FEATURES:append:powerpc64le =" arch/powerpc/powerpc-debug.scc"
--

2.45.0

Signature · 3 lines
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II
author
#2 lore raw
Quoted 24 lines · Bruce Ashfield
Quoted 12 lines · Khem Raj
Cc Bruce Ashfield <[email protected]>
---
 meta/recipes-kernel/linux/linux-yocto_6.6.bb | 1 +
 1 file changed, 1 insertion(+)
meta/recipes-kernel/linux/linux-yocto_6.6.bb +0 -0
index 71bfbf9e032..4503ec94ae9 100644

meta/recipes-kernel/linux/linux-yocto_6.6.bb KERNEL_FEATURES:append:qemux86-64=" cfg/sound.scc cfg/paravirt_kvm.scc" · line 68

Quoted 3 lines
meta/recipes-kernel/linux/linux-yocto_6.6.bb +0 -0
@@ -66,6 +66,7 @@ KERNEL_FEATURES:append:qemux86-64=" cfg/sound.scc cfg/paravirt_kvm.scc"
 KERNEL_FEATURES:append = " ${@bb.utils.contains("TUNE_FEATURES", "mx32", " cfg/x32.scc", "", d)}"
 KERNEL_FEATURES:append = " ${@bb.utils.contains("DISTRO_FEATURES", "ptest", " features/scsi/scsi-debug.scc features/nf_tables/nft_test.scc", "", d)}"
 KERNEL_FEATURES:append = " ${@bb.utils.contains("DISTRO_FEATURES", "ptest", " features/gpio/mockup.scc features/gpio/sim.scc", "", d)}"

We are getting quite a few of these now and that isn't a problem. But I think we should
probably start putting comments above the enable lines so casual users will know why
the various fragments are being enabled.

Quoted 2 lines

For example, I don't really know what the team driver is, and why ptest needs it!

when we expand ptests for more than core layer, then certain packages e.g. libteam in meta-oe [1] this config option is needed to be enabled.

[1] https://git.openembedded.org/meta-openembedded/commit/?id=df35bef3ae6411900efdfc3ea5ade23820e9af2f

Quoted 16 lines

Bruce

Quoted 7 lines
meta/recipes-kernel/linux/linux-yocto_6.6.bb +1 -1
+KERNEL_FEATURES:append = " ${@bb.utils.contains("DISTRO_FEATURES", "ptest", " features/net/team/team.scc", "", d)}"
 KERNEL_FEATURES:append:powerpc =" arch/powerpc/powerpc-debug.scc"
 KERNEL_FEATURES:append:powerpc64 =" arch/powerpc/powerpc-debug.scc"
 KERNEL_FEATURES:append:powerpc64le =" arch/powerpc/powerpc-debug.scc"
--

2.45.0

--
- Thou shalt not follow the NULL pointer, for chaos and madness await thee at its end
- "Use the force Harry" - Gandalf, Star Trek II

#3 lore raw
Quoted 26 lines · Khem Raj
Quoted 24 lines · Bruce Ashfield
Quoted 12 lines · Khem Raj
Cc Bruce Ashfield <[email protected]>
---
 meta/recipes-kernel/linux/linux-yocto_6.6.bb | 1 +
 1 file changed, 1 insertion(+)
meta/recipes-kernel/linux/linux-yocto_6.6.bb +0 -0
index 71bfbf9e032..4503ec94ae9 100644

meta/recipes-kernel/linux/linux-yocto_6.6.bb KERNEL_FEATURES:append:qemux86-64=" cfg/sound.scc cfg/paravirt_kvm.scc" · line 68

Quoted 3 lines
meta/recipes-kernel/linux/linux-yocto_6.6.bb +0 -0
@@ -66,6 +66,7 @@ KERNEL_FEATURES:append:qemux86-64=" cfg/sound.scc cfg/paravirt_kvm.scc"
 KERNEL_FEATURES:append = " ${@bb.utils.contains("TUNE_FEATURES", "mx32", " cfg/x32.scc", "", d)}"
 KERNEL_FEATURES:append = " ${@bb.utils.contains("DISTRO_FEATURES", "ptest", " features/scsi/scsi-debug.scc features/nf_tables/nft_test.scc", "", d)}"
 KERNEL_FEATURES:append = " ${@bb.utils.contains("DISTRO_FEATURES", "ptest", " features/gpio/mockup.scc features/gpio/sim.scc", "", d)}"

We are getting quite a few of these now and that isn't a problem. But I think we should
probably start putting comments above the enable lines so casual users will know why
the various fragments are being enabled.

Quoted 7 lines
Quoted 2 lines

For example, I don't really know what the team driver is, and why ptest needs it!

when we expand ptests for more than core layer, then certain packages e.g. libteam in meta-oe [1] this config option is needed to be enabled.

Cool. I don't have any concerns with the enablement itself, I'd just prefer that we put a line above it in the file to indicate what depends on that configuration so there's no confusion later.

Bruce

Quoted 18 lines

[1] https://git.openembedded.org/meta-openembedded/commit/?id=df35bef3ae6411900efdfc3ea5ade23820e9af2f

Quoted 16 lines

Bruce

Quoted 7 lines
meta/recipes-kernel/linux/linux-yocto_6.6.bb +1 -1
+KERNEL_FEATURES:append = " ${@bb.utils.contains("DISTRO_FEATURES", "ptest", " features/net/team/team.scc", "", d)}"
 KERNEL_FEATURES:append:powerpc =" arch/powerpc/powerpc-debug.scc"
 KERNEL_FEATURES:append:powerpc64 =" arch/powerpc/powerpc-debug.scc"
 KERNEL_FEATURES:append:powerpc64le =" arch/powerpc/powerpc-debug.scc"
--

2.45.0

--
- Thou shalt not follow the NULL pointer, for chaos and madness await thee at its end
- "Use the force Harry" - Gandalf, Star Trek II

Signature · 3 lines
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II