madvise11: ignore EBUSY for MADV_SOFT_OFFLINE
PATCH 1/1 madvise11: ignore EBUSY for MADV_SOFT_OFFLINE
The EBUSY error could be easily triggered on small system with kernel-debug. By not treating EBUSY as a failure, the test can avoid false positives where the test environment itself might frequently cause resource contention.
Test output:
madvise11.c:409: TINFO: Spawning 4 threads, with a total of 640 memory pages madvise11.c:163: TINFO: Thread [0] returned 0, succeeded. madvise11.c:163: TINFO: Thread [2] returned 0, succeeded. madvise11.c:163: TINFO: Thread [1] returned 0, succeeded. madvise11.c:163: TINFO: Thread [3] returned 0, succeeded.
madvise11.c:198: TPASS: soft-offline / mmap race still clean <--- end of 1st test
madvise11.c:132: TFAIL: madvise failed: EBUSY (16) <--- ERROR!
...
From kernel log:
[ 431.590511] soft offline: 0xbfa8f: page migration failed 1, type 0x800000008002e(referenced|uptodate|dirty|active|swapbacked|node=0|zone=1) ... [ 435.510819] soft offline: 0x98fb6: page migration failed 1, type 0x800000008000e(referenced|uptodate|dirty|swapbacked|node=0|zone=1) ...
Kernel callpath:
do_madvise()
---
#ifdef CONFIG_MEMORY_FAILURE
if (behavior == MADV_HWPOISON || behavior == MADV_SOFT_OFFLINE)
return madvise_inject_error(behavior, start, start + len_in);
#endif
---
madvise_inject_error()
soft_offline_page()
soft_offline_in_use_page()
...
2727 pr_info("soft offline: %#lx: %s migration failed %ld, type %pGp\n",
2728 pfn, msg_page[huge], ret, &page->flags);
2729 if (ret > 0)
2730 ret = -EBUSY; <--- Here--- testcases/kernel/syscalls/madvise/madvise11.c | 2 ++ 1 file changed, 2 insertions(+)
testcases/kernel/syscalls/madvise/madvise11.c +2 -0
@@ -128,6 +128,8 @@ static int allocate_offline(int tnum)return -1 ;if (madvise (ptrs[num_alloc], pagesize,MADV_SOFT_OFFLINE ) ==-1 ) { +if (errno ==EBUSY ) +continue ;if (errno !=EINVAL )tst_res (TFAIL |TERRNO ,"madvise failed" );if (errno ==EINVAL )
Signature · 5 lines
2.45.0 -- Mailing list info: https://lists.linux.it/listinfo/ltp
Hi Li,
...
testcases/kernel/syscalls/madvise/madvise11.c static int allocate_offline(int tnum) · line 132
Quoted 7 lines
+++
b/testcases/kernel/syscalls/madvise/madvise11.ctestcases/kernel/syscalls/madvise/madvise11.c +2
-0@@ -128,6 +128,8 @@ static int allocate_offline(int tnum)return -1 ;if (madvise (ptrs[num_alloc], pagesize,MADV_SOFT_OFFLINE ) ==-1 ) { +if (errno ==EBUSY ) +continue ;
LGTM
Kind regards,
Petr
Quoted 3 lines
testcases/kernel/syscalls/madvise/madvise11.c +0
-0if (errno !=EINVAL )tst_res (TFAIL |TERRNO ,"madvise failed" );if (errno ==EINVAL )
Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
Patch merged, thank you.
Quoted 23 lines · Petr Vorel
Hi Li,
...
testcases/kernel/syscalls/madvise/madvise11.c static int allocate_offline(int tnum) · line 130
Quoted 5 lines
+++
b/testcases/kernel/syscalls/madvise/madvise11.ctestcases/kernel/syscalls/madvise/madvise11.c +0
-0@@ -128,6 +128,8 @@ static int allocate_offline(int tnum)return -1 ; if (madvise(ptrs[num_alloc], pagesize,
MADV_SOFT_OFFLINE) == -1) {testcases/kernel/syscalls/madvise/madvise11.c static int allocate_offline(int tnum) · line 132
Quoted 2 lines
testcases/kernel/syscalls/madvise/madvise11.c +2
-0+if (errno ==EBUSY ) +continue ;LGTM
Reviewed-by Petr Vorel <[email protected]>Kind regards,
PetrReview static int allocate_offline(int tnum) · line 134
Quoted 2 lines
(quoted diff) +0
-0if (errno != EINVAL) tst_res(TFAIL | TERRNO, "madvisefailed");
Quoted 1 line
testcases/kernel/syscalls/madvise/madvise11.c +0
-0if (errno ==EINVAL )
Signature · 5 lines
Regards, Li Wang -- Mailing list info: https://lists.linux.it/listinfo/ltp