crypto: hifn_795x: Remove unused hifn_*_command structs
PATCH 1/1 crypto: hifn_795x: Remove unused hifn_*_command structs
From: "Dr. David Alan Gilbert" <[email protected]>
Remove 'hifn_mac_command' and 'hifn_comp_command' which are unused. They're the same structure as 'hifn_crypt_command' which is used.
(I was tempted to remove
hifn_base_result
hifn_comp_result
hifn_mac_result and
hifn_crypt_result
which are also unused, but they vary, and perhaps they're telling someone in the future what to look at.)
--- drivers/crypto/hifn_795x.c | 17 ----------------- 1 file changed, 17 deletions(-)
drivers/crypto/hifn_795x.c +0 -17
@@ -495,16 +495,6 @@ struct hifn_crypt_command {#define HIFN_CRYPT_CMD_SRCLEN_M 0xc000#define HIFN_CRYPT_CMD_SRCLEN_S 14 -/* -* Structure to help build up the command data structure. -*/ -struct hifn_mac_command { -volatile __le16 masks; -volatile __le16 header_skip; -volatile __le16 source_count; -volatile __le16 reserved; -}; -#define HIFN_MAC_CMD_ALG_MASK 0x0001#define HIFN_MAC_CMD_ALG_SHA1 0x0000#define HIFN_MAC_CMD_ALG_MD5 0x0001
@@ -526,13 +516,6 @@ struct hifn_mac_command {#define HIFN_MAC_CMD_POS_IPSEC 0x0200#define HIFN_MAC_CMD_NEW_KEY 0x0800 -struct hifn_comp_command { -volatile __le16 masks; -volatile __le16 header_skip; -volatile __le16 source_count; -volatile __le16 reserved; -}; -#define HIFN_COMP_CMD_SRCLEN_M 0xc000#define HIFN_COMP_CMD_SRCLEN_S 14#define HIFN_COMP_CMD_ONE 0x0100/* must be one */
Signature · 1 line
2.45.0
Quoted 13 lines · * [email protected] ([email protected]) wrote:
From: "Dr. David Alan Gilbert" <[email protected]>
Remove '
hifn_mac_command' and 'hifn_comp_command' which are unused. They're the same structure as 'hifn_crypt_command' which is used.(I was tempted to remove
hifn_base_result
hifn_comp_result
hifn_mac_resultand
hifn_crypt_result
which are also unused, but they vary, and perhaps they're telling someone in the future what to look at.)
Quoted 1 line
Signed-off-by Dr. David Alan Gilbert <[email protected]>
Ping.
Quoted 42 lines
--- drivers/crypto/hifn_795x.c | 17 ----------------- 1 file changed, 17 deletions(-)drivers/crypto/hifn_795x.c +0
-17@@ -495,16 +495,6 @@ struct hifn_crypt_command {#define HIFN_CRYPT_CMD_SRCLEN_M 0xc000#define HIFN_CRYPT_CMD_SRCLEN_S 14 -/* -* Structure to help build up the command data structure. -*/ -struct hifn_mac_command { -volatile __le16 masks; -volatile __le16 header_skip; -volatile __le16 source_count; -volatile __le16 reserved; -}; -#define HIFN_MAC_CMD_ALG_MASK 0x0001#define HIFN_MAC_CMD_ALG_SHA1 0x0000#define HIFN_MAC_CMD_ALG_MD5 0x0001@@ -526,13 +516,6 @@ struct hifn_mac_command {#define HIFN_MAC_CMD_POS_IPSEC 0x0200#define HIFN_MAC_CMD_NEW_KEY 0x0800 -struct hifn_comp_command { -volatile __le16 masks; -volatile __le16 header_skip; -volatile __le16 source_count; -volatile __le16 reserved; -}; -#define HIFN_COMP_CMD_SRCLEN_M 0xc000#define HIFN_COMP_CMD_SRCLEN_S 14#define HIFN_COMP_CMD_ONE 0x0100/* must be one */ Signature · 1 line
2.45.0
Signature · 4 lines
-----Open up your eyes, open up your mind, open up your code ------- / Dr. David Alan Gilbert | Running GNU/Linux | Happy \ \ dave @ treblig.org | | In Hex / \ _________________________|_____ http://www.treblig.org |_______/
Herbert Xu
maintainerQuoted 13 lines · On Sat, May 11, 2024 at 03:54:26PM +0100, [email protected] wrote:
From: "Dr. David Alan Gilbert" <[email protected]>
Remove '
hifn_mac_command' and 'hifn_comp_command' which are unused. They're the same structure as 'hifn_crypt_command' which is used.(I was tempted to remove
hifn_base_result
hifn_comp_result
hifn_mac_resultand
hifn_crypt_result
which are also unused, but they vary, and perhaps they're telling someone in the future what to look at.)
Quoted 4 lines
Signed-off-by Dr. David Alan Gilbert <[email protected]>--- drivers/crypto/hifn_795x.c | 17 ----------------- 1 file changed, 17 deletions(-)
Patch applied. Thanks.
Signature · 3 lines
Email: Herbert Xu <[email protected]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt