Skip to contentSkip to conversation

kconfig: use sym_get_choice_menu() in sym_check_prop()

PATCH New Masahiro Yamada 1 participant 1 message May 13, 2024

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 kconfig: use sym_get_choice_menu() in sym_check_prop()

Choices and their members are associated via the P_CHOICE property.

Currently, prop_get_symbol(sym_get_choice_prop()) is used to obtain the choice of the given choice member.

Replace it with sym_get_choice_menu(), which retrieves the choice without relying on P_CHOICE.

---

 scripts/kconfig/menu.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
scripts/kconfig/menu.c +2 -4
index bee96c9964fd..53151c5a6028 100644
@@ -263,11 +263,9 @@ static void sym_check_prop(struct symbol *sym)
 					    sym->name);
 			}
 			if (sym_is_choice(sym)) {
-				struct property *choice_prop =
-					sym_get_choice_prop(sym2);
+				struct menu *choice = sym_get_choice_menu(sym2);
 
-				if (!choice_prop ||
-				    prop_get_symbol(choice_prop) != sym)
+				if (!choice || choice->sym != sym)
 					prop_warn(prop,
 						  "choice default symbol '%s' is not contained in the choice",
 						  sym2->name);
Signature · 1 line
2.40.1