mm: page_alloc: fix the incorrect parameter
Subsystems (2)
PATCH 1/1 mm: page_alloc: fix the incorrect parameter
The first parameter passed to set_pageblock_migratetype should be the buddy, not the page. Let's change it back correctly.
--- mm/page_alloc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
mm/page_alloc.c +1 -1
@@ -1728,7 +1728,7 @@ bool move_freepages_block_isolate(struct zone *zone, struct page *page,del_page_from_free_list (buddy, zone, order,get_pfnblock_migratetype (buddy, pfn)); -set_pageblock_migratetype (page, migratetype); +set_pageblock_migratetype (buddy, migratetype);split_large_buddy (zone, buddy, pfn, order);return true; }
Signature · 1 line
2.25.1
Johannes Weiner
reviewerQuoted 2 lines · Yajun Deng
The first parameter passed to
set_pageblock_migratetypeshould be the buddy, not the page. Let's change it back correctly.
No it shouldn't be.
Quoted 11 lines
Fixes fd919a85cd55 ("mm: page_isolation: prepare for hygienic freelists")Signed-off-by Yajun Deng <[email protected]>--- mm/page_alloc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)mm/page_alloc.c +0
-0
mm/page_alloc.c bool move_freepages_block_isolate(struct zone *zone, struct page *page, · line 1732
Quoted 6 lines
mm/page_alloc.c +1
-1@@ -1728,7 +1728,7 @@ bool move_freepages_block_isolate(struct zone *zone, struct page *page,del_page_from_free_list (buddy, zone, order,get_pfnblock_migratetype (buddy, pfn)); -set_pageblock_migratetype (page, migratetype); +set_pageblock_migratetype (buddy, migratetype);split_large_buddy (zone, buddy, pfn, order);
[ pageblock | pageblock ]
^ ^
buddy page
We're trying to isolate the second pageblock, but it's part of a bigger buddy. Remove buddy from the free list, update the migratetype of page, then split and free the chunks back. This puts the first pageblock back on the original freelist and the second block onto the isolate list.
In the else branch, it's the first block we're interested in:
[ pageblock | pageblock ]
^
page
So again, take the whole thing off, but now mark the first block isolate, then split and free.
Quoted 67 lines · Johannes Weiner
Quoted 5 lines · Yajun Deng
The first parameter passed to
set_pageblock_migratetypeshould be thebuddy, not the page. Let's change it back correctly.
No it shouldn't be.
Quoted 27 lines
Fixes fd919a85cd55 ("mm: page_isolation: prepare for hygienic freelists")Signed-off-by Yajun Deng <[email protected]>---
mm/page_alloc.c | 2 +-1 file changed, 1 insertion(+), 1 deletion(-)diff --git
a/mm/page_alloc.cb/mm/page_alloc.cindex
cd584aace6bf..5422f6f8975d100644---
a/mm/page_alloc.c+++
b/mm/page_alloc.c@@ -1728,7 +1728,7 @@ bool move_freepages_block_isolate(struct zone *zone, struct page *page,
del_page_from_free_list(buddy, zone, order,
Quoted 8 lines
get_pfnblock_migratetype(buddy, pfn));-
set_pageblock_migratetype(page, migratetype);+
set_pageblock_migratetype(buddy, migratetype);
split_large_buddy(zone, buddy, pfn, order);[ pageblock | pageblock ]
^ ^
buddy page
We're trying to isolate the second pageblock, but it's part of a
bigger buddy. Remove buddy from the free list, update the migratetype
of page, then split and free the chunks back. This puts the first
pageblock back on the original freelist and the second block onto the
isolate list.
In the else branch, it's the first block we're interested in:
[ pageblock | pageblock ]
Quoted 8 lines
^
page
So again, take the whole thing off, but now mark the first block
isolate, then split and free.
Got it, thank you for your detailed explanation.