Adding support to load secure firmware for HS devices
Subsystems (3)
cover Adding support to load secure firmware for HS devices
Some use case needs rproc firmware to be loaded at u-boot stage, using following commands at u-boot shell, firmware could be loaded
=> setenv dorprocboot 1
=> run boot_rprocs
For Secure devices, secure version of rproc firmware should be loaded, which is appended by sec keyword[0].
but currently non-secure firmware is loaded even for secure devices. So adding support for loading secure firmware on Secured devices.
[0]: https://gist.github.com/uditkumarti/cd8bf6a448079b59145d17a0e8bf13b7
Bootlogs:
GP : https://gist.github.com/uditkumarti/23a00c313e1c28b62537aab733a585df#file-gp_device line 65 onwards HS : https://gist.github.com/uditkumarti/23a00c313e1c28b62537aab733a585df#file-hs-device line 60 onwards
Manorit Chawdhry (3):
include: mach-k3: move k3 security functions to security.h
drivers: remoteproc: ti_k3 : enable secure booting with firmware
images
mach-k3: common.c: add a flag for booting authenticated rproc binaries
Udit Kumar (1):
include: env: ti: Add support for secure firmwares
arch/arm/mach-k3/common.c | 4 +++- arch/arm/mach-k3/common.h | 4 ++-- arch/arm/mach-k3/include/mach/security.h | 11 +++++++++++ drivers/remoteproc/ti_k3_dsp_rproc.c | 4 ++++ drivers/remoteproc/ti_k3_r5f_rproc.c | 4 ++++ include/env/ti/k3_rproc.env | 6 +++++- include/env/ti/ti_common.env | 1 + 7 files changed, 30 insertions(+), 4 deletions(-) create mode 100644 arch/arm/mach-k3/include/mach/security.h
Signature · 1 line
2.34.1
PATCH 1/4 include: mach-k3: move k3 security functions to security.h
From: Manorit Chawdhry <[email protected]>
ti_secure_image_post_process and ti_secure_image_check_binary is used for the authentication purposes in the current boot flow. Authentication of remoteproc firmware images require ti_secure_image_post_process to be available outside mach-k3.
--- arch/arm/mach-k3/common.h | 4 ++-- arch/arm/mach-k3/include/mach/security.h | 11 +++++++++++ 2 files changed, 13 insertions(+), 2 deletions(-) create mode 100644 arch/arm/mach-k3/include/mach/security.h
arch/arm/mach-k3/common.h +2 -2
@@ -2,12 +2,13 @@/* * K3: Architecture common definitions * -* Copyright (C) 2018 Texas Instruments Incorporated - https://www.ti.com/ +* Copyright (C) 2018-2024 Texas Instruments Incorporated - https://www.ti.com/ * Lokesh Vutla <[email protected]> */ #include <asm/armv7_mpu.h> #include <asm/hardware.h> +#include <mach/security.h> #define K3_FIREWALL_BACKGROUND_BIT (8)
@@ -41,7 +42,6 @@ void spl_enable_cache(void);void mmr_unlock (uintptr_t base,u32 partition);bool is_rom_loaded_sysfw (struct rom_extended_boot_data *data);enum k3_device_type get_device_type (void ); -void ti_secure_image_post_process (void **p_image,size_t *p_size);struct ti_sci_handle *get_ti_sci_handle (void );void do_board_detect (void );void ti_secure_image_check_binary (void **p_image,size_t *p_size);
arch/arm/mach-k3/include/mach/security.h new file +11 -0
@@ -0,0 +1,11 @@ +/* SPDX-License-Identifier: GPL-2.0+ */ +/* +* K3: Security related definitions +* +* Copyright (C) 2024 Texas Instruments Incorporated - https://www.ti.com/ +* Manorit Chawdhry <[email protected]> +*/ + +#include <linux/types.h> + +void ti_secure_image_post_process (void **p_image,size_t *p_size);
Signature · 1 line
2.34.1
PATCH 2/4 drivers: remoteproc: ti_k3 : enable secure booting with firmware images
In reply to Udit KumarFrom: Manorit Chawdhry <[email protected]>
Remoteproc firmware images aren't authenticated in the current boot flow. Authenticates remoteproc firmware images to complete the root of trust in secure booting.
--- drivers/remoteproc/ti_k3_dsp_rproc.c | 4 ++++ drivers/remoteproc/ti_k3_r5f_rproc.c | 4 ++++ 2 files changed, 8 insertions(+)
drivers/remoteproc/ti_k3_dsp_rproc.c +4 -0
@@ -21,6 +21,7 @@#include <linux/sizes.h> #include <linux/soc/ti/ti_sci_protocol.h> #include "ti_sci_proc.h" +#include <mach/security.h> #define KEYSTONE_RPROC_LOCAL_ADDRESS_MASK (SZ_16M - 1)
@@ -127,6 +128,7 @@ static int k3_dsp_load(struct udevice *dev, ulong addr, ulong size)struct k3_dsp_privdata *dsp =dev_get_priv (dev);struct k3_dsp_boot_data *data = dsp->data;u32 boot_vector; +void *image_addr = (void *)addr;int ret;if (dsp->in_use) {
@@ -148,6 +150,8 @@ static int k3_dsp_load(struct udevice *dev, ulong addr, ulong size) goto proc_release; } +ti_secure_image_post_process (&image_addr, &size); + ret =rproc_elf_load_image (dev, addr, size);if (ret <0 ) {dev_err (dev,"Loading elf failed %d\n" , ret);
drivers/remoteproc/ti_k3_r5f_rproc.c +4 -0
@@ -20,6 +20,7 @@#include <linux/kernel.h> #include <linux/soc/ti/ti_sci_protocol.h> #include "ti_sci_proc.h" +#include <mach/security.h> /* * R5F's view of this address can either be for ATCM or BTCM with the other
@@ -301,6 +302,7 @@ static int k3_r5f_load(struct udevice *dev, ulong addr, ulong size)u64 boot_vector;u32 ctrl, sts, cfg =0 ;bool mem_auto_init; +void *image_addr = (void *)addr;int ret;dev_dbg (dev,"%s addr = 0x%lx, size = 0x%lx\n" , __func__, addr, size);
@@ -328,6 +330,8 @@ static int k3_r5f_load(struct udevice *dev, ulong addr, ulong size)k3_r5f_init_tcm_memories (core, mem_auto_init); +ti_secure_image_post_process (&image_addr, &size); + ret =rproc_elf_load_image (dev, addr, size);if (ret <0 ) {dev_err (dev,"Loading elf failedi %d\n" , ret);
Signature · 1 line
2.34.1
PATCH 3/4 include: env: ti: Add support for secure firmwares
In reply to Udit KumarSecure firmwares must be loaded if SOC is secure, currently rproc framework chooses non-secure firmware always.
So adding support to load secure firmware, when SOC is secure
--- include/env/ti/k3_rproc.env | 6 +++++- include/env/ti/ti_common.env | 1 + 2 files changed, 6 insertions(+), 1 deletion(-)
include/env/ti/k3_rproc.env +5 -1
@@ -13,11 +13,15 @@ rproc_load_and_boot_one= boot_rprocs_mmc= env set rproc_id; env set rproc_fw; + env set secure_suffix; + if test ${secure_rprocs} -eq 1; then + env set secure_suffix -sec; + fi; for i in ${rproc_fw_binaries} ; do if test -z "${rproc_id}" ; then env set rproc_id $i; else - env set rproc_fw $i; + env set rproc_fw $i${secure_suffix}; run rproc_load_and_boot_one; env set rproc_id; env set rproc_fw;
include/env/ti/ti_common.env +1 -0
@@ -12,6 +12,7 @@ bootm_size=0x10000000 boot_fdt=try boot_fit=0 +secure_rprocs=0 addr_fit=0x90000000 name_fit=fitImage update_to_fit=setenv loadaddr ${addr_fit}; setenv bootfile ${name_fit}
Signature · 1 line
2.34.1
PATCH 4/4 mach-k3: common.c: add a flag for booting authenticated rproc binaries
In reply to Udit KumarFrom: Manorit Chawdhry <[email protected]>
The flag will be used for booting authenticated remote procs from hs-se devices which can optionally be used in hs-fs devices also.
--- arch/arm/mach-k3/common.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
arch/arm/mach-k3/common.c +3 -1
@@ -283,8 +283,10 @@ int misc_init_r(void) }/* Default FIT boot on HS-SE devices */ -if (get_device_type () ==K3_DEVICE_TYPE_HS_SE ) +if (get_device_type () ==K3_DEVICE_TYPE_HS_SE ) {env_set ("boot_fit" ,"1" ); +env_set ("secure_rprocs" ,"1" ); + }return 0 ; }
Signature · 1 line
2.34.1
Quoted 10 lines · Udit Kumar
Some use case needs rproc firmware to be loaded at u-boot stage, using following commands at u-boot shell, firmware could be loaded
=> setenv dorprocboot 1
=> runboot_rprocsFor Secure devices, secure version of rproc firmware should be loaded, which is appended by sec keyword[0].
but currently non-secure firmware is loaded even for secure devices. So adding support for loading secure firmware on Secured devices.
Are you Cc'ing random people with this?
Please don't do it.
Signature · 2 lines
With Best Regards, Andy Shevchenko
Quoted 7 lines · Andy Shevchenko
Quoted 6 lines · Udit Kumar
Some use case needs rproc firmware to be loaded at u-boot stage, using following commands at u-boot shell, firmware could be loaded
=> setenv dorprocboot 1
=> runboot_rprocs
Quoted 6 lines
Quoted 4 lines
For Secure devices, secure version of rproc firmware should be loaded, which is appended by sec keyword[0].
but currently non-secure firmware is loaded even for secure devices. So adding support for loading secure firmware on Secured devices.Are you Cc'ing random people with this?
Please don't do it.
I used names names popped up while running get_maintainer.pl script of u-boot
your email id was there for patch-3 of this series
./scripts/get_maintainer.pl 0003-include-env-ti-Add-support-for-secure-firmwares.patch
Joe Hershberger <[email protected]> (maintainer:ENVIRONMENT)
Tom Rini <[email protected]> (maintainer:THE REST)
Udit Kumar <[email protected]> (commit_signer:1/2=50%,authored:1/2=50%,commit_signer:1/7=14%,authored:1/7=14%) Simon Glass <[email protected]> (commit_signer:1/2=50%,authored:1/2=50%,authored:1/7=14%) Andy Shevchenko <[email protected]> (commit_signer:1/2=50%)
Bin Meng <[email protected]> (commit_signer:1/2=50%)
Manorit Chawdhry <[email protected]> (commit_signer:1/2=50%,commit_signer:5/7=71%,authored:4/7=57%) Mattijs Korpershoek <[email protected]> (commit_signer:4/7=57%)
Nishanth Menon <[email protected]> (commit_signer:1/7=14%,authored:1/7=14%)
Siddharth Vadapalli <[email protected]> (commit_signer:1/7=14%)
[email protected] (open list)
Quoted 2 lines · Udit
Quoted 1 line · Andy Shevchenko
On Tue, May 21, 2024 at 04:26:44PM +0530, Udit Kumar wrote:
...
Quoted 7 lines
Quoted 2 lines
Are you Cc'ing random people with this?
Please don't do it.I used names names popped up while running get_maintainer.pl script of u-boot
your email id was there for patch-3 of this series
Nice, the tool is broken. Please, work with the respective people to fix a tool or to tune it to avoid such mistakes in the future.
(Hint: I would first disable Git fallback completely)
Quoted 15 lines
./scripts/get_maintainer.pl
0003-include-env-ti-Add-support-for-secure-firmwares.patch
Joe Hershberger <[email protected]> (maintainer:ENVIRONMENT)
Tom Rini <[email protected]> (maintainer:THE REST)
Udit Kumar <[email protected]> (commit_signer:1/2=50%,authored:1/2=50%,commit_signer:1/7=14%,authored:1/7=14%) Simon Glass <[email protected]>
(commit_signer:1/2=50%,authored:1/2=50%,authored:1/7=14%)
Andy Shevchenko <[email protected]> (commit_signer:1/2=50%)
Bin Meng <[email protected]> (commit_signer:1/2=50%)
Manorit Chawdhry <[email protected]> (commit_signer:1/2=50%,commit_signer:5/7=71%,authored:4/7=57%)
Mattijs Korpershoek <[email protected]> (commit_signer:4/7=57%)
Nishanth Menon <[email protected]> (commit_signer:1/7=14%,authored:1/7=14%)
Siddharth Vadapalli <[email protected]> (commit_signer:1/7=14%)
[email protected] (open list)
Signature · 2 lines
With Best Regards, Andy Shevchenko
Quoted 12 lines · Andy Shevchenko
Quoted 2 lines · Udit
Quoted 1 line · Andy Shevchenko
On Tue, May 21, 2024 at 04:26:44PM +0530, Udit Kumar wrote:
...
Quoted 6 lines
Quoted 2 lines
Are you Cc'ing random people with this?
Please don't do it.I used names names popped up while running get_maintainer.pl script of u-boot
Quoted 6 lines
Quoted 1 line
your email id was there for patch-3 of this series
Nice, the tool is broken. Please, work with the respective people to fix a tool or to tune it to avoid such mistakes in the future.
(Hint: I would first disable Git fallback completely)
So you were cc'd thanks to:
commit 5e541a05f70296dbad07fc1f4e8678ad207bb476
Author: Simon Glass <[email protected]> Date: Sun Jul 30 21:01:45 2023 -0600
env: Use include/env for text-environment includes
The 'environment' word is too long. We mostly use 'env' in U-Boot, so use that as the name of the include directory too.
And, I'm sorry because there are other contributors who get upset when git fallback doesn't find them (because it also ages out after a year). In this case there's not even a "tweak the threshold" option since there's only a single commit to the file so you're in 100% of them.
Signature · 1 line
Tom
Quoted 4 lines · Tom Rini
Quoted 3 lines · Andy Shevchenko
Quoted 2 lines · Udit
Quoted 1 line · Andy Shevchenko
On Tue, May 21, 2024 at 04:26:44PM +0530, Udit Kumar wrote:
...
Quoted 18 lines
Quoted 6 lines
Quoted 6 lines
Quoted 2 lines
Are you Cc'ing random people with this?
Please don't do it.I used names names popped up while running get_maintainer.pl script of u-boot
Quoted 6 lines
Quoted 1 line
your email id was there for patch-3 of this series
Nice, the tool is broken. Please, work with the respective people to fix a tool or to tune it to avoid such mistakes in the future.
(Hint: I would first disable Git fallback completely)
So you were cc'd thanks to:
commit5e541a05f70296dbad07fc1f4e8678ad207bb476Author: Simon Glass <[email protected]> Date: Sun Jul 30 21:01:45 2023 -0600
Quoted 7 lines
env: Use
include/envfor text-environment includesThe 'environment' word is too long. We mostly use 'env' in U-Boot, so use that as the name of the include directory too.
Signed-off-by Simon Glass <[email protected]>
Yeah, and it even explicitly stated what I reviewed from that code...
Quoted 6 lines
Reviewed-by Bin Meng <[email protected]>And, I'm sorry because there are other contributors who get upset when git fallback doesn't find them (because it also ages out after a year). In this case there's not even a "tweak the threshold" option since there's only a single commit to the file so you're in 100% of them.
Just an example of false positive by get_maintainer.pl :-( And a confirmation of what I said — tool is broken.
Signature · 2 lines
With Best Regards, Andy Shevchenko
Quoted 38 lines · Andy Shevchenko
Quoted 4 lines · Tom Rini
Quoted 3 lines · Andy Shevchenko
Quoted 2 lines · Udit
Quoted 1 line · Andy Shevchenko
On Tue, May 21, 2024 at 04:26:44PM +0530, Udit Kumar wrote:
...
Quoted 18 lines
Quoted 6 lines
Quoted 6 lines
Quoted 2 lines
Are you Cc'ing random people with this?
Please don't do it.I used names names popped up while running get_maintainer.pl script of u-boot
Quoted 6 lines
Quoted 1 line
your email id was there for patch-3 of this series
Nice, the tool is broken. Please, work with the respective people to fix a tool or to tune it to avoid such mistakes in the future.
(Hint: I would first disable Git fallback completely)
So you were cc'd thanks to:
commit5e541a05f70296dbad07fc1f4e8678ad207bb476Author: Simon Glass <[email protected]> Date: Sun Jul 30 21:01:45 2023 -0600Quoted 7 lines
env: Use
include/envfor text-environment includesThe 'environment' word is too long. We mostly use 'env' in U-Boot, so use that as the name of the include directory too.
Signed-off-by Simon Glass <[email protected]>Yeah, and it even explicitly stated what I reviewed from that code...
Quoted 2 lines
Reviewed-by Bin Meng <[email protected]>
Quoted 7 lines
Quoted 4 lines
And, I'm sorry because there are other contributors who get upset when git fallback doesn't find them (because it also ages out after a year). In this case there's not even a "tweak the threshold" option since there's only a single commit to the file so you're in 100% of them.
Just an example of false positive by get_maintainer.pl :-( And a confirmation of what I said — tool is broken.
It's an imperfect tool, yes. A quick check shows that if you never want to be cc'd from a git tag, you can add yourself to .get_maintainer.ignore and you will still be matched for things you have an explicit MAINTAINER entry for.
Signature · 1 line
Tom
Quoted 6 lines · Tom Rini
Quoted 5 lines · Andy Shevchenko
Quoted 4 lines · Tom Rini
Quoted 3 lines · Andy Shevchenko
Quoted 2 lines · Udit
Quoted 1 line · Andy Shevchenko
On Tue, May 21, 2024 at 04:26:44PM +0530, Udit Kumar wrote:
...
Quoted 35 lines
Quoted 35 lines
Quoted 18 lines
Quoted 6 lines
Quoted 6 lines
Quoted 2 lines
Are you Cc'ing random people with this?
Please don't do it.I used names names popped up while running get_maintainer.pl script of u-boot
Quoted 6 lines
Quoted 1 line
your email id was there for patch-3 of this series
Nice, the tool is broken. Please, work with the respective people to fix a tool or to tune it to avoid such mistakes in the future.
(Hint: I would first disable Git fallback completely)
So you were cc'd thanks to:
commit5e541a05f70296dbad07fc1f4e8678ad207bb476Author: Simon Glass <[email protected]> Date: Sun Jul 30 21:01:45 2023 -0600Quoted 7 lines
env: Use
include/envfor text-environment includesThe 'environment' word is too long. We mostly use 'env' in U-Boot, so use that as the name of the include directory too.
Signed-off-by Simon Glass <[email protected]>Yeah, and it even explicitly stated what I reviewed from that code...
Quoted 6 lines
Reviewed-by Bin Meng <[email protected]>And, I'm sorry because there are other contributors who get upset when git fallback doesn't find them (because it also ages out after a year). In this case there's not even a "tweak the threshold" option since there's only a single commit to the file so you're in 100% of them.
Quoted 7 lines
Quoted 2 lines
Just an example of false positive by get_maintainer.pl :-( And a confirmation of what I said — tool is broken.
It's an imperfect tool, yes. A quick check shows that if you never want to be cc'd from a git tag, you can add yourself to .get_maintainer.ignore and you will still be matched for things you have an explicit MAINTAINER entry for.
But this will kill me being a maintainer of U-Boot parts (regarding to a certain platform) which is not what I want.
Signature · 2 lines
With Best Regards, Andy Shevchenko
Quoted 48 lines · Andy Shevchenko
Quoted 6 lines · Tom Rini
Quoted 5 lines · Andy Shevchenko
Quoted 4 lines · Tom Rini
Quoted 3 lines · Andy Shevchenko
Quoted 2 lines · Udit
Quoted 1 line · Andy Shevchenko
On Tue, May 21, 2024 at 04:26:44PM +0530, Udit Kumar wrote:
...
Quoted 38 lines
Quoted 37 lines
Quoted 18 lines
Quoted 6 lines
Quoted 6 lines
Quoted 2 lines
Are you Cc'ing random people with this?
Please don't do it.I used names names popped up while running get_maintainer.pl script of u-boot
Quoted 6 lines
Quoted 1 line
your email id was there for patch-3 of this series
Nice, the tool is broken. Please, work with the respective people to fix a tool or to tune it to avoid such mistakes in the future.
(Hint: I would first disable Git fallback completely)
So you were cc'd thanks to:
commit5e541a05f70296dbad07fc1f4e8678ad207bb476Author: Simon Glass <[email protected]> Date: Sun Jul 30 21:01:45 2023 -0600Quoted 7 lines
env: Use
include/envfor text-environment includesThe 'environment' word is too long. We mostly use 'env' in U-Boot, so use that as the name of the include directory too.
Signed-off-by Simon Glass <[email protected]>Yeah, and it even explicitly stated what I reviewed from that code...
Quoted 6 lines
Reviewed-by Bin Meng <[email protected]>And, I'm sorry because there are other contributors who get upset when git fallback doesn't find them (because it also ages out after a year). In this case there's not even a "tweak the threshold" option since there's only a single commit to the file so you're in 100% of them.
Just an example of false positive by get_maintainer.pl :-( And a confirmation of what I said — tool is broken.
Quoted 7 lines
Quoted 4 lines
It's an imperfect tool, yes. A quick check shows that if you never want to be cc'd from a git tag, you can add yourself to .get_maintainer.ignore and you will still be matched for things you have an explicit MAINTAINER entry for.
But this will kill me being a maintainer of U-Boot parts (regarding to a certain platform) which is not what I want.
With a quick local test, no, it still reported you for edison stuff since that's not where the ignore list comes in.
Signature · 1 line
Tom
Quoted 8 lines · Tom Rini
Quoted 7 lines · Andy Shevchenko
Quoted 6 lines · Tom Rini
Quoted 5 lines · Andy Shevchenko
Quoted 4 lines · Tom Rini
Quoted 3 lines · Andy Shevchenko
Quoted 2 lines · Udit
Quoted 1 line · Andy Shevchenko
On Tue, May 21, 2024 at 04:26:44PM +0530, Udit Kumar wrote:
...
Quoted 43 lines
Quoted 43 lines
Quoted 42 lines
Quoted 30 lines
Quoted 18 lines
Quoted 6 lines
Quoted 6 lines
Quoted 2 lines
Are you Cc'ing random people with this?
Please don't do it.I used names names popped up while running get_maintainer.pl script of u-boot
Quoted 6 lines
Quoted 1 line
your email id was there for patch-3 of this series
Nice, the tool is broken. Please, work with the respective people to fix a tool or to tune it to avoid such mistakes in the future.
(Hint: I would first disable Git fallback completely)
So you were cc'd thanks to:
commit5e541a05f70296dbad07fc1f4e8678ad207bb476Author: Simon Glass <[email protected]> Date: Sun Jul 30 21:01:45 2023 -0600Quoted 7 lines
env: Use
include/envfor text-environment includesThe 'environment' word is too long. We mostly use 'env' in U-Boot, so use that as the name of the include directory too.
Signed-off-by Simon Glass <[email protected]>Yeah, and it even explicitly stated what I reviewed from that code...
Quoted 2 lines
Reviewed-by Bin Meng <[email protected]>Quoted 7 lines
Quoted 4 lines
And, I'm sorry because there are other contributors who get upset when git fallback doesn't find them (because it also ages out after a year). In this case there's not even a "tweak the threshold" option since there's only a single commit to the file so you're in 100% of them.
Just an example of false positive by get_maintainer.pl :-( And a confirmation of what I said — tool is broken.
It's an imperfect tool, yes. A quick check shows that if you never want to be cc'd from a git tag, you can add yourself to .get_maintainer.ignore and you will still be matched for things you have an explicit MAINTAINER entry for.
Quoted 5 lines
Quoted 2 lines
But this will kill me being a maintainer of U-Boot parts (regarding to a certain platform) which is not what I want.
With a quick local test, no, it still reported you for edison stuff since that's not where the ignore list comes in.
I see. Still looking at the rate of false positives so far from U-Boot project I don't see that a big hammer, like the proposed one, should be used. Better to teach people on how to use/tune the tool, it will be helpful in a long-term.
Signature · 2 lines
With Best Regards, Andy Shevchenko
Quoted 58 lines · Andy Shevchenko
Quoted 8 lines · Tom Rini
Quoted 7 lines · Andy Shevchenko
Quoted 6 lines · Tom Rini
Quoted 5 lines · Andy Shevchenko
Quoted 4 lines · Tom Rini
Quoted 3 lines · Andy Shevchenko
Quoted 2 lines · Udit
Quoted 1 line · Andy Shevchenko
On Tue, May 21, 2024 at 04:26:44PM +0530, Udit Kumar wrote:
...
Quoted 46 lines
Quoted 45 lines
Quoted 35 lines
Quoted 35 lines
Quoted 18 lines
Quoted 6 lines
Quoted 6 lines
Quoted 2 lines
Are you Cc'ing random people with this?
Please don't do it.I used names names popped up while running get_maintainer.pl script of u-boot
Quoted 6 lines
Quoted 1 line
your email id was there for patch-3 of this series
Nice, the tool is broken. Please, work with the respective people to fix a tool or to tune it to avoid such mistakes in the future.
(Hint: I would first disable Git fallback completely)
So you were cc'd thanks to:
commit5e541a05f70296dbad07fc1f4e8678ad207bb476Author: Simon Glass <[email protected]> Date: Sun Jul 30 21:01:45 2023 -0600Quoted 7 lines
env: Use
include/envfor text-environment includesThe 'environment' word is too long. We mostly use 'env' in U-Boot, so use that as the name of the include directory too.
Signed-off-by Simon Glass <[email protected]>Yeah, and it even explicitly stated what I reviewed from that code...
Quoted 6 lines
Reviewed-by Bin Meng <[email protected]>And, I'm sorry because there are other contributors who get upset when git fallback doesn't find them (because it also ages out after a year). In this case there's not even a "tweak the threshold" option since there's only a single commit to the file so you're in 100% of them.
Quoted 7 lines
Quoted 2 lines
Just an example of false positive by get_maintainer.pl :-( And a confirmation of what I said — tool is broken.
It's an imperfect tool, yes. A quick check shows that if you never want to be cc'd from a git tag, you can add yourself to .get_maintainer.ignore and you will still be matched for things you have an explicit MAINTAINER entry for.
But this will kill me being a maintainer of U-Boot parts (regarding to a certain platform) which is not what I want.
Quoted 6 lines
Quoted 2 lines
With a quick local test, no, it still reported you for edison stuff since that's not where the ignore list comes in.
I see. Still looking at the rate of false positives so far from U-Boot project I don't see that a big hammer, like the proposed one, should be used. Better to teach people on how to use/tune the tool, it will be helpful in a long-term.
Long term, it would be best if nearly everything had a real MAINTAINERS entry. Short term, I don't know how to reconcile "I don't want to be found via git history" with "Why wasn't I cc'd on a patch? Oh, because I touched it more than a year ago? I don't like that!" in a way other than:
- Encouraging people to add themselves to / expand existing MAINTAINERS entries.
- Add themselves to the ignore list if they don't want to be found for other contributions they made.
Signature · 1 line
Tom
Quoted 6 lines · Udit Kumar
Some use case needs rproc firmware to be loaded at u-boot stage, using following commands at u-boot shell, firmware could be loaded
=> setenv dorprocboot 1
=> runboot_rprocs
Quoted 6 lines
For Secure devices, secure version of rproc firmware should be loaded, which is appended by sec keyword[0].
but currently non-secure firmware is loaded even for secure devices. So adding support for loading secure firmware on Secured devices.[...]
Applied to u-boot/next, thanks!
Signature · 1 line
Tom