ARM: imx: verdin-imx8mm: Set CAN oscillator frequency based on model
PATCH v2 1/1 ARM: imx: verdin-imx8mm: Set CAN oscillator frequency based on model
The older i.MX8M Mini Verdin SoMs may came with 20 MHz SPI CAN controller oscillator, the newer SoMs always use 40 MHz oscillator. Handle both by overriding the oscillator frequency just before booting the kernel.
These are the known variants with 20 MHz oscillator:
- 0055, V1.1A, V1.1B, V1.1C and V1.1D, use a 20MHz oscillator
- 0059, V1.1A and V1.1B, use a 20MHz oscillator
---
Cc: "NXP i.MX U-Boot Team" <[email protected]>
Cc: Fabio Estevam <[email protected]>
Cc: Francesco Dolcini <[email protected]>
Cc: Marcel Ziswiler <[email protected]>
Cc: Martyn Welch <[email protected]>
Cc: Stefano Babic <[email protected]>
Cc: [email protected]
---
V2: - Update the comment in conditional statement
- Update ver_assembly check for 0055 rev.A/B/C/D
--- board/toradex/verdin-imx8mm/verdin-imx8mm.c | 30 +++++++++++++++++++++ 1 file changed, 30 insertions(+)
board/toradex/verdin-imx8mm/verdin-imx8mm.c +30 -0
@@ -125,6 +125,36 @@ int board_phys_sdram_size(phys_size_t *size)#if defined(CONFIG_OF_LIBFDT ) && defined(CONFIG_OF_BOARD_SETUP )int ft_board_setup (void *blob,struct bd_info *bd) { +const char *canoscpath ="/oscillator" ; +int freq =40000000 ;/* 40 MHz is used on most variants */ +int canoscoff, ret; + + canoscoff =fdt_path_offset (blob, canoscpath); +if (canoscoff <0 )/* No CAN oscillator found. */ + goto exit; + +/* +* The actual "prodid" (PID4 in Toradex naming) that have the CAN +* functionality are 0055 and 0059. Special case 20 MHz variant +* here: +* - 0055, V1.1A, V1.1B, V1.1C and V1.1D, use a 20MHz oscillator +* - 0059, V1.1A and V1.1B, use a 20MHz oscillator +*/ +if ((tdx_hw_tag.ver_major ==1 && tdx_hw_tag.ver_minor ==1 ) && + ((tdx_hw_tag.prodid ==VERDIN_IMX8MMQ_IT && + tdx_hw_tag.ver_assembly <=1 ) ||/* 0059 rev. A or B */ + (tdx_hw_tag.prodid ==VERDIN_IMX8MMQ_WIFI_BT_IT && + tdx_hw_tag.ver_assembly <=3 ))) {/* 0055 rev. A/B/C/D */ + freq =20000000 ; + } + + ret =fdt_setprop_u32 (blob, canoscoff,"clock-frequency" , freq); +if (ret <0 ) { +printf ("Failed to set CAN oscillator clock-frequency, ret=%d\n" , + ret); + } + +exit:return ft_common_board_setup (blob, bd); }#endif
Signature · 1 line
2.43.0
Quoted 37 lines · Marek Vasut
The older i.MX8M Mini Verdin SoMs may came with 20 MHz SPI CAN controller oscillator, the newer SoMs always use 40 MHz oscillator. Handle both by overriding the oscillator frequency just before booting the kernel.
These are the known variants with 20 MHz oscillator:
- 0055, V1.1A, V1.1B, V1.1C and V1.1D, use a 20MHz oscillator
- 0059, V1.1A and V1.1B, use a 20MHz oscillatorSigned-off-by Marek Vasut <[email protected]>---
Cc: "NXP i.MX U-Boot Team" <[email protected]>
Cc: Fabio Estevam <[email protected]>
Cc: Francesco Dolcini <[email protected]>
Cc: Marcel Ziswiler <[email protected]>
Cc: Martyn Welch <[email protected]>
Cc: Stefano Babic <[email protected]>
Cc: [email protected]
---
V2: - Update the comment in conditional statement
- Updatever_assemblycheck for 0055 rev.A/B/C/D--- board/toradex/verdin-imx8mm/verdin-imx8mm.c | 30 +++++++++++++++++++++ 1 file changed, 30 insertions(+)board/toradex/verdin-imx8mm/verdin-imx8mm.c +5
-0@@ -125,6 +125,36 @@ int board_phys_sdram_size(phys_size_t *size)#if defined(CONFIG_OF_LIBFDT ) && defined(CONFIG_OF_BOARD_SETUP )int ft_board_setup (void *blob,struct bd_info *bd) { +const char *canoscpath ="/oscillator" ; +int freq =40000000 ;/* 40 MHz is used on most variants */ +int canoscoff, ret; + + canoscoff =fdt_path_offset (blob, canoscpath);
board/toradex/verdin-imx8mm/verdin-imx8mm.c int board_phys_sdram_size(phys_size_t *size) · line 142
Quoted 10 lines
board/toradex/verdin-imx8mm/verdin-imx8mm.c +10
-0+if (canoscoff <0 )/* No CAN oscillator found. */ + goto exit; + +/* +* The actual "prodid" (PID4 in Toradex naming) that have the CAN +* functionality are 0055 and 0059. Special case 20 MHz variant +* here: +* - 0055, V1.1A, V1.1B, V1.1C and V1.1D, use a 20MHz oscillator +* - 0059, V1.1A and V1.1B, use a 20MHz oscillator +*/
Any reason why you ignored my suggestion here? The variants you list here are the only one with a 20MHz oscillator, and this is correct.
What is not correct is that 0055/0059 are the only variant with CAN functionality. We have other "prodid" with CAN functionality.
With that said, the code is correct, thanks. I appreciate you taking care of this.
Francesco
On 5/22/24 8:39 AM, Francesco Dolcini wrote:
Hi,
Quoted 27 lines
Quoted 13 lines
board/toradex/verdin-imx8mm/verdin-imx8mm.c +5
-0@@ -125,6 +125,36 @@ int board_phys_sdram_size(phys_size_t *size)#if defined(CONFIG_OF_LIBFDT ) && defined(CONFIG_OF_BOARD_SETUP )int ft_board_setup (void *blob,struct bd_info *bd) { +const char *canoscpath ="/oscillator" ; +int freq =40000000 ;/* 40 MHz is used on most variants */ +int canoscoff, ret; + + canoscoff =fdt_path_offset (blob, canoscpath);board/toradex/verdin-imx8mm/verdin-imx8mm.c int board_phys_sdram_size(phys_size_t *size) · line 142
Quoted 10 lines
board/toradex/verdin-imx8mm/verdin-imx8mm.c +10
-0+if (canoscoff <0 )/* No CAN oscillator found. */ + goto exit; + +/* +* The actual "prodid" (PID4 in Toradex naming) that have the CAN +* functionality are 0055 and 0059. Special case 20 MHz variant +* here: +* - 0055, V1.1A, V1.1B, V1.1C and V1.1D, use a 20MHz oscillator +* - 0059, V1.1A and V1.1B, use a 20MHz oscillator +*/ Any reason why you ignored my suggestion here? The variants you list here are the only one with a 20MHz oscillator, and this is correct.
Quoted 5 lines
What is not correct is that 0055/0059 are the only variant with CAN functionality. We have other "prodid" with CAN functionality.
With that said, the code is correct, thanks. I appreciate you taking care of this.
So ... what should I change for V3 ?
Maybe just create me a diff I can squash into the patch before resend ? (I think I am a bit confused, I thought I addressed all the V1 feedback)
Francesco Dolcini
Reviewed-byQuoted 31 lines · Marek Vasut
Quoted 30 lines · Francesco Dolcini
Quoted 13 lines
board/toradex/verdin-imx8mm/verdin-imx8mm.c +5
-0@@ -125,6 +125,36 @@ int board_phys_sdram_size(phys_size_t *size)#if defined(CONFIG_OF_LIBFDT ) && defined(CONFIG_OF_BOARD_SETUP )int ft_board_setup (void *blob,struct bd_info *bd) { +const char *canoscpath ="/oscillator" ; +int freq =40000000 ;/* 40 MHz is used on most variants */ +int canoscoff, ret; + + canoscoff =fdt_path_offset (blob, canoscpath);board/toradex/verdin-imx8mm/verdin-imx8mm.c int board_phys_sdram_size(phys_size_t *size) · line 142
Quoted 10 lines
board/toradex/verdin-imx8mm/verdin-imx8mm.c +10
-0+if (canoscoff <0 )/* No CAN oscillator found. */ + goto exit; + +/* +* The actual "prodid" (PID4 in Toradex naming) that have the CAN +* functionality are 0055 and 0059. Special case 20 MHz variant +* here: +* - 0055, V1.1A, V1.1B, V1.1C and V1.1D, use a 20MHz oscillator +* - 0059, V1.1A and V1.1B, use a 20MHz oscillator +*/ Any reason why you ignored my suggestion here? The variants you list here are the only one with a 20MHz oscillator, and this is correct.
What is not correct is that 0055/0059 are the only variant with CAN functionality. We have other "prodid" with CAN functionality.
Quoted 7 lines
Quoted 2 lines
With that said, the code is correct, thanks. I appreciate you taking care of this.
So ... what should I change for V3 ?
Maybe just create me a diff I can squash into the patch before resend ? (I think I am a bit confused, I thought I addressed all the V1 feedback)
Sorry for the confusion, here the diff.
With that please add
board/toradex/verdin-imx8mm/verdin-imx8mm.c +4 -5
@@ -134,11 +134,10 @@ int ft_board_setup(void *blob, struct bd_info *bd) goto exit;/* -* The actual "prodid" (PID4 in Toradex naming) that have the CAN -* functionality are 0055 and 0059. Special case 20 MHz variant -* here: -* - 0055, V1.1A, V1.1B, V1.1C and V1.1D, use a 20MHz oscillator -* - 0059, V1.1A and V1.1B, use a 20MHz oscillator +* The followings "prodid" (PID4 in Toradex naming) use +* a 20MHz CAN oscillator: +* - 0055, V1.1A, V1.1B, V1.1C and V1.1D +* - 0059, V1.1A and V1.1B */ if ((tdx_hw_tag.ver_major == 1 && tdx_hw_tag.ver_minor == 1) && ((tdx_hw_tag.prodid == VERDIN_IMX8MMQ_IT &&
Quoted 35 lines · Francesco Dolcini
Quoted 34 lines · Marek Vasut
Quoted 32 lines · Francesco Dolcini
Quoted 13 lines
board/toradex/verdin-imx8mm/verdin-imx8mm.c +5
-0@@ -125,6 +125,36 @@ int board_phys_sdram_size(phys_size_t *size)#if defined(CONFIG_OF_LIBFDT ) && defined(CONFIG_OF_BOARD_SETUP )int ft_board_setup (void *blob,struct bd_info *bd) { +const char *canoscpath ="/oscillator" ; +int freq =40000000 ;/* 40 MHz is used on most variants */ +int canoscoff, ret; + + canoscoff =fdt_path_offset (blob, canoscpath);board/toradex/verdin-imx8mm/verdin-imx8mm.c int board_phys_sdram_size(phys_size_t *size) · line 142
Quoted 10 lines
board/toradex/verdin-imx8mm/verdin-imx8mm.c +10
-0+if (canoscoff <0 )/* No CAN oscillator found. */ + goto exit; + +/* +* The actual "prodid" (PID4 in Toradex naming) that have the CAN +* functionality are 0055 and 0059. Special case 20 MHz variant +* here: +* - 0055, V1.1A, V1.1B, V1.1C and V1.1D, use a 20MHz oscillator +* - 0059, V1.1A and V1.1B, use a 20MHz oscillator +*/ Any reason why you ignored my suggestion here? The variants you list here are the only one with a 20MHz oscillator, and this is correct.
What is not correct is that 0055/0059 are the only variant with CAN functionality. We have other "prodid" with CAN functionality.
With that said, the code is correct, thanks. I appreciate you taking care of this.
Quoted 7 lines
Quoted 4 lines
So ... what should I change for V3 ?
Maybe just create me a diff I can squash into the patch before resend ? (I think I am a bit confused, I thought I addressed all the V1 feedback)
Sorry for the confusion, here the diff.
With that please add
Thank you. I missed this mail and now I found it. Fixed in V3.