Skip to contentSkip to conversation

nvme-pci: add quirks for Lexar NM790

PATCH In review Jason Nader 2 participants 4 messages May 22, 2024 – May 23, 2024 NVMe

lore
Share & tools
lore
#0 lore raw

cover nvme-pci: add quirks for Lexar NM790

Hi,

This adds Lexar NM790 to the quirks list.
Other drives in the model line-up already exist in the list.

Kernel logs before:

nvme nvme1: pci function 0000:03:00.0
nvme nvme1: missing or invalid SUBNQN field. nvme nvme1: allocated 32 MiB host memory buffer. nvme nvme1: 8/0/0 default/read/poll queues block nvme1n1: No UUID available providing old NGUID

Kernel logs after:

nvme nvme1: pci function 0000:03:00.0 nvme nvme1: allocated 32 MiB host memory buffer. nvme nvme1: 8/0/0 default/read/poll queues nvme nvme1: Ignoring bogus Namespace Identifiers

Other info:

Quoted 1 line

sudo nvme ns-descs /dev/nvme1n1

NVME Namespace Identification Descriptors NS 1:
eui64 : 6479a74b40200c00
nguid : 00000000000000000000000000000000

Jason Nader (1):
nvme-pci: add quirks for Lexar NM790

 drivers/nvme/host/pci.c | 3 +++
 1 file changed, 3 insertions(+)
Signature · 1 line
2.45.1
#1 lore raw

PATCH 1/1 nvme-pci: add quirks for Lexar NM790

NVME device 'Lexar SSD NM790 2TB', which shows in lspci -nn as
Shenzhen Longsys Electronics Co., Ltd. Lexar NM790 NVME SSD (DRAM-less) [1d97:1602] (rev 01), shows the following warnings in dmesg:

nvme nvme1: missing or invalid SUBNQN field. block nvme1n1: No UUID available providing old NGUID

To fix this, add IGNORE_DEV_SUBNQN and BOGUS_NID quirks for this device.

---
 drivers/nvme/host/pci.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/nvme/host/pci.c +3 -0
index 710043086dff..8ca831cb2f79 100644
@@ -3490,6 +3490,9 @@ static const struct pci_device_id nvme_id_table[] = {
 	{ PCI_DEVICE(0x1d97, 0x2269), /* Lexar NM760 */
 		.driver_data = NVME_QUIRK_BOGUS_NID |
 				NVME_QUIRK_IGNORE_DEV_SUBNQN, },
+	{ PCI_DEVICE(0x1d97, 0x1602), /* Lexar NM790 */
+		.driver_data = NVME_QUIRK_BOGUS_NID |
+				NVME_QUIRK_IGNORE_DEV_SUBNQN, },
 	{ PCI_DEVICE(0x10ec, 0x5763), /* TEAMGROUP T-FORCE CARDEA ZERO Z330 SSD */
 		.driver_data = NVME_QUIRK_BOGUS_NID, },
 	{ PCI_DEVICE(0x1e4b, 0x1602), /* HS-SSD-FUTURE 2048G  */
Signature · 1 line
2.45.1
maintainer
#2 lore raw
In reply to Jason Nader
Quoted 20 lines · Jason Nader

Hi,

This adds Lexar NM790 to the quirks list.
Other drives in the model line-up already exist in the list.

Kernel logs before:

nvme nvme1: pci function 0000:03:00.0
nvme nvme1: missing or invalid SUBNQN field. nvme nvme1: allocated 32 MiB host memory buffer. nvme nvme1: 8/0/0 default/read/poll queues block nvme1n1: No UUID available providing old NGUID

Kernel logs after:

nvme nvme1: pci function 0000:03:00.0 nvme nvme1: allocated 32 MiB host memory buffer. nvme nvme1: 8/0/0 default/read/poll queues nvme nvme1: Ignoring bogus Namespace Identifiers

Quoted 6 lines

Other info:

Quoted 1 line

sudo nvme ns-descs /dev/nvme1n1

NVME Namespace Identification Descriptors NS 1:
eui64 : 6479a74b40200c00
nguid : 00000000000000000000000000000000

This quirk is actually for the nvme subsystem. It has nothing to do with namespace descriptors.

nvme id-ctrl /dev/nvme1 | grep subnqn

I'm not even sure why we have this quirk; it just suppresses a harmless print message; everything works the same with or without the quirk.

#3 lore raw
Quoted 5 lines · Keith Busch

On Thu, May 23, 2024 at 12:56:13AM +0900, Jason Nader wrote:
namespace descriptors.

nvme id-ctrl /dev/nvme1 | grep subnqn

Output below:

```
subnqn    :
```