Skip to contentSkip to conversation

uapi: linux/kd.h: include missing header

PATCH In review Dmitry V. Levin 2 participants 2 messages May 23, 2024 ABI/API

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 uapi: linux/kd.h: include missing header

Given that linux/kd.h now uses macros defined in linux/ioctl.h, do not rely on that header being already included by linux/kd.h users and include linux/ioctl.h explicitly.

This bug was found by strace CI.

Fixes 8c467f330059 ("VT: Use macros to define ioctls")
---
 include/uapi/linux/kd.h | 1 +
 1 file changed, 1 insertion(+)
include/uapi/linux/kd.h +1 -0
index 8ddb2219a84b..8fcce939ba25 100644
@@ -3,6 +3,7 @@
 #define _UAPI_LINUX_KD_H
 #include <linux/types.h>
 #include <linux/compiler.h>
+#include <linux/ioctl.h>
 
 /* 0x4B is 'K', to avoid collision with termios and vt */
 #define KD_IOCTL_BASE	'K'
Signature · 1 line
ldv
Acked-by on v1 1/1
#1 lore raw
Quoted 8 lines · Dmitry V. Levin

Given that linux/kd.h now uses macros defined in linux/ioctl.h, do not rely on that header being already included by linux/kd.h users and include linux/ioctl.h explicitly.

This bug was found by strace CI.

Fixes 8c467f330059 ("VT: Use macros to define ioctls")
Quoted 19 lines
---
 include/uapi/linux/kd.h | 1 +
 1 file changed, 1 insertion(+)
include/uapi/linux/kd.h +1 -0
index 8ddb2219a84b..8fcce939ba25 100644
@@ -3,6 +3,7 @@
 #define _UAPI_LINUX_KD_H
 #include <linux/types.h>
 #include <linux/compiler.h>
+#include <linux/ioctl.h>
 
 /* 0x4B is 'K', to avoid collision with termios and vt */
 #define KD_IOCTL_BASE	'K'
Signature · 1 line
ldv
Signature · 1 line
Rgrds, legion