mm: Drop leftover comment references to pxx_huge()
Subsystems (5)
PATCH 1/1 mm: Drop leftover comment references to pxx_huge()
pxx_huge() has been removed in recent commit 9636f055dae1 ("mm/treewide:
remove pXd_huge()"), however there are still three comments referencing the API that got overlooked. Remove them.
Cc Jason Gunthorpe <[email protected]>
Reported-by Christophe Leroy <[email protected]>
Signed-off-by Peter Xu <[email protected]>
--- Documentation/mm/arch_pgtable_helpers.rst | 4 ---- arch/x86/mm/pat/set_memory.c | 4 ++-- 2 files changed, 2 insertions(+), 6 deletions(-)
Documentation/mm/arch_pgtable_helpers.rst +0 -4
@@ -90,8 +90,6 @@ PMD Page Table Helpers +---------------------------+--------------------------------------------------+ | pmd_leaf | Tests a leaf mapped PMD | +---------------------------+--------------------------------------------------+ -| pmd_huge | Tests a HugeTLB mapped PMD | -+---------------------------+--------------------------------------------------+ | pmd_trans_huge | Tests a Transparent Huge Page (THP) at PMD | +---------------------------+--------------------------------------------------+ | pmd_present | Tests whether pmd_page() points to valid memory |
@@ -169,8 +167,6 @@ PUD Page Table Helpers +---------------------------+--------------------------------------------------+ | pud_leaf | Tests a leaf mapped PUD | +---------------------------+--------------------------------------------------+ -| pud_huge | Tests a HugeTLB mapped PUD | -+---------------------------+--------------------------------------------------+ | pud_trans_huge | Tests a Transparent Huge Page (THP) at PUD | +---------------------------+--------------------------------------------------+ | pud_present | Tests a valid mapped PUD |
arch/x86/mm/pat/set_memory.c +2 -2
@@ -1120,8 +1120,8 @@ __split_large_page(struct cpa_data *cpa, pte_t *kpte, unsigned long address, lpinc =PMD_SIZE ;/* * Clear the PSE flags if the PRESENT flag is not set -* otherwise pmd_present/pmd_huge will return true -* even on a non present pmd. +* otherwise pmd_present() will return true even on a non +* present pmd. */ if (!(pgprot_val (ref_prot) & _PAGE_PRESENT))pgprot_val (ref_prot) &= ~_PAGE_PSE;
Signature · 1 line
2.45.0
Am 27.05.24 um 17:48 schrieb Peter Xu:
Quoted 8 lines
pxx_huge()has been removed in recent commit9636f055dae1("mm/treewide:
removepXd_huge()"), however there are still three comments referencing the API that got overlooked. Remove them.Cc Jason Gunthorpe <[email protected]>Reported-by Christophe Leroy <[email protected]>Signed-off-by Peter Xu <[email protected]>---
Reviewed-by David Hildenbrand <[email protected]>
Signature · 3 lines
Thanks, David / dhildenb