Skip to contentSkip to conversation

selftests/mqueue: fix 5 warnings about signed/unsigned mismatches

PATCH Applied John Hubbard 1 participant 1 message May 27, 2024 Kselftest

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 selftests/mqueue: fix 5 warnings about signed/unsigned mismatches

When building with clang, via:

make LLVM=1 -C tools/testing/selftest

...clang warns about several cases of using a signed integer for the priority argument to mq_receive(3), which expects an unsigned int.

Fix this by declaring the type as unsigned int in all cases.

---

Changes since the first version:

1) Rebased onto Linux 6.10-rc1

2) Reviewed-by's added.

thanks,
John Hubbard

 tools/testing/selftests/mqueue/mq_perf_tests.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
tools/testing/selftests/mqueue/mq_perf_tests.c +4 -2
index 5c16159d0bcd..fb898850867c 100644
@@ -323,7 +323,8 @@ void *fake_cont_thread(void *arg)
 void *cont_thread(void *arg)
 {
 	char buff[MSG_SIZE];
-	int i, priority;
+	int i;
+	unsigned int priority;
 
 	for (i = 0; i < num_cpus_to_pin; i++)
 		if (cpu_threads[i] == pthread_self())
@@ -425,7 +426,8 @@ struct test test2[] = {
 void *perf_test_thread(void *arg)
 {
 	char buff[MSG_SIZE];
-	int prio_out, prio_in;
+	int prio_out;
+	unsigned int prio_in;
 	int i;
 	clockid_t clock;
 	pthread_t *t;

base-commit: 2bfcfd584ff5ccc8bb7acde19b42570414bf880b

Signature · 1 line
2.45.1