PCI: dwc: ep: Enforce DWC specific 64-bit BAR limitiation
PATCH 1/1 PCI: dwc: ep: Enforce DWC specific 64-bit BAR limitiation
From the DWC EP databook 5.96a, section "3.5.7.1.4 General Rules for BAR Setup (Fixed Mask or Programmable Mask Schemes Only)":
"Any pair (for example BARs 0 and 1) can be configured as one 64-bit BAR, two 32-bit BARs, or one 32-bit BAR."
"BAR pairs cannot overlap to form a 64-bit BAR. For example, you cannot combine BARs 1 and 2 to form a 64-bit BAR."
While this limitation does exist in some other PCI endpoint controllers, e.g. cdns_pcie_ep_set_bar(), the limitation does not appear to be defined in the PCIe specification itself, thus add an explicit check for this in dw_pcie_ep_set_bar() (rather than pci_epc_set_bar()).
--- drivers/pci/controller/dwc/pcie-designware-ep.c | 7 +++++++ 1 file changed, 7 insertions(+)
drivers/pci/controller/dwc/pcie-designware-ep.c +7 -0
@@ -227,6 +227,13 @@ static int dw_pcie_ep_set_bar(struct pci_epc *epc, u8 func_no, u8 vfunc_no,int ret, type;u32 reg; +/* +* DWC does not allow BAR pairs to overlap, e.g. you cannot combine BARs +* 1 and 2 to form a 64-bit BAR. +*/ +if ((flags &PCI_BASE_ADDRESS_MEM_TYPE_64 ) && (bar &1 )) +return -EINVAL ; + reg =PCI_BASE_ADDRESS_0 + (4 * bar);if (!(flags &PCI_BASE_ADDRESS_SPACE ))
Signature · 1 line
2.45.1
Quoted 9 lines · Niklas Cassel
From the DWC EP databook 5.96a, section "3.5.7.1.4 General Rules for BAR Setup (Fixed Mask or Programmable Mask Schemes Only)":
"Any pair (for example BARs 0 and 1) can be configured as one 64-bit BAR, two 32-bit BARs, or one 32-bit BAR."
"BAR pairs cannot overlap to form a 64-bit BAR. For example, you cannot combine BARs 1 and 2 to form a 64-bit BAR."
Quoted 6 lines
While this limitation does exist in some other PCI endpoint controllers, e.g.
cdns_pcie_ep_set_bar(), the limitation does not appear to be defined in the PCIe specification itself, thus add an explicit check for this indw_pcie_ep_set_bar()(rather thanpci_epc_set_bar()).Signed-off-by Niklas Cassel <[email protected]>
- Mani
Quoted 25 lines
--- drivers/pci/controller/dwc/pcie-designware-ep.c | 7 +++++++ 1 file changed, 7 insertions(+)drivers/pci/controller/dwc/pcie-designware-ep.c +7
-0@@ -227,6 +227,13 @@ static int dw_pcie_ep_set_bar(struct pci_epc *epc, u8 func_no, u8 vfunc_no,int ret, type;u32 reg; +/* +* DWC does not allow BAR pairs to overlap, e.g. you cannot combine BARs +* 1 and 2 to form a 64-bit BAR. +*/ +if ((flags &PCI_BASE_ADDRESS_MEM_TYPE_64 ) && (bar &1 )) +return -EINVAL ; + reg =PCI_BASE_ADDRESS_0 + (4 * bar);if (!(flags &PCI_BASE_ADDRESS_SPACE ))Signature · 1 line
2.45.1
Signature · 1 line
மணிவண்ணன் சதாசிவம்
Krzysztof Wilczyński
AppliedQuoted 6 lines
From the DWC EP databook 5.96a, section "3.5.7.1.4 General Rules for BAR Setup (Fixed Mask or Programmable Mask Schemes Only)":
"Any pair (for example BARs 0 and 1) can be configured as one 64-bit BAR, two 32-bit BARs, or one 32-bit BAR."
Quoted 7 lines
"BAR pairs cannot overlap to form a 64-bit BAR. For example, you cannot combine BARs 1 and 2 to form a 64-bit BAR."
While this limitation does exist in some other PCI endpoint controllers, e.g.
cdns_pcie_ep_set_bar(), the limitation does not appear to be defined in the PCIe specification itself, thus add an explicit check for this indw_pcie_ep_set_bar()(rather thanpci_epc_set_bar()).
Applied to controller/dwc, thank you!
[1/1] PCI: dwc: ep: Enforce DWC specific 64-bit BAR limitation
https://git.kernel.org/pci/pci/c/a46de632131f Krzysztof