Skip to contentSkip to conversation

scftorture: make torture_type static

PATCH Applied Jeff Johnson 2 participants 2 messages May 29, 2024 Kernel janitors

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 scftorture: make torture_type static

Fix the 'make C=1' warning:
kernel/scftorture.c:71:6: warning: symbol 'torture_type' was not declared. Should it be static?

---
 kernel/scftorture.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/scftorture.c +1 -1
index 59032aaccd18..13ad348143ca 100644
@@ -67,7 +67,7 @@ torture_param(int, weight_many_wait, -1, "Testing weight for multi-CPU operation
 torture_param(int, weight_all, -1, "Testing weight for all-CPU no-wait operations.");
 torture_param(int, weight_all_wait, -1, "Testing weight for all-CPU operations.");
 
-char *torture_type = "";
+static char *torture_type = "";
 
 #ifdef MODULE
 # define SCFTORT_SHUTDOWN 0

---
base-commit: 4a4be1ad3a6efea16c56615f31117590fd881358
change-id: 20240529-static-scftorture-c86eccd9e30e

#1 lore raw
Quoted 4 lines · Jeff Johnson

Fix the 'make C=1' warning:
kernel/scftorture.c:71:6: warning: symbol 'torture_type' was not declared. Should it be static?

I queued both this and the scftorture.c fix, thank you!!!

Thanx, Paul

Quoted 22 lines
---
 kernel/scftorture.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/scftorture.c +1 -2
index 59032aaccd18..13ad348143ca 100644
@@ -67,7 +67,7 @@ torture_param(int, weight_many_wait, -1, "Testing weight for multi-CPU operation
 torture_param(int, weight_all, -1, "Testing weight for all-CPU no-wait operations.");
 torture_param(int, weight_all_wait, -1, "Testing weight for all-CPU operations.");
 
-char *torture_type = "";
+static char *torture_type = "";
 
 #ifdef MODULE
 # define SCFTORT_SHUTDOWN 0
 
---

base-commit: 4a4be1ad3a6efea16c56615f31117590fd881358
change-id: 20240529-static-scftorture-c86eccd9e30e