staging: r8712u: remove unused struct 'zero_bulkout_context'
PATCH 1/1 staging: r8712u: remove unused struct 'zero_bulkout_context'
From: "Dr. David Alan Gilbert" <[email protected]>
'zero_bulkout_context' is unused since the original commit 2865d42c78a9 ("staging: r8712u: Add the new driver to the mainline kernel").
Remove it.
--- drivers/staging/rtl8712/usb_ops_linux.c | 7 ------- 1 file changed, 7 deletions(-)
drivers/staging/rtl8712/usb_ops_linux.c +0 -7
@@ -26,13 +26,6 @@#define RTL871X_VENQT_READ 0xc0#define RTL871X_VENQT_WRITE 0x40 -struct zero_bulkout_context { -void *pbuf; -void *purb; -void *pirp; -void *padapter; -}; -uint r8712_usb_init_intf_priv (struct intf_priv *pintfpriv) { pintfpriv->piorw_urb =usb_alloc_urb (0 ,GFP_ATOMIC );
Signature · 1 line
2.45.1
On 5/29/24 02:08, [email protected] wrote:
please remove the following line:
Quoted 2 lines
From: "Dr. David Alan Gilbert" <[email protected]>
To me it is not important which commit introduced the struct. This is not a bug. So I would omit this lines and use instead just:
Remove struct zero_bulkout_context as it is unused.
Quoted 4 lines
'
zero_bulkout_context' is unused since the original commit2865d42c78a9("staging: r8712u: Add the new driver to the mainline kernel").
please remove the following line:
Quoted 14 lines
Remove it. >
Signed-off-by Dr. David Alan Gilbert <[email protected]>--- drivers/staging/rtl8712/usb_ops_linux.c | 7 ------- 1 file changed, 7 deletions(-)drivers/staging/rtl8712/usb_ops_linux.c +0
-0@@ -26,13 +26,6 @@#define RTL871X_VENQT_READ 0xc0#define RTL871X_VENQT_WRITE 0x40
drivers/staging/rtl8712/usb_ops_linux.c line 31
Quoted 10 lines
drivers/staging/rtl8712/usb_ops_linux.c +0
-7-struct zero_bulkout_context { -void *pbuf; -void *purb; -void *pirp; -void *padapter; -}; -uint r8712_usb_init_intf_priv (struct intf_priv *pintfpriv) { pintfpriv->piorw_urb =usb_alloc_urb (0 ,GFP_ATOMIC );
Hi David,
I would prefer the following changes:
Subject: please change from r8712u which is the compiled driver name to folder name of the driver: rtl8712
Please also consider the above hints.
If you send in a second version of this patch please use a change history. Description from Dan under:
https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/
Please contact me for any questions.
Thanks for your support.
Bye Philipp
Quoted 5 lines · * Philipp Hortmann ([email protected]) wrote:
On 5/29/24 02:08, [email protected] wrote:
please remove the following line:
Quoted 2 lines
From: "Dr. David Alan Gilbert" <[email protected]>
Quoted 9 lines
To me it is not important which commit introduced the struct. This is not a bug. So I would omit this lines and use instead just:
Remove structzero_bulkout_contextas it is unused.Quoted 4 lines
'
zero_bulkout_context' is unused since the original commit2865d42c78a9("staging: r8712u: Add the new driver to the mainline kernel").please remove the following line:
Quoted 1 line
Remove it. >
v2 sent just now with changes as requested. (Although I think you're the only person who has asked to remove that detail, most seem to like it as a hint as to whether there's some reason it's unused).
Dave
Quoted 44 lines
Quoted 12 lines
Signed-off-by Dr. David Alan Gilbert <[email protected]>--- drivers/staging/rtl8712/usb_ops_linux.c | 7 ------- 1 file changed, 7 deletions(-)drivers/staging/rtl8712/usb_ops_linux.c +0
-0@@ -26,13 +26,6 @@#define RTL871X_VENQT_READ 0xc0#define RTL871X_VENQT_WRITE 0x40drivers/staging/rtl8712/usb_ops_linux.c line 30
Quoted 10 lines
drivers/staging/rtl8712/usb_ops_linux.c +0
-7-struct zero_bulkout_context { -void *pbuf; -void *purb; -void *pirp; -void *padapter; -}; -uint r8712_usb_init_intf_priv (struct intf_priv *pintfpriv) { pintfpriv->piorw_urb =usb_alloc_urb (0 ,GFP_ATOMIC );Hi David,
I would prefer the following changes:
Subject: please change from r8712u which is the compiled driver name to folder name of the driver: rtl8712Please also consider the above hints.
If you send in a second version of this patch please use a change history. Description from Dan under:
https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/Please contact me for any questions.
Thanks for your support.
Bye Philipp
Signature · 4 lines
-----Open up your eyes, open up your mind, open up your code ------- / Dr. David Alan Gilbert | Running GNU/Linux | Happy \ \ dave @ treblig.org | | In Hex / \ _________________________|_____ http://www.treblig.org |_______/
Quoted 14 lines · Dr. David Alan Gilbert
Quoted 13 lines · * Philipp Hortmann ([email protected]) wrote:
On 5/29/24 02:08, [email protected] wrote:
please remove the following line:
Quoted 2 lines
From: "Dr. David Alan Gilbert" <[email protected]>
To me it is not important which commit introduced the struct. This is not a bug. So I would omit this lines and use instead just:
Remove structzero_bulkout_contextas it is unused.Quoted 4 lines
'
zero_bulkout_context' is unused since the original commit2865d42c78a9("staging: r8712u: Add the new driver to the mainline kernel").please remove the following line:
Quoted 8 lines
Quoted 1 line
Quoted 1 line
Remove it. >
v2 sent just now with changes as requested. (Although I think you're the only person who has asked to remove that detail, most seem to like it as a hint as to whether there's some reason it's unused).
Dave
May be you are right. But may be they are just happy that they do not have to respond to mails for the drivers named in this email:
https://lore.kernel.org/linux-staging/[email protected]/
Please consider that reviewers and testers are always wanted.
That only one person responses for simple changes is not so uncommon.
Thanks for your support.
Philipp
Quoted 45 lines
Quoted 45 lines
Quoted 13 lines
Signed-off-by Dr. David Alan Gilbert <[email protected]>--- drivers/staging/rtl8712/usb_ops_linux.c | 7 ------- 1 file changed, 7 deletions(-)drivers/staging/rtl8712/usb_ops_linux.c +0
-0@@ -26,13 +26,6 @@#define RTL871X_VENQT_READ 0xc0#define RTL871X_VENQT_WRITE 0x40drivers/staging/rtl8712/usb_ops_linux.c line 30
Quoted 10 lines
drivers/staging/rtl8712/usb_ops_linux.c +0
-7-struct zero_bulkout_context { -void *pbuf; -void *purb; -void *pirp; -void *padapter; -}; -uint r8712_usb_init_intf_priv (struct intf_priv *pintfpriv) { pintfpriv->piorw_urb =usb_alloc_urb (0 ,GFP_ATOMIC );Hi David,
I would prefer the following changes:
Subject: please change from r8712u which is the compiled driver name to folder name of the driver: rtl8712Please also consider the above hints.
If you send in a second version of this patch please use a change history. Description from Dan under:
https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/Please contact me for any questions.
Thanks for your support.
Bye Philipp