Skip to contentSkip to conversation

net: allow rps/rfs related configs to be switched

PATCH Superseded Jason Xing 2 participants 4 messages May 31, 2024 – Jun 5, 2024

Subsystems (2)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Jason Xing

author
#0 lore raw

PATCH 1/1 net: allow rps/rfs related configs to be switched

From: Jason Xing <[email protected]>

After John Sperbeck reported a compile error if the CONFIG_RFS_ACCEL is off, I found that I cannot easily enable/disable the config because of lack of the prompt when using 'make menuconfig'. Therefore, I decided to change rps/rfc related configs altogether.

---
 net/Kconfig | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
net/Kconfig +3 -3
index f0a8692496ff..cea38fc2e2ef 100644
@@ -290,12 +290,12 @@ config MAX_SKB_FRAGS
 	  If unsure, say 17.
 
 config RPS
-	bool
+	bool "Enable receive packet steering"
 	depends on SMP && SYSFS
 	default y
 
 config RFS_ACCEL
-	bool
+	bool "Enable hardware acceleration of RFS"
 	depends on RPS
 	select CPU_RMAP
 	default y
@@ -351,7 +351,7 @@ config BPF_STREAM_PARSER
 	  BPF_MAP_TYPE_SOCKMAP.
 
 config NET_FLOW_LIMIT
-	bool
+	bool "Enable net flow limit"
 	depends on RPS
 	default y
 	help
Signature · 1 line
2.37.3
reviewer
#1 lore raw
Quoted 8 lines · Jason Xing

From: Jason Xing <[email protected]>

After John Sperbeck reported a compile error if the CONFIG_RFS_ACCEL is off, I found that I cannot easily enable/disable the config because of lack of the prompt when using 'make menuconfig'. Therefore, I decided to change rps/rfc related configs altogether.

Hi Jason,

FWIIW, I think it would be appropriate to also add help text for each option. And I would drop "Enable", modeling Kdoc on, f.e. CONFIG_CGROUP_NET_CLASSID.

Likewise for CONFIG_BQL, although that isn't strictly related to this patch.

...

author
#2 lore raw

Hello Simon,

Quoted 9 lines · Simon Horman
Quoted 7 lines · Jason Xing

From: Jason Xing <[email protected]>

After John Sperbeck reported a compile error if the CONFIG_RFS_ACCEL is off, I found that I cannot easily enable/disable the config because of lack of the prompt when using 'make menuconfig'. Therefore, I decided to change rps/rfc related configs altogether.

Quoted 6 lines
Quoted 1 line

Hi Jason,

FWIIW, I think it would be appropriate to also add help text for each option. And I would drop "Enable", modeling Kdoc on, f.e. CONFIG_CGROUP_NET_CLASSID.

Thanks for your review.

I will adjust as you suggest in the next submission.

Quoted 3 lines

Likewise for CONFIG_BQL, although that isn't strictly related to this patch.

Yes, I can see. I think I could write another patch to do this since currently I would like to submit a rps/rfs related patch.

Thanks,
Jason

reviewer
#3 lore raw
Quoted 14 lines · Jason Xing

Hello Simon,

Quoted 11 lines · Simon Horman
Quoted 8 lines · Jason Xing

From: Jason Xing <[email protected]>

After John Sperbeck reported a compile error if the CONFIG_RFS_ACCEL is off, I found that I cannot easily enable/disable the config because of lack of the prompt when using 'make menuconfig'. Therefore, I decided to change rps/rfc related configs altogether.

Quoted 8 lines
Quoted 4 lines

Hi Jason,

FWIIW, I think it would be appropriate to also add help text for each option. And I would drop "Enable", modeling Kdoc on, f.e. CONFIG_CGROUP_NET_CLASSID.

Thanks for your review.

I will adjust as you suggest in the next submission.

Thanks.

Quoted 5 lines
Quoted 2 lines

Likewise for CONFIG_BQL, although that isn't strictly related to this patch.

Yes, I can see. I think I could write another patch to do this since currently I would like to submit a rps/rfs related patch.

Yes, of course.
It's a separate issue.