perf hisi-ptt: remove unused struct 'hisi_ptt_queue'
Subsystems (2)
PATCH 1/1 perf hisi-ptt: remove unused struct 'hisi_ptt_queue'
From: "Dr. David Alan Gilbert" <[email protected]>
'hisi_ptt_queue' has been unused since the original commit 5e91e57e6809 ("perf auxtrace arm64: Add support for parsing HiSilicon PCIe Trace packet").
Remove it.
--- tools/perf/util/hisi-ptt.c | 5 ----- 1 file changed, 5 deletions(-)
tools/perf/util/hisi-ptt.c +0 -5
@@ -35,11 +35,6 @@ struct hisi_ptt {u32 pmu_type; }; -struct hisi_ptt_queue { -struct hisi_ptt *ptt; -struct auxtrace_buffer *buffer; -}; -static enum hisi_ptt_pkt_type hisi_ptt_check_packet_type (unsigned char *buf) {uint32_t head = *(uint32_t *)buf;
Signature · 1 line
2.45.1
Quoted 9 lines · On Sun, 2 Jun 2024 01:07:09 +0100 [email protected] wrote:
From: "Dr. David Alan Gilbert" <[email protected]>
'
hisi_ptt_queue' has been unused since the original commit5e91e57e6809("perf auxtrace arm64: Add support for parsing HiSilicon PCIe Trace packet").Remove it.
Signed-off-by Dr. David Alan Gilbert <[email protected]>
LGTM
Minimal
by which I mean I searched for it and indeed found only this definition.
Quoted 20 lines
--- tools/perf/util/hisi-ptt.c | 5 ----- 1 file changed, 5 deletions(-)tools/perf/util/hisi-ptt.c +0
-5@@ -35,11 +35,6 @@ struct hisi_ptt {u32 pmu_type; }; -struct hisi_ptt_queue { -struct hisi_ptt *ptt; -struct auxtrace_buffer *buffer; -}; -static enum hisi_ptt_pkt_type hisi_ptt_check_packet_type (unsigned char *buf) {uint32_t head = *(uint32_t *)buf;
Quoted 10 lines · On Sat, Jun 1, 2024 at 5:07 PM <[email protected]> wrote:
From: "Dr. David Alan Gilbert" <[email protected]>
'
hisi_ptt_queue' has been unused since the original commit5e91e57e6809("perf auxtrace arm64: Add support for parsing HiSilicon PCIe Trace packet").Remove it.
Signed-off-by Dr. David Alan Gilbert <[email protected]>
Hi/thanks David,
Ian
Quoted 23 lines
--- tools/perf/util/hisi-ptt.c | 5 ----- 1 file changed, 5 deletions(-)tools/perf/util/hisi-ptt.c +0
-6@@ -35,11 +35,6 @@ struct hisi_ptt {u32 pmu_type; }; -struct hisi_ptt_queue { -struct hisi_ptt *ptt; -struct auxtrace_buffer *buffer; -}; -static enum hisi_ptt_pkt_type hisi_ptt_check_packet_type (unsigned char *buf) {uint32_t head = *(uint32_t *)buf; --2.45.1
On Sun, 02 Jun 2024 01:07:09 +0100, [email protected] wrote:
Applied to perf-tools-next, thanks!
Best regards,
Namhyung