Skip to contentSkip to conversation

perf hisi-ptt: remove unused struct 'hisi_ptt_queue'

PATCH Applied [email protected] 4 participants 4 messages Jun 2, 2024 – Jun 6, 2024

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 perf hisi-ptt: remove unused struct 'hisi_ptt_queue'

From: "Dr. David Alan Gilbert" <[email protected]>

'hisi_ptt_queue' has been unused since the original commit 5e91e57e6809 ("perf auxtrace arm64: Add support for parsing HiSilicon PCIe Trace packet").

Remove it.

---
 tools/perf/util/hisi-ptt.c | 5 -----
 1 file changed, 5 deletions(-)
tools/perf/util/hisi-ptt.c +0 -5
index 52d0ce302ca0..37ea987017f6 100644
@@ -35,11 +35,6 @@ struct hisi_ptt {
 	u32 pmu_type;
 };
 
-struct hisi_ptt_queue {
-	struct hisi_ptt *ptt;
-	struct auxtrace_buffer *buffer;
-};
-
 static enum hisi_ptt_pkt_type hisi_ptt_check_packet_type(unsigned char *buf)
 {
 	uint32_t head = *(uint32_t *)buf;
Signature · 1 line
2.45.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 9 lines · On Sun, 2 Jun 2024 01:07:09 +0100 [email protected] wrote:

From: "Dr. David Alan Gilbert" <[email protected]>

'hisi_ptt_queue' has been unused since the original commit 5e91e57e6809 ("perf auxtrace arm64: Add support for parsing HiSilicon PCIe Trace packet").

Remove it.

LGTM
Minimal

by which I mean I searched for it and indeed found only this definition.

Quoted 20 lines
---
 tools/perf/util/hisi-ptt.c | 5 -----
 1 file changed, 5 deletions(-)
tools/perf/util/hisi-ptt.c +0 -5
index 52d0ce302ca0..37ea987017f6 100644
@@ -35,11 +35,6 @@ struct hisi_ptt {
 	u32 pmu_type;
 };
 
-struct hisi_ptt_queue {
-	struct hisi_ptt *ptt;
-	struct auxtrace_buffer *buffer;
-};
-
 static enum hisi_ptt_pkt_type hisi_ptt_check_packet_type(unsigned char *buf)
 {
 	uint32_t head = *(uint32_t *)buf;
reviewer Reviewed-by on v1 1/1
#2 lore raw
In reply to [email protected]
Quoted 10 lines · On Sat, Jun 1, 2024 at 5:07 PM <[email protected]> wrote:

From: "Dr. David Alan Gilbert" <[email protected]>

'hisi_ptt_queue' has been unused since the original commit 5e91e57e6809 ("perf auxtrace arm64: Add support for parsing HiSilicon PCIe Trace packet").

Remove it.

Hi/thanks David,

Ian

Quoted 23 lines
---
 tools/perf/util/hisi-ptt.c | 5 -----
 1 file changed, 5 deletions(-)
tools/perf/util/hisi-ptt.c +0 -6
index 52d0ce302ca0..37ea987017f6 100644
@@ -35,11 +35,6 @@ struct hisi_ptt {
        u32 pmu_type;
 };
 
-struct hisi_ptt_queue {
-       struct hisi_ptt *ptt;
-       struct auxtrace_buffer *buffer;
-};
-
 static enum hisi_ptt_pkt_type hisi_ptt_check_packet_type(unsigned char *buf)
 {
        uint32_t head = *(uint32_t *)buf;
--

2.45.1