drm/tegra: fix a possible null pointer dereference
PATCH v2 1/1 drm/tegra: fix a possible null pointer dereference
In malidp_tegra_crtc_reset, new memory is allocated with kzalloc, but no check is performed. Before calling __drm_atomic_helper_crtc_reset, mw_state should be checked to prevent possible null pointer dereference.
---
V2:
* In patch V2, we call __drm_atomic_helper_crtc_reset(crtc, NULL) when state is null.
Thanks to Thierry Reding for helpful suggestion.
--- drivers/gpu/drm/tegra/dc.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
drivers/gpu/drm/tegra/dc.c +4 -1
@@ -1388,7 +1388,10 @@ static void tegra_crtc_reset(struct drm_crtc *crtc)if (crtc->state)tegra_crtc_atomic_destroy_state (crtc, crtc->state); -__drm_atomic_helper_crtc_reset (crtc, &state->base); +if (state) +__drm_atomic_helper_crtc_reset (crtc, &state->base); +else +__drm_atomic_helper_crtc_reset (crtc,NULL ); } static struct drm_crtc_state *
Signature · 1 line
2.34.1
Quoted 3 lines · Huai-Yuan Liu
In
malidp_tegra_crtc_reset, new memory is allocated with kzalloc, but no check is performed. Before calling__drm_atomic_helper_crtc_reset,mw_stateshould be checked to prevent possible null pointer dereference.
The commit message here still references variables that don't exist in this driver. Looks like copy/paste leftovers from a similar patch?
Thierry