drm/amd/pm: remove dead code in si_convert_power_level_to_smc
Subsystems (3)
PATCH 1/12 drm/amd/pm: remove dead code in si_convert_power_level_to_smc
Since gmc_pg is false, setting mcFlags with SISLANDS_SMC_MC_PG_EN cannot be reach.
--- drivers/gpu/drm/amd/pm/legacy-dpm/si_dpm.c | 3 --- 1 file changed, 3 deletions(-)
drivers/gpu/drm/amd/pm/legacy-dpm/si_dpm.c +0 -3
@@ -5487,9 +5487,6 @@ static int si_convert_power_level_to_smc(struct amdgpu_device *adev, (RREG32(DPG_PIPE_STUTTER_CONTROL) & STUTTER_ENABLE) && (adev->pm.dpm.new_active_crtc_count <= 2)) { level->mcFlags |=SISLANDS_SMC_MC_STUTTER_EN ; - -if (gmc_pg) - level->mcFlags |=SISLANDS_SMC_MC_PG_EN ; }if (adev->gmc.vram_type ==AMDGPU_VRAM_TYPE_GDDR5 ) {
Signature · 1 line
2.25.1
[Public]
Hi Jesse,
Quoted 25 lines
-----Original Message-----
From: Jesse Zhang <[email protected]>
Sent: Monday, June 3, 2024 4:46 PM
To: [email protected]
Cc: Deucher, Alexander <[email protected]>; Koenig, Christian <[email protected]>; Kuehling, Felix <[email protected]>; Huang, Tim <[email protected]>; Zhang, Jesse(Jie) <[email protected]>; Zhang, Jesse(Jie) <[email protected]>
Subject: [PATCH 01/12] drm/amd/pm: remove dead code insi_convert_power_level_to_smcSince
gmc_pgis false, setting mcFlags withSISLANDS_SMC_MC_PG_ENcannot be reach.Signed-off-by Jesse Zhang <[email protected]>--- drivers/gpu/drm/amd/pm/legacy-dpm/si_dpm.c | 3 --- 1 file changed, 3 deletions(-)drivers/gpu/drm/amd/pm/legacy-dpm/si_dpm.c +0
-0
drivers/gpu/drm/amd/pm/legacy-dpm/si_dpm.c static int si_convert_power_level_to_smc(struct · line 5493
Quoted 7 lines
drivers/gpu/drm/amd/pm/legacy-dpm/si_dpm.c +0
-3@@ -5487,9 +5487,6 @@ static int si_convert_power_level_to_smc(struct amdgpu_device *adev, (RREG32(DPG_PIPE_STUTTER_CONTROL) & STUTTER_ENABLE) && (adev->pm.dpm.new_active_crtc_count <= 2)) { level->mcFlags |=SISLANDS_SMC_MC_STUTTER_EN ; - -if (gmc_pg) - level->mcFlags |=SISLANDS_SMC_MC_PG_EN ;
If remove this, the pmc_pg should never be used, maybe remove the definition of "bool gmc_pg = false" as well?
Tim Huang
Quoted 5 lines
drivers/gpu/drm/amd/pm/legacy-dpm/si_dpm.c +0
-0}if (adev->gmc.vram_type == AMDGPU_VRAM_TYPE_GDDR5) {--
2.25.1