riscv: dts: starfive: Update flash partition layout
Subsystems (3)
PATCH 1/1 riscv: dts: starfive: Update flash partition layout
From: Matthias Brugger <[email protected]>
Up to now, the describe flash partition layout has some gaps. Use the whole flash chip by getting rid of the gaps.
---
arch/riscv/boot/dts/starfive/jh7110-common.dtsi | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-)
arch/riscv/boot/dts/starfive/jh7110-common.dtsi +2 -5
@@ -321,16 +321,13 @@ partitions { #size-cells = <1>; spl@0 { - reg = <0x0 0x80000>; + reg = <0x0 0xf0000>; }; uboot-env@f0000 { reg = <0xf0000 0x10000>; }; uboot@100000 { - reg = <0x100000 0x400000>; - }; - reserved-data@600000 { - reg = <0x600000 0xa00000>; + reg = <0x100000 0xf00000>; }; }; };
Signature · 1 line
2.45.1
Quoted 7 lines · On 03.06.24 17:07, [email protected] wrote:
From: Matthias Brugger <[email protected]>
Up to now, the describe flash partition layout has some gaps. Use the whole flash chip by getting rid of the gaps.
Suggested-by Heinrich Schuchardt <[email protected]>Signed-off-by Matthias Brugger <[email protected]>
For flashing larger firmware like EDK II it is helpful to maximize the partition sizes. Thanks for sending the patch.
Commit 8384087a ("riscv: dts: starfive: Add QSPI controller node for StarFive JH7110 SoC") https://lore.kernel.org/linux-riscv/[email protected]/ introduced the current layout.
CCing Starfive's U-Boot reviewers.
Quoted 29 lines
---
arch/riscv/boot/dts/starfive/jh7110-common.dtsi | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-)arch/riscv/boot/dts/starfive/jh7110-common.dtsi +2
-5@@ -321,16 +321,13 @@ partitions { #size-cells = <1>; spl@0 { - reg = <0x0 0x80000>; + reg = <0x0 0xf0000>; }; uboot-env@f0000 { reg = <0xf0000 0x10000>; }; uboot@100000 { - reg = <0x100000 0x400000>; - }; - reserved-data@600000 { - reg = <0x600000 0xa00000>; + reg = <0x100000 0xf00000>; }; }; };
Quoted 13 lines · Heinrich Schuchardt
Quoted 7 lines · On 03.06.24 17:07, [email protected] wrote:
From: Matthias Brugger <[email protected]>
Up to now, the describe flash partition layout has some gaps. Use the whole flash chip by getting rid of the gaps.
Suggested-by Heinrich Schuchardt <[email protected]>Signed-off-by Matthias Brugger <[email protected]>For flashing larger firmware like EDK II it is helpful to maximize the partition sizes. Thanks for sending the patch.
Quoted 8 lines
Commit
8384087a("riscv: dts: starfive: Add QSPI controller node for StarFive JH7110 SoC") https://lore.kernel.org/linux-riscv/20230804020254.291239-4-
[email protected]/
introduced the current layout.CCing Starfive's U-Boot reviewers.
Reviewed-by Heinrich Schuchardt <[email protected]>
We added a "reserved-data" partition because the u-boot of VF2 didn't require a large space and users can use this partition to do something they want.
Best regards,
Hal
Quoted 15 lines
Quoted 15 lines
---
arch/riscv/boot/dts/starfive/jh7110-common.dtsi | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-)arch/riscv/boot/dts/starfive/jh7110-common.dtsi +0
-0@@ -321,16 +321,13 @@ partitions { #size-cells = <1>;
Quoted 16 lines
Quoted 6 lines
arch/riscv/boot/dts/starfive/jh7110-common.dtsi +1
-1spl@0 { - reg = <0x0 0x80000>; + reg = <0x0 0xf0000>; }; uboot-env@f0000 { reg = <0xf0000 0x10000>;arch/riscv/boot/dts/starfive/jh7110-common.dtsi partitions { · line 333
Quoted 10 lines
arch/riscv/boot/dts/starfive/jh7110-common.dtsi +1
-4}; uboot@100000 { - reg = <0x100000 0x400000>; - }; - reserved-data@600000 { - reg = <0x600000 0xa00000>; + reg = <0x100000 0xf00000>; }; }; };
_______________________________________________
linux-riscv mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-riscv
Quoted 7 lines · matthias.bgg@ wrote:
From: Matthias Brugger <[email protected]>
Up to now, the describe flash partition layout has some gaps. Use the whole flash chip by getting rid of the gaps.
Suggested-by Heinrich Schuchardt <[email protected]>Signed-off-by Matthias Brugger <[email protected]>
Hi Matthias,
Thanks for the patch.
Quoted 11 lines
---
arch/riscv/boot/dts/starfive/jh7110-common.dtsi | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-)arch/riscv/boot/dts/starfive/jh7110-common.dtsi +0
-0
arch/riscv/boot/dts/starfive/jh7110-common.dtsi partitions { · line 324
Quoted 5 lines
arch/riscv/boot/dts/starfive/jh7110-common.dtsi +1
-1@@ -321,16 +321,13 @@ partitions { #size-cells = <1>; spl@0 { - reg = <0x0 0x80000>; + reg = <0x0 0xf0000>;
..this is definitely fine, but..
arch/riscv/boot/dts/starfive/jh7110-common.dtsi partitions { · line 330
Quoted 10 lines
arch/riscv/boot/dts/starfive/jh7110-common.dtsi +1
-4}; uboot-env@f0000 { reg = <0xf0000 0x10000>; }; uboot@100000 { - reg = <0x100000 0x400000>; - }; - reserved-data@600000 { - reg = <0x600000 0xa00000>; + reg = <0x100000 0xf00000>;
Do we know that all of the VF2 1.2A, VF2 1.3B and Milk-V Mars boards have at least 15kB SPI flash chips? In other words were there a reason this previously ended at 10kB?
Also it looks like my Mars board and VF2 1.3B both report discovering a "gd25lq128d" chip of 16kB, so why stop at 15kB?
/Emil
Quoted 47 lines · Emil Renner Berthing
Quoted 7 lines · matthias.bgg@ wrote:
From: Matthias Brugger <[email protected]>
Up to now, the describe flash partition layout has some gaps. Use the whole flash chip by getting rid of the gaps.
Suggested-by Heinrich Schuchardt <[email protected]>Signed-off-by Matthias Brugger <[email protected]>Hi Matthias,
Thanks for the patch.
Quoted 11 lines
---
arch/riscv/boot/dts/starfive/jh7110-common.dtsi | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-)arch/riscv/boot/dts/starfive/jh7110-common.dtsi +0
-0arch/riscv/boot/dts/starfive/jh7110-common.dtsi partitions { · line 324
Quoted 5 lines
arch/riscv/boot/dts/starfive/jh7110-common.dtsi +1
-1@@ -321,16 +321,13 @@ partitions { #size-cells = <1>; spl@0 { - reg = <0x0 0x80000>; + reg = <0x0 0xf0000>;..this is definitely fine, but..
arch/riscv/boot/dts/starfive/jh7110-common.dtsi partitions { · line 330
Quoted 10 lines
arch/riscv/boot/dts/starfive/jh7110-common.dtsi +1
-4}; uboot-env@f0000 { reg = <0xf0000 0x10000>; }; uboot@100000 { - reg = <0x100000 0x400000>; - }; - reserved-data@600000 { - reg = <0x600000 0xa00000>; + reg = <0x100000 0xf00000>;Do we know that all of the VF2 1.2A, VF2 1.3B and Milk-V Mars boards have at least 15kB SPI flash chips? In other words were there a reason this previously ended at 10kB?
Quoted 2 lines
Also it looks like my Mars board and VF2 1.3B both report discovering a "gd25lq128d" chip of 16kB, so why stop at 15kB?
Hello Emil,
0xf00000 (15 MiB) is the value of the size-cell. gd25lq128d has 128 Mbit (=16 MiB).
Cf. the examples in Documentation/devicetree/bindings/mtd/partitions/fixed-partitions.yaml
The prior partition scheme had a partition 'reserved-data' also ending at 16 MiB. We don't change the expected size with the current patch.
Best regards
Heinrich
Quoted 2 lines
/Emil
Emil Renner Berthing
Reviewed-byQuoted 53 lines · Heinrich Schuchardt
Quoted 47 lines · Emil Renner Berthing
Quoted 7 lines · matthias.bgg@ wrote:
From: Matthias Brugger <[email protected]>
Up to now, the describe flash partition layout has some gaps. Use the whole flash chip by getting rid of the gaps.
Suggested-by Heinrich Schuchardt <[email protected]>Signed-off-by Matthias Brugger <[email protected]>Hi Matthias,
Thanks for the patch.
Quoted 11 lines
---
arch/riscv/boot/dts/starfive/jh7110-common.dtsi | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-)arch/riscv/boot/dts/starfive/jh7110-common.dtsi +0
-0arch/riscv/boot/dts/starfive/jh7110-common.dtsi partitions { · line 324
Quoted 5 lines
arch/riscv/boot/dts/starfive/jh7110-common.dtsi +1
-1@@ -321,16 +321,13 @@ partitions { #size-cells = <1>; spl@0 { - reg = <0x0 0x80000>; + reg = <0x0 0xf0000>;..this is definitely fine, but..
arch/riscv/boot/dts/starfive/jh7110-common.dtsi partitions { · line 330
Quoted 10 lines
arch/riscv/boot/dts/starfive/jh7110-common.dtsi +1
-4}; uboot-env@f0000 { reg = <0xf0000 0x10000>; }; uboot@100000 { - reg = <0x100000 0x400000>; - }; - reserved-data@600000 { - reg = <0x600000 0xa00000>; + reg = <0x100000 0xf00000>;Do we know that all of the VF2 1.2A, VF2 1.3B and Milk-V Mars boards have at least 15kB SPI flash chips? In other words were there a reason this previously ended at 10kB?
Quoted 2 lines
Also it looks like my Mars board and VF2 1.3B both report discovering a "gd25lq128d" chip of 16kB, so why stop at 15kB?
Hello Emil,
Quoted 8 lines
0xf00000(15 MiB) is the value of the size-cell. gd25lq128d has 128 Mbit (=16 MiB).Cf. the examples in
Documentation/devicetree/bindings/mtd/partitions/fixed-partitions.yamlThe prior partition scheme had a partition 'reserved-data' also ending at 16 MiB. We don't change the expected size with the current patch.
Oh, you're right. I totally misread that, sorry. You can add my
From: Conor Dooley <[email protected]>
Quoted 4 lines · On Mon, 03 Jun 2024 17:07:55 +0200, [email protected] wrote:
Up to now, the describe flash partition layout has some gaps. Use the whole flash chip by getting rid of the gaps.
Applied to riscv-dt-for-next, thanks!
[1/1] riscv: dts: starfive: Update flash partition layout
https://git.kernel.org/conor/c/1dc5f8f6ea73
Thanks,
Conor.