Skip to contentSkip to conversation

drm/amdgpu: fix the overflowed constant warning for RREG32_SOC15()

PATCH In review Bob Zhou 2 participants 2 messages Jun 4, 2024

Subsystems (2)
lore
Share & tools
lore

Bob Zhou

author
#0 lore raw

PATCH v2 1/1 drm/amdgpu: fix the overflowed constant warning for RREG32_SOC15()

To fix potential overflowed constant warning reported by Coverity, modify the variables to uint32_t.

---
 drivers/gpu/drm/amd/amdgpu/imu_v12_0.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
drivers/gpu/drm/amd/amdgpu/imu_v12_0.c +4 -3
index 0c8ef908d112..74999f29d0a6 100644
@@ -119,7 +119,8 @@ static int imu_v12_0_load_microcode(struct amdgpu_device *adev)
 
 static int imu_v12_0_wait_for_reset_status(struct amdgpu_device *adev)
 {
-	int i, imu_reg_val = 0;
+	uint32_t imu_reg_val = 0;
+	int i;
 
 	for (i = 0; i < adev->usec_timeout; i++) {
 		imu_reg_val = RREG32_SOC15(GC, 0, regGFX_IMU_GFX_RESET_CTRL);
@@ -138,7 +139,7 @@ static int imu_v12_0_wait_for_reset_status(struct amdgpu_device *adev)
 
 static void imu_v12_0_setup(struct amdgpu_device *adev)
 {
-	int imu_reg_val;
+	uint32_t imu_reg_val;
 
 	WREG32_SOC15(GC, 0, regGFX_IMU_C2PMSG_ACCESS_CTRL0, 0xffffff);
 	WREG32_SOC15(GC, 0, regGFX_IMU_C2PMSG_ACCESS_CTRL1, 0xffff);
@@ -157,7 +158,7 @@ static void imu_v12_0_setup(struct amdgpu_device *adev)
 
 static int imu_v12_0_start(struct amdgpu_device *adev)
 {
-	int imu_reg_val;
+	uint32_t imu_reg_val;
 
 	imu_reg_val = RREG32_SOC15(GC, 0, regGFX_IMU_CORE_CTRL);
 	imu_reg_val &= 0xfffffffe;
Signature · 1 line
2.34.1
Acked-by on v2 1/1
#1 lore raw

Am 04.06.24 um 09:08 schrieb Bob Zhou:

Quoted 4 lines

To fix potential overflowed constant warning reported by Coverity, modify the variables to uint32_t.

Quoted 36 lines
---
  drivers/gpu/drm/amd/amdgpu/imu_v12_0.c | 7 ++++---
  1 file changed, 4 insertions(+), 3 deletions(-)
drivers/gpu/drm/amd/amdgpu/imu_v12_0.c +4 -3
index 0c8ef908d112..74999f29d0a6 100644
@@ -119,7 +119,8 @@ static int imu_v12_0_load_microcode(struct amdgpu_device *adev)
 
  static int imu_v12_0_wait_for_reset_status(struct amdgpu_device *adev)
  {
-	int i, imu_reg_val = 0;
+	uint32_t imu_reg_val = 0;
+	int i;
 
  	for (i = 0; i < adev->usec_timeout; i++) {
  		imu_reg_val = RREG32_SOC15(GC, 0, regGFX_IMU_GFX_RESET_CTRL);
@@ -138,7 +139,7 @@ static int imu_v12_0_wait_for_reset_status(struct amdgpu_device *adev)
 
  static void imu_v12_0_setup(struct amdgpu_device *adev)
  {
-	int imu_reg_val;
+	uint32_t imu_reg_val;
 
  	WREG32_SOC15(GC, 0, regGFX_IMU_C2PMSG_ACCESS_CTRL0, 0xffffff);
  	WREG32_SOC15(GC, 0, regGFX_IMU_C2PMSG_ACCESS_CTRL1, 0xffff);
@@ -157,7 +158,7 @@ static void imu_v12_0_setup(struct amdgpu_device *adev)
 
  static int imu_v12_0_start(struct amdgpu_device *adev)
  {
-	int imu_reg_val;
+	uint32_t imu_reg_val;
 
  	imu_reg_val = RREG32_SOC15(GC, 0, regGFX_IMU_CORE_CTRL);
  	imu_reg_val &= 0xfffffffe;