bcachefs: Move the ei_flags setting to after initialization
PATCH 1/1 bcachefs: Move the ei_flags setting to after initialization
From: Youling Tang <[email protected]>
inode->ei_flags setting and cleaning should be done after initialization, otherwise the operation is invalid.
Fixes 9ca4853b98af ("bcachefs: Fix quota support for snapshots")
Signed-off-by Youling Tang <[email protected]>
--- fs/bcachefs/fs.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
fs/bcachefs/fs.c +5 -5
@@ -1488,11 +1488,6 @@ static void bch2_vfs_inode_init(struct btree_trans *trans, subvol_inum inum,bch2_iget5_set (&inode->v, &inum);bch2_inode_update_after_write (trans, inode, bi, ~0 ); -if (BCH_SUBVOLUME_SNAP (subvol)) -set_bit (EI_INODE_SNAPSHOT , &inode->ei_flags); -else -clear_bit (EI_INODE_SNAPSHOT , &inode->ei_flags); - inode->v.i_blocks = bi->bi_sectors; inode->v.i_ino = bi->bi_inum; inode->v.i_rdev = bi->bi_dev;
@@ -1504,6 +1499,11 @@ static void bch2_vfs_inode_init(struct btree_trans *trans, subvol_inum inum, inode->ei_qid =bch_qid (bi); inode->ei_subvol = inum.subvol; +if (BCH_SUBVOLUME_SNAP (subvol)) +set_bit (EI_INODE_SNAPSHOT , &inode->ei_flags); +else +clear_bit (EI_INODE_SNAPSHOT , &inode->ei_flags); + inode->v.i_mapping->a_ops = &bch_address_space_operations;switch (inode->v.i_mode &S_IFMT ) {
Signature · 1 line
2.34.1