Skip to contentSkip to conversation

bcache: Fix compiler warnings

PATCH In review Marilene A Garcia 1 participant 2 messages Jun 5, 2024 bcache (block layer cache)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 bcache: Fix compiler warnings

It fixes the following compiler warnings by
using "/*" instead of "/**" in the comments

drivers/md/bcache/request.c:309: warning:
Function parameter or struct member 'bch_data_insert' not described in 'CLOSURE_CALLBACK'

drivers/md/bcache/request.c:309: warning: expecting prototype for bch_data_insert(). Prototype was for CLOSURE_CALLBACK() instead

---
Hello,
These warnings happen using GCC compiler the command 'make W=1'.

Thank you.

 drivers/md/bcache/request.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/md/bcache/request.c +1 -1
index af345dc6fde1..457b9605aff9 100644
@@ -285,7 +285,7 @@ static CLOSURE_CALLBACK(bch_data_insert_start)
 	}
 }
 
-/**
+/*
  * bch_data_insert - stick some data in the cache
  * @cl: closure pointer.
  *
Signature · 1 line
2.34.1
#1 lore raw
Quoted 26 lines · Marilene A Garcia

It fixes the following compiler warnings by
using "/*" instead of "/**" in the comments

drivers/md/bcache/request.c:309: warning:
Function parameter or struct member 'bch_data_insert' not described in 'CLOSURE_CALLBACK'

drivers/md/bcache/request.c:309: warning: expecting prototype for bch_data_insert(). Prototype was for CLOSURE_CALLBACK() instead

---
Hello,
These warnings happen using GCC compiler the command 'make W=1'.

Thank you.

  drivers/md/bcache/request.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/md/bcache/request.c +0 -0
index af345dc6fde1..457b9605aff9 100644

drivers/md/bcache/request.c static CLOSURE_CALLBACK(bch_data_insert_start) · line 291

Quoted 8 lines
drivers/md/bcache/request.c +1 -1
@@ -285,7 +285,7 @@ static CLOSURE_CALLBACK(bch_data_insert_start)
  	}
  }
 
-/**
+/*
   * bch_data_insert - stick some data in the cache
   * @cl: closure pointer.
   *

Hello,
I have realized that even though this change could fix the warning, it is not the correct fix to it, because it breaks the format of kernel function comments.

So please discard the patch.
Thank you.