drm/amd/pm: remove dead code in si_convert_power_level_to_smc
Subsystems (3)
PATCH v2 1/12 drm/amd/pm: remove dead code in si_convert_power_level_to_smc
Since gmc_pg is false, setting mcFlags with SISLANDS_SMC_MC_PG_EN cannot be reach.
Signed-off-by Jesse Zhang <[email protected]>
Suggested-by Tim Huang <[email protected]>
--- drivers/gpu/drm/amd/pm/legacy-dpm/si_dpm.c | 4 ---- 1 file changed, 4 deletions(-)
drivers/gpu/drm/amd/pm/legacy-dpm/si_dpm.c +0 -4
@@ -5467,7 +5467,6 @@ static int si_convert_power_level_to_smc(struct amdgpu_device *adev,int ret;bool dll_state_on;u16 std_vddc; -bool gmc_pg = false;if (eg_pi->pcie_performance_request && (si_pi->force_pcie_gen !=SI_PCIE_GEN_INVALID ))
@@ -5487,9 +5486,6 @@ static int si_convert_power_level_to_smc(struct amdgpu_device *adev, (RREG32(DPG_PIPE_STUTTER_CONTROL) & STUTTER_ENABLE) && (adev->pm.dpm.new_active_crtc_count <= 2)) { level->mcFlags |=SISLANDS_SMC_MC_STUTTER_EN ; - -if (gmc_pg) - level->mcFlags |=SISLANDS_SMC_MC_PG_EN ; }if (adev->gmc.vram_type ==AMDGPU_VRAM_TYPE_GDDR5 ) {
Signature · 1 line
2.25.1
[Public]
This patch is,
Reviewed-by Tim Huang <[email protected]>
Quoted 47 lines
-----Original Message-----
From: Jesse Zhang <[email protected]>
Sent: Wednesday, June 5, 2024 4:34 PM
To: [email protected]
Cc: Deucher, Alexander <[email protected]>; Koenig, Christian <[email protected]>; Huang, Tim <[email protected]>; Zhang, Jesse(Jie) <[email protected]>; Zhang, Jesse(Jie) <[email protected]>
Subject: [PATCH 1/12 V2] drm/amd/pm: remove dead code insi_convert_power_level_to_smcSince
gmc_pgis false, setting mcFlags withSISLANDS_SMC_MC_PG_ENcannot be reach.Signed-off-by Jesse Zhang <[email protected]>Suggested-by Tim Huang <[email protected]>--- drivers/gpu/drm/amd/pm/legacy-dpm/si_dpm.c | 4 ---- 1 file changed, 4 deletions(-)drivers/gpu/drm/amd/pm/legacy-dpm/si_dpm.c +0
-1@@ -5467,7 +5467,6 @@ static int si_convert_power_level_to_smc(structamdgpu_device *adev, int ret;bool dll_state_on;u16 std_vddc; -bool gmc_pg = false; if (eg_pi->pcie_performance_request &&(si_pi->force_pcie_gen != SI_PCIE_GEN_INVALID)) @@ -5487,9 +5486,6 @@ static int si_convert_power_level_to_smc(struct amdgpu_device *adev, (RREG32(DPG_PIPE_STUTTER_CONTROL) & STUTTER_ENABLE) && (adev->pm.dpm.new_active_crtc_count <= 2)) { level->mcFlags |= SISLANDS_SMC_MC_STUTTER_EN;drivers/gpu/drm/amd/pm/legacy-dpm/si_dpm.c +0
-4- -if (gmc_pg) - level->mcFlags |=SISLANDS_SMC_MC_PG_EN ; }if (adev->gmc.vram_type ==AMDGPU_VRAM_TYPE_GDDR5 ) { --2.25.1