Skip to contentSkip to conversation

drm/amd/pm: remove dead code in si_convert_power_level_to_smc

PATCH In review Jesse Zhang 2 participants 2 messages Jun 5, 2024

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/12 drm/amd/pm: remove dead code in si_convert_power_level_to_smc

Since gmc_pg is false, setting mcFlags with SISLANDS_SMC_MC_PG_EN cannot be reach.

---
 drivers/gpu/drm/amd/pm/legacy-dpm/si_dpm.c | 4 ----
 1 file changed, 4 deletions(-)
drivers/gpu/drm/amd/pm/legacy-dpm/si_dpm.c +0 -4
index 68ac01a8bc3a..f324a8ef8032 100644
@@ -5467,7 +5467,6 @@ static int si_convert_power_level_to_smc(struct amdgpu_device *adev,
 	int ret;
 	bool dll_state_on;
 	u16 std_vddc;
-	bool gmc_pg = false;
 
 	if (eg_pi->pcie_performance_request &&
 	    (si_pi->force_pcie_gen != SI_PCIE_GEN_INVALID))
@@ -5487,9 +5486,6 @@ static int si_convert_power_level_to_smc(struct amdgpu_device *adev,
 	    (RREG32(DPG_PIPE_STUTTER_CONTROL) & STUTTER_ENABLE) &&
 	    (adev->pm.dpm.new_active_crtc_count <= 2)) {
 		level->mcFlags |= SISLANDS_SMC_MC_STUTTER_EN;
-
-		if (gmc_pg)
-			level->mcFlags |= SISLANDS_SMC_MC_PG_EN;
 	}
 
 	if (adev->gmc.vram_type == AMDGPU_VRAM_TYPE_GDDR5) {
Signature · 1 line
2.25.1
Reviewed-by on v2 1/12
#1 lore raw

[Public]

This patch is,

Quoted 47 lines

-----Original Message-----
From: Jesse Zhang <[email protected]>
Sent: Wednesday, June 5, 2024 4:34 PM
To: [email protected]
Cc: Deucher, Alexander <[email protected]>; Koenig, Christian <[email protected]>; Huang, Tim <[email protected]>; Zhang, Jesse(Jie) <[email protected]>; Zhang, Jesse(Jie) <[email protected]>
Subject: [PATCH 1/12 V2] drm/amd/pm: remove dead code in si_convert_power_level_to_smc

Since gmc_pg is false, setting mcFlags with SISLANDS_SMC_MC_PG_EN cannot be reach.

---
 drivers/gpu/drm/amd/pm/legacy-dpm/si_dpm.c | 4 ----
 1 file changed, 4 deletions(-)
drivers/gpu/drm/amd/pm/legacy-dpm/si_dpm.c +0 -1
index 68ac01a8bc3a..f324a8ef8032 100644
@@ -5467,7 +5467,6 @@ static int si_convert_power_level_to_smc(struct
 amdgpu_device *adev,
      int ret;
      bool dll_state_on;
      u16 std_vddc;
-     bool gmc_pg = false;
 
      if (eg_pi->pcie_performance_request &&
          (si_pi->force_pcie_gen != SI_PCIE_GEN_INVALID)) @@ -5487,9
+5486,6 @@ static int si_convert_power_level_to_smc(struct amdgpu_device
*adev,
          (RREG32(DPG_PIPE_STUTTER_CONTROL) & STUTTER_ENABLE) &&
          (adev->pm.dpm.new_active_crtc_count <= 2)) {
              level->mcFlags |= SISLANDS_SMC_MC_STUTTER_EN;
drivers/gpu/drm/amd/pm/legacy-dpm/si_dpm.c +0 -4
-
-             if (gmc_pg)
-                     level->mcFlags |= SISLANDS_SMC_MC_PG_EN;
      }
 
      if (adev->gmc.vram_type == AMDGPU_VRAM_TYPE_GDDR5) {
--

2.25.1