nvme-multipath: find NUMA path only for online numa-node
Subsystems (11)
Sasha Levin
maintainerPATCH 1/18 nvme-multipath: find NUMA path only for online numa-node
From: Nilay Shroff <[email protected]>
[ Upstream commit d3a043733f25d743f3aa617c7f82dbcb5ee2211a ]
In current native multipath design when a shared namespace is created, we loop through each possible numa-node, calculate the NUMA distance of that node from each nvme controller and then cache the optimal IO path for future reference while sending IO. The issue with this design is that we may refer to the NUMA distance table for an offline node which may not be populated at the time and so we may inadvertently end up finding and caching a non-optimal path for IO. Then latter when the corresponding numa-node becomes online and hence the NUMA distance table entry for that node is created, ideally we should re-calculate the multipath node distance for the newly added node however that doesn't happen unless we rescan/reset the controller. So essentially, we may keep using non-optimal IO path for a node which is made online after namespace is created.
This patch helps fix this issue ensuring that when a shared namespace is created, we calculate the multipath node distance for each online numa-node instead of each possible numa-node. Then latter when a node becomes online and we receive any IO on that newly added node, we would calculate the multipath node distance for newly added node but this time NUMA distance table would have been already populated for newly added node. Hence we would be able to correctly calculate the multipath node distance and choose the optimal path for the IO.
--- drivers/nvme/host/multipath.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/nvme/host/multipath.c +1 -1
@@ -594,7 +594,7 @@ static void nvme_mpath_set_live(struct nvme_ns *ns)int node, srcu_idx; srcu_idx =srcu_read_lock (&head->srcu); -for_each_node (node) +for_each_online_node (node)__nvme_find_path (head, node);srcu_read_unlock (&head->srcu, srcu_idx); }
Signature · 1 line
2.43.0
Sasha Levin
maintainerPATCH 2/18 dma-mapping: benchmark: avoid needless copy_to_user if benchmark fails
From: Fedor Pchelkin <[email protected]>
[ Upstream commit f7c9ccaadffd13066353332c13d7e9bf73b8f92d ]
If do_map_benchmark() has failed, there is nothing useful to copy back to userspace.
--- kernel/dma/map_benchmark.c | 3 +++ 1 file changed, 3 insertions(+)
kernel/dma/map_benchmark.c +3 -0
@@ -252,6 +252,9 @@ static long map_benchmark_ioctl(struct file *file, unsigned int cmd,* dma_mask changed by benchmark */ dma_set_mask (map->dev, old_dma_mask); + +if (ret) +return ret;break ;default :return -EINVAL ;
Signature · 1 line
2.43.0
Sasha Levin
maintainerPATCH 3/18 connector: Fix invalid conversion in cn_proc.h
In reply to Sasha LevinFrom: Matt Jan <[email protected]>
[ Upstream commit 06e785aeb9ea8a43d0a3967c1ba6e69d758e82d4 ]
The implicit conversion from unsigned int to enumproc_cn_event is invalid, so explicitly cast it
for compilation in a C++ compiler./usr/include/linux/cn_proc.h: In function 'proc_cn_event valid_event(proc_cn_event)':/usr/include/linux/cn_proc.h:72:17: error: invalid conversion from 'unsigned int' to 'proc_cn_event' [-fpermissive]
72 | ev_type &= PROC_EVENT_ALL;
| ^
| |
| unsigned int--- include/uapi/linux/cn_proc.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
include/uapi/linux/cn_proc.h +1 -2
@@ -69,8 +69,7 @@ struct proc_input {static inline enum proc_cn_event valid_event (enum proc_cn_event ev_type) { - ev_type &=PROC_EVENT_ALL ; -return ev_type; +return (enum proc_cn_event )(ev_type &PROC_EVENT_ALL ); }/*
Signature · 1 line
2.43.0
Sasha Levin
maintainerPATCH 4/18 nvme: adjust multiples of NVME_CTRL_PAGE_SIZE in offset
In reply to Sasha LevinFrom: Kundan Kumar <[email protected]>
[ Upstream commit 1bd293fcf3af84674e82ed022c049491f3768840 ]
bio_vec start offset may be relatively large particularly when large folio gets added to the bio. A bigger offset will result in avoiding the single-segment mapping optimization and end up using expensive mempool_alloc further.
Rather than using absolute value, adjust bv_offset by NVME_CTRL_PAGE_SIZE while checking if segment can be fitted into one/two PRP entries.
--- drivers/nvme/host/pci.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/nvme/host/pci.c +2 -1
@@ -778,7 +778,8 @@ static blk_status_t nvme_map_data(struct nvme_dev *dev, struct request *req,struct bio_vec bv =req_bvec (req);if (!is_pci_p2pdma_page (bv.bv_page)) { -if (bv.bv_offset + bv.bv_len <=NVME_CTRL_PAGE_SIZE *2 ) +if ((bv.bv_offset & (NVME_CTRL_PAGE_SIZE -1 )) + + bv.bv_len <=NVME_CTRL_PAGE_SIZE *2 )return nvme_setup_prp_simple (dev, req, &cmnd->rw, &bv);
Signature · 1 line
2.43.0
Sasha Levin
maintainerPATCH 5/18 afs: Don't cross .backup mountpoint from backup volume
In reply to Sasha LevinFrom: Marc Dionne <[email protected]>
[ Upstream commit 29be9100aca2915fab54b5693309bc42956542e5 ]
Don't cross a mountpoint that explicitly specifies a backup volume (target is <vol>.backup) when starting from a backup volume.
It it not uncommon to mount a volume's backup directly in the volume itself. This can cause tools that are not paying attention to get into a loop mounting the volume onto itself as they attempt to traverse the tree, leading to a variety of problems.
This doesn't prevent the general case of loops in a sequence of mountpoints, but addresses a common special case in the same way as other afs clients.
--- fs/afs/mntpt.c | 5 +++++ 1 file changed, 5 insertions(+)
fs/afs/mntpt.c +5 -0
@@ -140,6 +140,11 @@ static int afs_mntpt_set_params(struct fs_context *fc, struct dentry *mntpt)put_page (page);if (ret <0 )return ret; + +/* Don't cross a backup volume mountpoint from a backup volume */ +if (src_as->volume && src_as->volume->type ==AFSVL_BACKVOL && + ctx->type ==AFSVL_BACKVOL ) +return -ENODEV ; }return 0 ;
Signature · 1 line
2.43.0
Sasha Levin
maintainerPATCH 6/18 regmap-i2c: Subtract reg size from max_write
In reply to Sasha LevinFrom: Jim Wylder <[email protected]>
[ Upstream commit 611b7eb19d0a305d4de00280e4a71a1b15c507fc ]
Currently, when an adapter defines a max_write_len quirk, the data will be chunked into data sizes equal to the max_write_len quirk value. But the payload will be increased by the size of the register address before transmission. The resulting value always ends up larger than the limit set by the quirk.
Avoid this error by setting regmap's max_write to the quirk's max_write_len minus the number of bytes for the register and padding. This allows the chunking to work correctly for this limited case without impacting other use-cases.
--- drivers/base/regmap/regmap-i2c.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/base/regmap/regmap-i2c.c +2 -1
@@ -350,7 +350,8 @@ static const struct regmap_bus *regmap_get_i2c_bus(struct i2c_client *i2c,if (quirks->max_write_len && (bus->max_raw_write ==0 || bus->max_raw_write > quirks->max_write_len)) - max_write = quirks->max_write_len; + max_write = quirks->max_write_len - + (config->reg_bits + config->pad_bits) /BITS_PER_BYTE ;if (max_read || max_write) { ret_bus =kmemdup (bus,sizeof (*bus),GFP_KERNEL );
Signature · 1 line
2.43.0
Sasha Levin
maintainerPATCH 7/18 platform/x86: touchscreen_dmi: Add support for setting touchscreen properties from cmdline
In reply to Sasha LevinFrom: Hans de Goede <[email protected]>
[ Upstream commit 0b178b02673998f5acca5a0365a8858ca45beedb ]
On x86/ACPI platforms touchscreens mostly just work without needing any device/model specific configuration. But in some cases (mostly with Silead and Goodix touchscreens) it is still necessary to manually specify various touchscreen-properties on a per model basis.
touchscreen_dmi is a special place for DMI quirks for this, but it can be challenging for users to figure out the right property values, especially for Silead touchscreens where non of these can be read back from the touchscreen-controller.
ATM users can only test touchscreen properties by editing touchscreen_dmi.c and then building a completely new kernel which makes it unnecessary difficult for users to test and submit properties when necessary for their laptop / tablet model.
Add support for specifying properties on the kernel commandline to allow users to easily figure out the right settings. See the added documentation in kernel-parameters.txt for the commandline syntax.
--- .../admin-guide/kernel-parameters.txt | 22 ++++++ drivers/platform/x86/touchscreen_dmi.c | 79 ++++++++++++++++++- 2 files changed, 98 insertions(+), 3 deletions(-)
Documentation/admin-guide/kernel-parameters.txt +22 -0
@@ -1880,6 +1880,28 @@ Format: <bus_id>,<clkrate> + i2c_touchscreen_props= [HW,ACPI,X86] + Set device-properties for ACPI-enumerated I2C-attached + touchscreen, to e.g. fix coordinates of upside-down + mounted touchscreens. If you need this option please + submit a drivers/platform/x86/touchscreen_dmi.c patch + adding a DMI quirk for this. + + Format: + <ACPI_HW_ID>:<prop_name>=<val>[:prop_name=val][:...] + Where <val> is one of: + Omit "=<val>" entirely Set a boolean device-property + Unsigned number Set a u32 device-property + Anything else Set a string device-property + + Examples (split over multiple lines): + i2c_touchscreen_props=GDIX1001:touchscreen-inverted-x: + touchscreen-inverted-y + + i2c_touchscreen_props=MSSL1680:touchscreen-size-x=1920: + touchscreen-size-y=1080:touchscreen-inverted-y: + firmware-name=gsl1680-vendor-model.fw:silead,home-button + i8042.debug [HW] Toggle i8042 debug mode i8042.unmask_kbd_data [HW] Enable printing of interrupt data from the KBD port
drivers/platform/x86/touchscreen_dmi.c +76 -3
112 lines not on this page · raw message
Signature · 1 line
2.43.0
Sasha Levin
maintainerPATCH 8/18 platform/x86: touchscreen_dmi: Add info for GlobalSpace SolT IVW 11.6" tablet
In reply to Sasha LevinFrom: hmtheboy154 <[email protected]>
[ Upstream commit 7c8639aa41343fd7b3dbe09baf6b0791fcc407a1 ]
This is a tablet created by GlobalSpace Technologies Limited which uses an Intel Atom x5-Z8300, 4GB of RAM & 64GB of storage.
--- drivers/platform/x86/touchscreen_dmi.c | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+)
drivers/platform/x86/touchscreen_dmi.c +25 -0
@@ -900,6 +900,22 @@ static const struct ts_dmi_data schneider_sct101ctm_data = { .properties = schneider_sct101ctm_props, }; +static const struct property_entry globalspace_solt_ivw116_props[] = { +PROPERTY_ENTRY_U32 ("touchscreen-min-x" ,7 ), +PROPERTY_ENTRY_U32 ("touchscreen-min-y" ,22 ), +PROPERTY_ENTRY_U32 ("touchscreen-size-x" ,1723 ), +PROPERTY_ENTRY_U32 ("touchscreen-size-y" ,1077 ), +PROPERTY_ENTRY_STRING ("firmware-name" ,"gsl1680-globalspace-solt-ivw116.fw" ), +PROPERTY_ENTRY_U32 ("silead,max-fingers" ,10 ), +PROPERTY_ENTRY_BOOL ("silead,home-button" ), + { } +}; + +static const struct ts_dmi_data globalspace_solt_ivw116_data = { + .acpi_name ="MSSL1680:00" , + .properties = globalspace_solt_ivw116_props, +}; +static const struct property_entry techbite_arc_11_6_props[] = {PROPERTY_ENTRY_U32 ("touchscreen-min-x" ,5 ),PROPERTY_ENTRY_U32 ("touchscreen-min-y" ,7 ),
@@ -1627,6 +1643,15 @@ const struct dmi_system_id touchscreen_dmi_table[] = { DMI_MATCH(DMI_PRODUCT_NAME, "SCT101CTM"), }, }, + { +/* GlobalSpace SoLT IVW 11.6" */ + .driver_data = (void *)&globalspace_solt_ivw116_data, + .matches = { +DMI_MATCH (DMI_SYS_VENDOR ,"Globalspace Tech Pvt Ltd" ), +DMI_MATCH (DMI_PRODUCT_NAME ,"SolTIVW" ), + DMI_MATCH(DMI_PRODUCT_SKU, "PN20170413488"), + }, + }, {/* Techbite Arc 11.6 */ .driver_data = (void *)&techbite_arc_11_6_data,
Signature · 1 line
2.43.0
Sasha Levin
maintainerPATCH 9/18 platform/x86: touchscreen_dmi: Add info for the EZpad 6s Pro
In reply to Sasha LevinFrom: hmtheboy154 <[email protected]>
[ Upstream commit 3050052613790e75b5e4a8536930426b0a8b0774 ]
The "EZpad 6s Pro" uses the same touchscreen as the "EZpad 6 Pro B", unlike the "Ezpad 6 Pro" which has its own touchscreen.
--- drivers/platform/x86/touchscreen_dmi.c | 11 +++++++++++ 1 file changed, 11 insertions(+)
drivers/platform/x86/touchscreen_dmi.c +11 -0
@@ -1404,6 +1404,17 @@ const struct dmi_system_id touchscreen_dmi_table[] = { DMI_MATCH(DMI_BIOS_DATE, "04/24/2018"), }, }, + { +/* Jumper EZpad 6s Pro */ + .driver_data = (void *)&jumper_ezpad_6_pro_b_data, + .matches = { +DMI_MATCH (DMI_SYS_VENDOR ,"Jumper" ), +DMI_MATCH (DMI_PRODUCT_NAME ,"Ezpad" ), +/* Above matches are too generic, add bios match */ +DMI_MATCH (DMI_BIOS_VERSION ,"E.WSA116_8.E1.042.bin" ), + DMI_MATCH(DMI_BIOS_DATE, "01/08/2020"), + }, + }, {/* Jumper EZpad 6 m4 */ .driver_data = (void *)&jumper_ezpad_6_m4_data,
Signature · 1 line
2.43.0
Sasha Levin
maintainerPATCH 10/18 nvmet: fix a possible leak when destroy a ctrl during qp establishment
In reply to Sasha LevinFrom: Sagi Grimberg <[email protected]>
[ Upstream commit c758b77d4a0a0ed3a1292b3fd7a2aeccd1a169a4 ]
In nvmet_sq_destroy we capture sq->ctrl early and if it is non-NULL we know that a ctrl was allocated (in the admin connect request handler) and we need to release pending AERs, clear ctrl->sqs and sq->ctrl (for nvme-loop primarily), and drop the final reference on the ctrl.
However, a small window is possible where nvmet_sq_destroy starts (as a result of the client giving up and disconnecting) concurrently with the nvme admin connect cmd (which may be in an early stage). But *before* kill_and_confirm of sq->ref (i.e. the admin connect managed to get an sq live reference). In this case, sq->ctrl was allocated however after it was captured in a local variable in nvmet_sq_destroy.
This prevented the final reference drop on the ctrl.
Solve this by re-capturing the sq->ctrl after all inflight request has completed, where for sure sq->ctrl reference is final, and move forward based on that.
This issue was observed in an environment with many hosts connecting multiple ctrls simoutanuosly, creating a delay in allocating a ctrl leading up to this race window.
--- drivers/nvme/target/core.c | 9 +++++++++ 1 file changed, 9 insertions(+)
drivers/nvme/target/core.c +9 -0
@@ -806,6 +806,15 @@ void nvmet_sq_destroy(struct nvmet_sq *sq)percpu_ref_exit (&sq->ref);nvmet_auth_sq_free (sq); +/* +* we must reference the ctrl again after waiting for inflight IO +* to complete. Because admin connect may have sneaked in after we +* store sq->ctrl locally, but before we killed the percpu_ref. the +* admin connect allocates and assigns sq->ctrl, which now needs a +* final ref put, as this ctrl is going away. +*/ + ctrl = sq->ctrl; +if (ctrl) {/* * The teardown flow may take some time, and the host may not
Signature · 1 line
2.43.0
Sasha Levin
maintainerPATCH 11/18 kbuild: fix short log for AS in link-vmlinux.sh
In reply to Sasha LevinFrom: Masahiro Yamada <[email protected]>
[ Upstream commit 3430f65d6130ccbc86f0ff45642eeb9e2032a600 ]
In convention, short logs print the output file, not the input file.
Let's change the suffix for 'AS' since it assembles *.S into *.o.
[Before]
LD .tmp_vmlinux.kallsyms1 NM .tmp_vmlinux.kallsyms1.syms KSYMS .tmp_vmlinux.kallsyms1.S AS .tmp_vmlinux.kallsyms1.S LD .tmp_vmlinux.kallsyms2 NM .tmp_vmlinux.kallsyms2.syms KSYMS .tmp_vmlinux.kallsyms2.S AS .tmp_vmlinux.kallsyms2.S LD vmlinux
[After]
LD .tmp_vmlinux.kallsyms1 NM .tmp_vmlinux.kallsyms1.syms KSYMS .tmp_vmlinux.kallsyms1.S AS .tmp_vmlinux.kallsyms1.o LD .tmp_vmlinux.kallsyms2 NM .tmp_vmlinux.kallsyms2.syms KSYMS .tmp_vmlinux.kallsyms2.S AS .tmp_vmlinux.kallsyms2.o LD vmlinux
--- scripts/link-vmlinux.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
scripts/link-vmlinux.sh +1 -1
@@ -182,7 +182,7 @@ kallsyms_step() mksysmap ${kallsyms_vmlinux} ${kallsyms_vmlinux}.syms ${kallsymso_prev} kallsyms ${kallsyms_vmlinux}.syms ${kallsyms_S} - info AS ${kallsyms_S} + info AS ${kallsymso} ${CC} ${NOSTDINC_FLAGS} ${LINUXINCLUDE} ${KBUILD_CPPFLAGS} \ ${KBUILD_AFLAGS} ${KBUILD_AFLAGS_KERNEL} \ -c -o ${kallsymso} ${kallsyms_S}
Signature · 1 line
2.43.0
Sasha Levin
maintainerPATCH 12/18 nfc/nci: Add the inconsistency check between the input data length and count
In reply to Sasha LevinFrom: Edward Adam Davis <[email protected]>
[ Upstream commit 068648aab72c9ba7b0597354ef4d81ffaac7b979 ]
write$nci(r0, &(0x7f0000000740)=ANY=[@ANYBLOB="610501"], 0xf)
Syzbot constructed a write() call with a data length of 3 bytes but a count value of 15, which passed too little data to meet the basic requirements of the function nci_rf_intf_activated_ntf_packet().
Therefore, increasing the comparison between data length and count value to avoid problems caused by inconsistent data length and count.
--- drivers/nfc/virtual_ncidev.c | 4 ++++ 1 file changed, 4 insertions(+)
drivers/nfc/virtual_ncidev.c +4 -0
@@ -125,6 +125,10 @@ static ssize_t virtual_ncidev_write(struct file *file,kfree_skb (skb);return -EFAULT ; } +if (strnlen (skb->data, count) != count) { +kfree_skb (skb); +return -EINVAL ; + }nci_recv_frame (vdev->ndev, skb);return count;
Signature · 1 line
2.43.0
Sasha Levin
maintainerPATCH 13/18 spi: cadence: Ensure data lines set to low during dummy-cycle period
In reply to Sasha LevinFrom: Witold Sadowski <[email protected]>
[ Upstream commit 4a69c1264ff41bc5bf7c03101ada0454fbf08868 ]
During dummy-cycles xSPI will switch GPIO into Hi-Z mode. In that dummy period voltage on data lines will slowly drop, what can cause unintentional modebyte transmission. Value send to SPI memory chip will depend on last address, and clock frequency.
To prevent unforeseen consequences of that behaviour, force send single modebyte(0x00).
Modebyte will be send only if number of dummy-cycles is not equal to 0. Code must also reduce dummycycle byte count by one - as one byte is send as modebyte.
--- drivers/spi/spi-cadence-xspi.c | 20 +++++++++++++++----- 1 file changed, 15 insertions(+), 5 deletions(-)
drivers/spi/spi-cadence-xspi.c +15 -5
@@ -145,6 +145,9 @@#define CDNS_XSPI_STIG_DONE_FLAG BIT(0)#define CDNS_XSPI_TRD_STATUS 0x0104 +#define MODE_NO_OF_BYTES GENMASK(25, 24) +#define MODEBYTES_COUNT 1 +/* Helper macros for filling command registers */ #define CDNS_XSPI_CMD_FLD_P1_INSTR_CMD_1 (op, data_phase) ( \ FIELD_PREP(CDNS_XSPI_CMD_INSTR_TYPE, (data_phase) ? \
@@ -157,9 +160,10 @@ FIELD_PREP(CDNS_XSPI_CMD_P1_R2_ADDR3, ((op)->addr.val >> 24) & 0xFF) | \ FIELD_PREP(CDNS_XSPI_CMD_P1_R2_ADDR4, ((op)->addr.val >> 32) & 0xFF)) -#define CDNS_XSPI_CMD_FLD_P1_INSTR_CMD_3 (op) ( \ +#define CDNS_XSPI_CMD_FLD_P1_INSTR_CMD_3 (op, modebytes) ( \ FIELD_PREP(CDNS_XSPI_CMD_P1_R3_ADDR5, ((op)->addr.val >> 40) & 0xFF) | \ FIELD_PREP(CDNS_XSPI_CMD_P1_R3_CMD, (op)->cmd.opcode) | \ + FIELD_PREP(MODE_NO_OF_BYTES, modebytes) | \ FIELD_PREP(CDNS_XSPI_CMD_P1_R3_NUM_ADDR_BYTES, (op)->addr.nbytes))#define CDNS_XSPI_CMD_FLD_P1_INSTR_CMD_4 (op, chipsel) ( \
@@ -173,12 +177,12 @@#define CDNS_XSPI_CMD_FLD_DSEQ_CMD_2 (op) \ FIELD_PREP(CDNS_XSPI_CMD_DSEQ_R2_DCNT_L, (op)->data.nbytes & 0xFFFF) -#define CDNS_XSPI_CMD_FLD_DSEQ_CMD_3 (op) ( \ +#define CDNS_XSPI_CMD_FLD_DSEQ_CMD_3 (op, dummybytes) ( \ FIELD_PREP(CDNS_XSPI_CMD_DSEQ_R3_DCNT_H, \ ((op)->data.nbytes >> 16) & 0xffff) | \ FIELD_PREP(CDNS_XSPI_CMD_DSEQ_R3_NUM_OF_DUMMY, \ (op)->dummy.buswidth != 0 ? \ - (((op)->dummy.nbytes * 8) / (op)->dummy.buswidth) : \ + (((dummybytes) * 8) / (op)->dummy.buswidth) : \ 0))#define CDNS_XSPI_CMD_FLD_DSEQ_CMD_4 (op, chipsel) ( \
@@ -351,6 +355,7 @@ static int cdns_xspi_send_stig_command(struct cdns_xspi_dev *cdns_xspi,u32 cmd_regs[6 ];u32 cmd_status;int ret; +int dummybytes = op->dummy.nbytes; ret =cdns_xspi_wait_for_controller_idle (cdns_xspi);if (ret <0 )
@@ -365,7 +370,12 @@ static int cdns_xspi_send_stig_command(struct cdns_xspi_dev *cdns_xspi,memset (cmd_regs,0 ,sizeof (cmd_regs)); cmd_regs[1 ] =CDNS_XSPI_CMD_FLD_P1_INSTR_CMD_1 (op, data_phase); cmd_regs[2 ] =CDNS_XSPI_CMD_FLD_P1_INSTR_CMD_2 (op); - cmd_regs[3 ] =CDNS_XSPI_CMD_FLD_P1_INSTR_CMD_3 (op); +if (dummybytes !=0 ) { + cmd_regs[3 ] =CDNS_XSPI_CMD_FLD_P1_INSTR_CMD_3 (op,1 ); + dummybytes--; + }else { + cmd_regs[3 ] =CDNS_XSPI_CMD_FLD_P1_INSTR_CMD_3 (op,0 ); + } cmd_regs[4 ] =CDNS_XSPI_CMD_FLD_P1_INSTR_CMD_4 (op, cdns_xspi->cur_cs);
@@ -375,7 +385,7 @@ static int cdns_xspi_send_stig_command(struct cdns_xspi_dev *cdns_xspi, cmd_regs[0 ] =CDNS_XSPI_STIG_DONE_FLAG ; cmd_regs[1 ] =CDNS_XSPI_CMD_FLD_DSEQ_CMD_1 (op); cmd_regs[2 ] =CDNS_XSPI_CMD_FLD_DSEQ_CMD_2 (op); - cmd_regs[3 ] =CDNS_XSPI_CMD_FLD_DSEQ_CMD_3 (op); + cmd_regs[3 ] =CDNS_XSPI_CMD_FLD_DSEQ_CMD_3 (op, dummybytes); cmd_regs[4 ] =CDNS_XSPI_CMD_FLD_DSEQ_CMD_4 (op, cdns_xspi->cur_cs);
Signature · 1 line
2.43.0
Sasha Levin
maintainerPATCH 14/18 ALSA: ump: Set default protocol when not given explicitly
In reply to Sasha LevinFrom: Takashi Iwai <[email protected]>
[ Upstream commit bc42ca002d5d211f9c57334b9b4c25ddb0b4ec35 ]
When an inquiry of the current protocol via UMP Stream Configuration message fails by some reason, we may leave the current protocol undefined, which may lead to unexpected behavior. Better to assume a valid protocol found in the protocol capability bits instead.
For a device that doesn't support the UMP v1.2 feature, it won't reach to this code path, and USB MIDI GTB descriptor would be used for determining the protocol, instead.
--- sound/core/ump.c | 8 ++++++++ 1 file changed, 8 insertions(+)
sound/core/ump.c +8 -0
@@ -960,6 +960,14 @@ int snd_ump_parse_endpoint(struct snd_ump_endpoint *ump)if (err <0 )ump_dbg (ump,"Unable to get UMP EP stream config\n" ); +/* If no protocol is set by some reason, assume the valid one */ +if (!(ump->info.protocol &SNDRV_UMP_EP_INFO_PROTO_MIDI_MASK )) { +if (ump->info.protocol_caps &SNDRV_UMP_EP_INFO_PROTO_MIDI2 ) + ump->info.protocol |=SNDRV_UMP_EP_INFO_PROTO_MIDI2 ; +else if (ump->info.protocol_caps &SNDRV_UMP_EP_INFO_PROTO_MIDI1 ) + ump->info.protocol |=SNDRV_UMP_EP_INFO_PROTO_MIDI1 ; + } +/* Query and create blocks from Function Blocks */ for (blk =0 ; blk < ump->info.num_blocks; blk++) { err =create_block_from_fb_info (ump, blk);
Signature · 1 line
2.43.0
Sasha Levin
maintainerPATCH 15/18 drm/amdgpu: silence UBSAN warning
In reply to Sasha LevinFrom: Alex Deucher <[email protected]>
[ Upstream commit 05d9e24ddb15160164ba6e917a88c00907dc2434 ]
Convert a variable sized array from [1] to [].
--- drivers/gpu/drm/amd/include/atomfirmware.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/include/atomfirmware.h +1 -1
@@ -3508,7 +3508,7 @@ struct atom_gpio_voltage_object_v4uint8_t phase_delay_us;// phase delay in unit of micro second uint8_t reserved;uint32_t gpio_mask_val;// GPIO Mask value -struct atom_voltage_gpio_map_lut voltage_gpio_lut[1 ]; + struct atom_voltage_gpio_map_lut voltage_gpio_lut[] __counted_by(gpio_entry_num); };struct atom_svid2_voltage_object_v4
Signature · 1 line
2.43.0
Sasha Levin
maintainerPATCH 16/18 drm/amdgpu: fix dereference null return value for the function amdgpu_vm_pt_parent
In reply to Sasha LevinFrom: Jesse Zhang <[email protected]>
[ Upstream commit a0cf36546cc24ae1c95d72253c7795d4d2fc77aa ]
The pointer parent may be NULLed by the function amdgpu_vm_pt_parent. To make the code more robust, check the pointer parent.
--- drivers/gpu/drm/amd/amdgpu/amdgpu_vm_pt.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_vm_pt.c +5 -1
@@ -766,11 +766,15 @@ int amdgpu_vm_pde_update(struct amdgpu_vm_update_params *params, struct amdgpu_vm_bo_base *entry) {struct amdgpu_vm_bo_base *parent =amdgpu_vm_pt_parent (entry); -struct amdgpu_bo *bo = parent->bo, *pbo; +struct amdgpu_bo *bo, *pbo;struct amdgpu_vm *vm = params->vm;uint64_t pde, pt, flags;unsigned int level; +if (WARN_ON (!parent)) +return -EINVAL ; + + bo = parent->bo;for (level =0 , pbo = bo->parent; pbo; ++level) pbo = pbo->parent;
Signature · 1 line
2.43.0
Sasha Levin
maintainerPATCH 17/18 Revert "drm/amdkfd: fix gfx_target_version for certain 11.0.3 devices"
In reply to Sasha LevinFrom: Alex Deucher <[email protected]>
[ Upstream commit dd2b75fd9a79bf418e088656822af06fc253dbe3 ]
This reverts commit 28ebbb4981cb1fad12e0b1227dbecc88810b1ee8.
Revert this commit as apparently the LLVM code to take advantage of this never landed.
--- drivers/gpu/drm/amd/amdkfd/kfd_device.c | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-)
drivers/gpu/drm/amd/amdkfd/kfd_device.c +2 -9
@@ -405,15 +405,8 @@ struct kfd_dev *kgd2kfd_probe(struct amdgpu_device *adev, bool vf) f2g = &gfx_v11_kfd2kgd;break ;case IP_VERSION (11 ,0 ,3 ): -if ((adev->pdev->device ==0x7460 && - adev->pdev->revision ==0x00 ) || - (adev->pdev->device ==0x7461 && - adev->pdev->revision ==0x00 )) -/* Note: Compiler version is 11.0.5 while HW version is 11.0.3 */ - gfx_target_version =110005 ; -else -/* Note: Compiler version is 11.0.1 while HW version is 11.0.3 */ - gfx_target_version =110001 ; +/* Note: Compiler version is 11.0.1 while HW version is 11.0.3 */ + gfx_target_version =110001 ; f2g = &gfx_v11_kfd2kgd;break ;case IP_VERSION (11 ,5 ,0 ):
Signature · 1 line
2.43.0
Sasha Levin
maintainerPATCH 18/18 null_blk: Do not allow runt zone with zone capacity smaller then zone size
In reply to Sasha LevinFrom: Damien Le Moal <[email protected]>
[ Upstream commit b164316808ec5de391c3e7b0148ec937d32d280d ]
A zoned device with a smaller last zone together with a zone capacity smaller than the zone size does make any sense as that does not correspond to any possible setup for a real device:
1) For ZNS and zoned UFS devices, all zones are always the same size.
2) For SMR HDDs, all zones always have the same capacity. In other words, if we have a smaller last runt zone, then this zone capacity should always be equal to the zone size.
Add a check in null_init_zoned_dev() to prevent a configuration to have both a smaller zone size and a zone capacity smaller than the zone size.
--- drivers/block/null_blk/zoned.c | 11 +++++++++++ 1 file changed, 11 insertions(+)
drivers/block/null_blk/zoned.c +11 -0
@@ -83,6 +83,17 @@ int null_init_zoned_dev(struct nullb_device *dev, struct request_queue *q)return -EINVAL ; } +/* +* If a smaller zone capacity was requested, do not allow a smaller last +* zone at the same time as such zone configuration does not correspond +* to any real zoned device. +*/ +if (dev->zone_capacity != dev->zone_size && + dev->size & (dev->zone_size -1 )) { +pr_err ("A smaller last zone is not allowed with zone capacity smaller than zone size.\n" ); +return -EINVAL ; + } + zone_capacity_sects =mb_to_sects (dev->zone_capacity); dev_capacity_sects =mb_to_sects (dev->size); dev->zone_size_sects =mb_to_sects (dev->zone_size);
Signature · 1 line
2.43.0