Skip to contentSkip to conversation

iwlwifi: mvm: adding check if the thermal firmware is running

PATCH Superseded Guilherme Giacomo Simoes 1 participant 1 message Jun 5, 2024 Intel wireless wifi link (iwlwifi)

lore
Share & tools
lore
#0 lore raw

PATCH v4 1/1 iwlwifi: mvm: adding check if the thermal firmware is running

In the dmesg is showing the message "failed to read out thermal zone" as if the temperature read is failed by don't find the thermal zone.

After researching and debugging, I see that this specific error is occurrenced because the thermal try read the temperature when is started, but the firmware is not running yet.

For more legibiliti i change the tt.c for return EAGAIN when this was occurrence. After this change, in my computer I compile and install kernel in /boot and in my dmesg the message "failed to read out thermal zone" is not show any more.

I would like to thanks for Rafael Wysocki <[email protected]> , Kalle Valo <[email protected]> and Johannes Berg <[email protected]> for your suggestions in my previous patch.

---
 drivers/net/wireless/intel/iwlwifi/mvm/tt.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)
drivers/net/wireless/intel/iwlwifi/mvm/tt.c +6 -2
index 8083c4b2ab6b..d1dd334b5049 100644
@@ -620,8 +620,12 @@ static int iwl_mvm_tzone_get_temp(struct thermal_zone_device *device,
 
 	mutex_lock(&mvm->mutex);
 
-	if (!iwl_mvm_firmware_running(mvm) ||
-	    mvm->fwrt.cur_fw_img != IWL_UCODE_REGULAR) {
+	if (!iwl_mvm_firmware_running(mvm)) {
+		ret = -EAGAIN;
+		goto out;
+	}
+
+	if (mvm->fwrt.cur_fw_img != IWL_UCODE_REGULAR) {
 		ret = -ENODATA;
 		goto out;
 	}
Signature · 1 line
2.45.2