memcg-remove-the-lockdep-assert-from-__mod_objcg_mlstate.patch removed from -mm tree
The quilt patch titled
Subject: memcg: remove the lockdep assert from __mod_objcg_mlstate()
has been removed from the -mm tree. Its filename was
memcg-remove-the-lockdep-assert-from-__mod_objcg_mlstate.patch
This patch was dropped because it was merged into the mm-hotfixes-stable branch of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
------------------------------------------------------
From: Sebastian Andrzej Siewior <[email protected]>
Subject: memcg: remove the lockdep assert from __mod_objcg_mlstate()
Date: Tue, 28 May 2024 16:13:41 +0200
The assert was introduced in the commit cited below as an insurance that the semantic is the same after the local_irq_save() has been removed and the function has been made static.
The original requirement to disable interrupt was due the modification of per-CPU counters which require interrupts to be disabled because the counter update operation is not atomic and some of the counters are updated from interrupt context.
All callers of __mod_objcg_mlstate() acquire a lock (memcg_stock.stock_lock) which disables interrupts on !PREEMPT_RT and the lockdep assert is satisfied. On PREEMPT_RT the interrupts are not disabled and the assert triggers.
The safety of the counter update is already ensured by VM_WARN_ON_IRQS_ENABLED() which is part of __mod_memcg_lruvec_state() and does not require yet another check.
Remove the lockdep assert from __mod_objcg_mlstate().
---
mm/memcontrol.c | 2 -- 1 file changed, 2 deletions(-)
mm/memcontrol.c renamed from mm/memcontrol.c~memcg-remove-the-lockdep-assert-from-__mod_objcg_mlstate +0 -2
@@ -3147,8 +3147,6 @@ static inline void __mod_objcg_mlstate(sstruct mem_cgroup *memcg;struct lruvec *lruvec; -lockdep_assert_irqs_disabled (); -rcu_read_lock (); memcg =obj_cgroup_memcg (objcg); lruvec =mem_cgroup_lruvec (memcg, pgdat);
_
Patches currently in -mm which might be from [email protected] are