Skip to contentSkip to conversation

RDMA/mana_ib: ignore optional access flags for MRs

PATCH Applied Konstantin Taranov 4 participants 6 messages Jun 5, 2024 – Jun 6, 2024

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 RDMA/mana_ib: ignore optional access flags for MRs

From: Konstantin Taranov <[email protected]>

Ignore optional ib_access_flags when an MR is created.

Fixes 0266a177631d ("RDMA/mana_ib: Add a driver for Microsoft Azure Network Adapter")
---
 drivers/infiniband/hw/mana/mr.c | 1 +
 1 file changed, 1 insertion(+)
drivers/infiniband/hw/mana/mr.c +1 -0
index 4f13423..887b09d 100644
@@ -112,6 +112,7 @@ struct ib_mr *mana_ib_reg_user_mr(struct ib_pd *ibpd, u64 start, u64 length,
 		  "start 0x%llx, iova 0x%llx length 0x%llx access_flags 0x%x",
 		  start, iova, length, access_flags);
 
+	access_flags &= ~IB_ACCESS_OPTIONAL;
 	if (access_flags & ~VALID_MR_FLAGS)
 		return ERR_PTR(-EINVAL);
 
Signature · 1 line
2.43.0
#1 lore raw
Quoted 5 lines

Subject: [PATCH v2 1/1] RDMA/mana_ib: ignore optional access flags for MRs

From: Konstantin Taranov <[email protected]>

Ignore optional ib_access_flags when an MR is created.

Can you add details on why this is needed?

#2 lore raw
Quoted 3 lines
Quoted 1 line

Ignore optional ib_access_flags when an MR is created.

Can you add details on why this is needed?

Do you mean to the commit message?
If we do not ignore these optional flags, the reg user mr fails because the next 2 lines:

	if (access_flags & ~VALID_MR_FLAGS)
		return ERR_PTR(-EINVAL);
#3 lore raw
Quoted 8 lines · Konstantin Taranov
Quoted 3 lines
Quoted 1 line

Ignore optional ib_access_flags when an MR is created.

Can you add details on why this is needed?

Do you mean to the commit message?
If we do not ignore these optional flags, the reg user mr fails because the next 2 lines:

	if (access_flags & ~VALID_MR_FLAGS)
		return ERR_PTR(-EINVAL);

I took this patch as is.

Thanks

#4 lore raw
Quoted 6 lines
Quoted 6 lines
Quoted 3 lines
Quoted 1 line

Ignore optional ib_access_flags when an MR is created.

Can you add details on why this is needed?

Do you mean to the commit message?
If we do not ignore these optional flags, the reg user mr fails because the

Quoted 7 lines

next 2 lines:

Quoted 2 lines
	if (access_flags & ~VALID_MR_FLAGS)
		return ERR_PTR(-EINVAL);

I took this patch as is.

Thanks

thanks. It makes sense.