net/ena: devargs api change
cover net/ena: devargs api change
From: Shai Brandes <[email protected]>
Hi everyone, this is an API change to the ena PMD devargs that removes the 3 devargs that control the user setting for the LLQ policy and replaces it with a new shared devarg that implements the same logic.
Shai Brandes (1):
net/ena: restructure the llq policy user setting
doc/guides/nics/ena.rst | 25 ++---- doc/guides/rel_notes/release_24_07.rst | 8 ++ drivers/net/ena/ena_ethdev.c | 104 +++++++++---------------- drivers/net/ena/ena_ethdev.h | 3 - 4 files changed, 51 insertions(+), 89 deletions(-)
Signature · 1 line
2.17.1
PATCH 1/1 net/ena: restructure the llq policy user setting
From: Shai Brandes <[email protected]>
Replaced enable_llq, normal_llq_hdr and large_llq_hdr devargs with a new shared devarg named llq_policy that implements the same logic and accepts the following values:
0 - Disable LLQ.
Use with extreme caution as it leads to a huge performance degradation on AWS instances from 6th generation onwards.
1 - Accept device recommended LLQ policy (Default).
Device can recommend normal or large LLQ policy.
2 - Enforce normal LLQ policy.
3 - Enforce large LLQ policy.
Required for packets with header that exceed 96 bytes on AWS instances prior to 5th generation.
--- doc/guides/nics/ena.rst | 25 ++---- doc/guides/rel_notes/release_24_07.rst | 8 ++ drivers/net/ena/ena_ethdev.c | 104 +++++++++---------------- drivers/net/ena/ena_ethdev.h | 3 - 4 files changed, 51 insertions(+), 89 deletions(-)
doc/guides/nics/ena.rst +8 -17
@@ -107,15 +107,15 @@ Configuration Runtime Configuration ^^^^^^^^^^^^^^^^^^^^^ - * **large_llq_hdr** (default 0) + * **llq_policy** (default 1) - Enables or disables usage of large LLQ headers. This option will have - effect only if the device also supports large LLQ headers. Otherwise, the - default value will be used. - - * **normal_llq_hdr** (default 0) - - Enforce normal LLQ policy. + Controls whether use device recommended header policy or override it. + 0 - Disable LLQ. + **Use with extreme caution as it leads to a huge performance + degradation on AWS instances from 6th generation onwards.** + 1 - Accept device recommended LLQ policy (Default). + 2 - Enforce normal LLQ policy. + 3 - Enforce large LLQ policy. * **miss_txc_to** (default 5)
@@ -126,15 +126,6 @@ Runtime Configuration timer service. Setting this parameter to 0 disables this feature. Maximum allowed value is 60 seconds. - * **enable_llq** (default 1) - - Determines whenever the driver should use the LLQ (if it's available) or - not. - - **NOTE: On the 6th generation AWS instances disabling LLQ may lead to a - huge performance degradation. In general disabling LLQ is highly not - recommended!** - * **control_poll_interval** (default 0) Enable polling-based functionality of the admin queues,
doc/guides/rel_notes/release_24_07.rst +8 -0
@@ -73,6 +73,12 @@ New Features ``bpf_obj_get()`` for an xskmap pinned (by the AF_XDP DP) inside the container. +* **Updated Amazon ena (Elastic Network Adapter) net driver.** + + * Modified the PMD API that controls the LLQ header policy. + Replaced ``enable_llq``, ``normal_llq_hdr`` and ``large_llq_hdr`` devargs + with a new shared devarg ``llq_policy`` that keeps the same logic. + * **Update Tap PMD driver.** * Updated to support up to 8 queues when used by secondary process.
@@ -117,6 +123,8 @@ API Changes This section is a comment. Do not overwrite or remove it. Also, make sure to start the actual text at the margin. ======================================================= +* drivers/net/ena: Removed ``enable_llq``, ``normal_llq_hdr`` and ``large_llq_hdr`` devargs + and replaced it with a new shared devarg ``llq_policy`` that keeps the same logic. ABI Changes
drivers/net/ena/ena_ethdev.c +35 -69
182 lines not on this page · raw message
drivers/net/ena/ena_ethdev.h +0 -3
@@ -337,9 +337,6 @@ struct ena_adapter {uint32_t active_aenq_groups;bool trigger_reset; -bool enable_llq; -bool use_large_llq_hdr; -bool use_normal_llq_hdr;ena_llq_policy llq_header_policy;uint32_t last_tx_comp_qid;
Signature · 1 line
2.17.1
Re: [PATCH 1/1] net/ena: restructure the llq policy user setting
Quoted 15 lines · On 6/6/2024 2:33 PM, [email protected] wrote:
From: Shai Brandes <[email protected]>
Replaced
enable_llq,normal_llq_hdrandlarge_llq_hdrdevargs with a new shared devarg namedllq_policythat implements the same logic and accepts the following values:
0 - Disable LLQ.
Use with extreme caution as it leads to a huge performance degradation on AWS instances from 6th generation onwards.
1 - Accept device recommended LLQ policy (Default).
Device can recommend normal or large LLQ policy.
2 - Enforce normal LLQ policy.
3 - Enforce large LLQ policy.
Required for packets with header that exceed 96 bytes on AWS instances prior to 5th generation.
Quoted 3 lines
Signed-off-by Shai Brandes <[email protected]>Reviewed-by Amit Bernstein <[email protected]>
Hi Shai,
This patch changes device parameters and impacts end user. Although this is not part of ABI policy, and we don't have an explicit policy around it, but since it may impact end user experience, would you be OK to postpone this patch to v24.11 release, where ABI break is planned?
RE: [PATCH 1/1] net/ena: restructure the llq policy user setting
Sure, thanks!
בתאריך 5 ביולי 2024 20:32, Ferruh Yigit <[email protected]> כתב:
CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe.
Quoted 15 lines · On 6/6/2024 2:33 PM, [email protected] wrote:
From: Shai Brandes <[email protected]>
Replaced
enable_llq,normal_llq_hdrandlarge_llq_hdrdevargs with a new shared devarg namedllq_policythat implements the same logic and accepts the following values:
0 - Disable LLQ.
Use with extreme caution as it leads to a huge performance degradation on AWS instances from 6th generation onwards.
1 - Accept device recommended LLQ policy (Default).
Device can recommend normal or large LLQ policy.
2 - Enforce normal LLQ policy.
3 - Enforce large LLQ policy.
Required for packets with header that exceed 96 bytes on AWS instances prior to 5th generation.
Quoted 3 lines
Signed-off-by Shai Brandes <[email protected]>Reviewed-by Amit Bernstein <[email protected]>
Hi Shai,
This patch changes device parameters and impacts end user. Although this is not part of ABI policy, and we don't have an explicit policy around it, but since it may impact end user experience, would you be OK to postpone this patch to v24.11 release, where ABI break is planned?