selftests/pidfd: Fix wrong expectation
PATCH 7/10 selftests/pidfd: Fix wrong expectation
From: Mickaël Salaün <[email protected]>
Replace a wrong EXPECT_GT(self->child_pid_exited, 0) with EXPECT_GE(), which will be actually tested on the parent and child sides with a following commit.
Cc Shuah Khan <[email protected]>
Reviewed-by Kees Cook <[email protected]>
Reviewed-by Christian Brauner <[email protected]>
Signed-off-by Mickaël Salaün <[email protected]>
--- tools/testing/selftests/pidfd/pidfd_setns_test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tools/testing/selftests/pidfd/pidfd_setns_test.c +1 -1
@@ -158,7 +158,7 @@ FIXTURE_SETUP(current_nsset)/* Create task that exits right away. */ self->child_pid_exited =create_child (&self->child_pidfd_exited,CLONE_NEWUSER |CLONE_NEWNET ); -EXPECT_GT (self->child_pid_exited,0 ); +EXPECT_GE (self->child_pid_exited,0 );if (self->child_pid_exited ==0 )_exit (EXIT_SUCCESS );
Signature · 1 line
2.39.2
Quoted 11 lines · Okan Tümüklü
From: Mickaël Salaün <[email protected]>
Replace a wrong
EXPECT_GT(self->child_pid_exited, 0)withEXPECT_GE(), which will be actually tested on the parent and child sides with a following commit.Cc Shuah Khan <[email protected]>Reviewed-by Kees Cook <[email protected]>Reviewed-by Christian Brauner <[email protected]>Signed-off-by Mickaël Salaün <[email protected]>
FYI - This patch is already in the mainline.
commit 821bc4a8fd2454ff6d719aae7cac93f60567fe65
Author: Mickaël Salaün <[email protected]> Date: Sat May 11 19:14:42 2024 +0200
selftests/pidfd: Fix wrong expectation
Replace a wrong EXPECT_GT(self->child_pid_exited, 0) with EXPECT_GE(), which will be actually tested on the parent and child sides with a following commit.
Cc Shuah Khan <[email protected]>
Reviewed-by Kees Cook <[email protected]>
Reviewed-by Christian Brauner <[email protected]>
Signed-off-by Mickaël Salaün <[email protected]>
thanks,
-- Shuah