Skip to contentSkip to conversation

selftests/pidfd: Fix wrong expectation

PATCH In review Okan Tümüklü 2 participants 2 messages Jun 6, 2024 – Jun 7, 2024

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 7/10 selftests/pidfd: Fix wrong expectation

From: Mickaël Salaün <[email protected]>

Replace a wrong EXPECT_GT(self->child_pid_exited, 0) with EXPECT_GE(), which will be actually tested on the parent and child sides with a following commit.

---
 tools/testing/selftests/pidfd/pidfd_setns_test.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/testing/selftests/pidfd/pidfd_setns_test.c +1 -1
index 6e2f2cd400ca..47746b0c6acd 100644
@@ -158,7 +158,7 @@ FIXTURE_SETUP(current_nsset)
 	/* Create task that exits right away. */
 	self->child_pid_exited = create_child(&self->child_pidfd_exited,
 					      CLONE_NEWUSER | CLONE_NEWNET);
-	EXPECT_GT(self->child_pid_exited, 0);
+	EXPECT_GE(self->child_pid_exited, 0);
 
 	if (self->child_pid_exited == 0)
 		_exit(EXIT_SUCCESS);
Signature · 1 line
2.39.2
maintainer Reviewed-by Kees Cook Reviewed-by Christian Brauner on v1 7/10
#1 lore raw
Quoted 11 lines · Okan Tümüklü

From: Mickaël Salaün <[email protected]>

Replace a wrong EXPECT_GT(self->child_pid_exited, 0) with EXPECT_GE(), which will be actually tested on the parent and child sides with a following commit.

FYI - This patch is already in the mainline.

commit 821bc4a8fd2454ff6d719aae7cac93f60567fe65

Author: Mickaël Salaün <[email protected]>
Date:   Sat May 11 19:14:42 2024 +0200

selftests/pidfd: Fix wrong expectation

Replace a wrong EXPECT_GT(self->child_pid_exited, 0) with EXPECT_GE(), which will be actually tested on the parent and child sides with a following commit.

thanks,
-- Shuah